From: Renjiang Han <quic_renjiang@quicinc.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] media: venus: pm_helpers: use opp-table for the frequency
Date: Fri, 4 Jul 2025 15:50:41 +0800 [thread overview]
Message-ID: <cee197ea-7403-4c1a-beb2-dd1fc9404cd5@quicinc.com> (raw)
In-Reply-To: <f87b6127-a416-45fe-8b17-bd32574e20a3@quicinc.com>
On 7/4/2025 3:21 PM, Renjiang Han wrote:
>
> On 6/12/2025 10:23 AM, Renjiang Han wrote:
>> Some platforms (such as qcs615 and sc7180) use the same core but have
>> different frequency tables. Using the opp-table allows us to separate
>> the core description from the frequency data and supports the use of
>> fallback compatibles.
>>
>> Reviewed-by: Vikash Garodia<quic_vgarodia@quicinc.com>
>> Reviewed-by: Bryan O'Donoghue<bryan.odonoghue@linaro.org>
>> Signed-off-by: Renjiang Han<quic_renjiang@quicinc.com>
>> ---
>> video core in QCS615 is same as that in SC7180, while the clock
>> frequency
>> corners are different. In such cases, the clock frequencies are better
>> represented in DT than static table in video driver. The patch make use
>> of OPP table in DT to choose the frequency corner to scale.
>>
>> Note:
>> Earlier discussion was concluded in [1] where it was agreed to rely on
>> opp-table for QCS615.
>>
>> [1]https://lore.kernel.org/linux-arm-msm/c9b83c8b-68d1-43bc-99d6-d2d2b9e445f4@oss.qualcomm.com/
>>
>> ---
>> Changes in v2:
>> - 1. Update message based on the review comment.
>> - Link to
>> v1:https://lore.kernel.org/r/20250610-use_freq_with_opp_table-v1-1-7339d690fd1a@quicinc.com
>> ---
>> drivers/media/platform/qcom/venus/pm_helpers.c | 58
>> +++++++++++++++-----------
>> 1 file changed, 34 insertions(+), 24 deletions(-)
> I’d appreciate any thoughts you might have on this.
>
This patch has already been picked up, please ignore last email.
--
Best Regards,
Renjiang
prev parent reply other threads:[~2025-07-04 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 2:23 Renjiang Han
2025-07-04 7:21 ` Renjiang Han
2025-07-04 7:50 ` Renjiang Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee197ea-7403-4c1a-beb2-dd1fc9404cd5@quicinc.com \
--to=quic_renjiang@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®