From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BE2C4338F for ; Sun, 1 Aug 2021 20:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7579C60524 for ; Sun, 1 Aug 2021 20:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231200AbhHAUQE (ORCPT ); Sun, 1 Aug 2021 16:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhHAUQD (ORCPT ); Sun, 1 Aug 2021 16:16:03 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2818EC0613D3 for ; Sun, 1 Aug 2021 13:15:55 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id f20-20020a9d6c140000b02904bb9756274cso3687268otq.6 for ; Sun, 01 Aug 2021 13:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SCcuT+0QFEZ5pOqaHiafc4eYwFnXV3Mc9ZkWxRnuv4g=; b=mJ2f92JQDFt1pBmeDfy6QwCC/24FTHxvojX4S87Nay0py4jAbAZmkYBpJNTaom4xZG rETVzy9y2Fhf5SToJ99K6hTMELQrKZdic4IYzKyyzcQkqXIJqDKWRGDD726wPYzUugYo FCTkE0/fwCGOzSqZcWvRCbc3TAMe7u6Yrccs0Q+4u1VTGN7MKSdDAVrgq2iPt7aaIiKz mtqeHOUAApCrGEWiexIwpEUbzoBbG1NE5DOJkdDp5mB4YaAy5i2LHuLNWEJfl6119PFy LrFNxxe6hYUALCAlEVXaVLInDnqYD5JnRkS1lupu3LEOja+DC9myZI5afm+fKk+abad5 LIJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SCcuT+0QFEZ5pOqaHiafc4eYwFnXV3Mc9ZkWxRnuv4g=; b=CIJnU8hNA5INJ9eYjsuQhJuJS5xjOmPF9C28VlNgnKKSg+7ttsrfmNSdDt6+QGSwz5 se3HXJ5qpqVlLjYQkVrYUceWFB7c6z4rmIs4hdYKOHU2jZa8fhR1OdoEQwuV9heROepk KFEFqC2S921E7qBpBbCC5TtL9c9o7HMqBbyrj5iv1M3sGtHVTqgzH+EsgNg0+sf7DNMS ZAeE00ShG4S1HIL9g+euHazMgTT2CVIHOFfN67M0tVXKKkC+z9j/Wo7bRn+7xF0dW7YE Ka8VxwgJFX7sZWnp+XQvcqUnTccb4TH0LNh3wKjqlzn4Ce9vC886ZU46/sC8fBegF21u zH7Q== X-Gm-Message-State: AOAM533dmJOt5z6rSli7+r+UX364w9d0SnurHiWSrUlSRA7bSTaZwQPr /LZOra7+9A6nPBdFnljxLQAGpbt2qew= X-Google-Smtp-Source: ABdhPJwfZu1KdxekaGhoKyzE8lIqVR10w8bh5dnOkdP0NeE5LOBo3GzXlbiZcbF9IQYFQAHlxGM1pQ== X-Received: by 2002:a9d:827:: with SMTP id 36mr9141079oty.322.1627848954542; Sun, 01 Aug 2021 13:15:54 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100a.res6.spectrum.com (2603-8090-2005-39b3-0000-0000-0000-100a.res6.spectrum.com. [2603:8090:2005:39b3::100a]) by smtp.gmail.com with ESMTPSA id u3sm1556498otg.15.2021.08.01.13.15.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Aug 2021 13:15:53 -0700 (PDT) Sender: Larry Finger Subject: Re: kernel BUG in new r8188eu To: Greg Kroah-Hartman Cc: LKML , linux-staging@lists.linux.dev References: <80042e9f-6811-38f3-010b-1c0951ba88db@lwfinger.net> From: Larry Finger Message-ID: Date: Sun, 1 Aug 2021 15:15:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote: > > I am worried that my "remove the wrapper" logic got something wrong > here, so if you could test the revert of that, I would appreciate it. > > I think I need to go buy one of these devices so I can test cleanups > locally... The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free() function"). Looking at it, the only difference between the original wrapper and the new code is that the wrapper zeros the len variable before the kfree() call, but making that change did not help. Reverting that patch restores the old behavior. There are lots of these on Ebay from $2.47 up with free shipping! Larry