From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B99317707 for ; Tue, 18 Nov 2025 13:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763472255; cv=none; b=pATxUQSgyWYQEzAUU8wjCatdUEcaBRnC7QmuD7c5W8Oa75Hptkm4LdZU/UpoYtzEvT8VBKZdIb+ci07aj0eHwZQg72UvY72NSc1Ri+S5xvSuQvHuGCSaPLejMxMXCgryYJ8LNI1ngmFtUIQoEF4ecvVUwQQpEJAiuEgoNorrvq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763472255; c=relaxed/simple; bh=YRPcOuCWyS3IkB/8T5kzemqn4zA4eRE3UPKIfdMgAGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KA4bTLZab0A4dwp9Hsctg9NJhQKDDXltUPeIHop7EO5Lq5V2GM5QAJ0xrS5QDp40M/7EnNed3/+joU2g1GV7AWr2CnjEvCLw0smwLasZ+tiBSVjlDD0os7ffz3dUjKZA70cECkB6iHd8QSPabIFB4yjSThAi7qIpHTQEKaV2+H8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VzmbQNtA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X+oGahCE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VzmbQNtA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X+oGahCE" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI6iAQa384611 for ; Tue, 18 Nov 2025 13:24:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mT3BS7HYX0OjxoOUzW62R+wISMMOs6OD7mkkhojAy3U=; b=VzmbQNtA4hDbL9no AJzSYpKX10KwzUrif06jiE/nsLfhDNC2rUzeyJsTjdGhvpt3duUHBzNcm0eZiFx7 KKLCxIbrdDlnynq4ahc+n8+2e6FjqbUaTTwaduw0STkDTNcFlCJZ77CLbZlP1dVr I/nPTCXSJjQuxpHkEFDcgCXAYfyzJCJm7OCeIjovfdMf/+yPV1ZoO/fp4BQ4x9q8 1EjHVfNhVgAjI35jYwutdCdlQbbMXsvTOKK1inOoqn2lXMCxh8y1qQiK+WX9vd85 WS2OF6Qjw8PQ96lL9ZWWuPw8s4G8W5Z7ftUOdnw+C0/2UcgP2P0YMwq1091l9kTS 2VgPKg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agag8jjk9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 13:24:12 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88248a197c5so12941206d6.2 for ; Tue, 18 Nov 2025 05:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763472252; x=1764077052; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mT3BS7HYX0OjxoOUzW62R+wISMMOs6OD7mkkhojAy3U=; b=X+oGahCEXfpgYhcckhr71ZLiVUonRG82h6Afw8Cg5NHv1jXA3bM+77TgrpKSDhAbNM Rn26VcWqXAkMdkP0ZLSGjRDQoR8EPNzmXnih7+X2QeDgHNrgqxmE4NObSeGuEYn0HSMQ i5CQGXJhhb5nZFSdqDzNbvG818PvMNvP/Z23XQ+C0nFKuYT5XH9b8R2sYk1noO1TZMAK NhbrHaA9UBvrdEz+WVydGVtRGB3bs5PMzI4ONk2wlbOLX1HptrsyyDBFjY2zfAAvBx88 JTqF4XSzRBWO4gYU0RKEdCPCkRXKEQXcu++X9WvRC4L0N2Q5haxH8ravWVkAVvmW0zLo W20A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763472252; x=1764077052; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mT3BS7HYX0OjxoOUzW62R+wISMMOs6OD7mkkhojAy3U=; b=sv1EZjSea0m8Yw5ij0uQp1MFaB54+BhCvLn5AVvFIxdkkzz8T35jvCqb5bs+vtXgGg 6jpD5HCZYCxpZiYOAe4fnx+bBQ8CnihB08KXgaEndFpJpenHMarLxAHQ4cjEJlk2MM7t KYxYXfXBTRouoHDps+bDke99GrPdsgzH58nD8eWcHcRvD1UsIzHMTfUJMj3IA0Ip4Pn2 8HGoNEkMePqrQGScdEic9vNpU61gI1XoBy1BUAZ8oXE4YSZsKRoySUWB2QJ31bxoVwlV pQHIuddzmUrztiokStAKP/YNFO4LXa80xnVloas64eGa+fVQe9qxdZwZGUBghju8IvWl X3qw== X-Forwarded-Encrypted: i=1; AJvYcCV150aTSyOcCupr4i++PzzGfTRz3/jIrig5+XC3RjOjgK1Lw8kTlqGW2w63kNVDcPN/jKfAfeeycexwot8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4hMwGWczfkwzu3KJUVo+H6nb79Pb8OT2xJJ0JN2sTMdCh92Nc 3TFk6iXe/3U1+zb8tnQkIC8Ks3T9rUwbuvEE+EiDhsdHayp6CXFHRjyx0oqKtIZOw7t+5DdkN1+ 0SrHd9P5oRUmDRcANc7h4xRu0WWFT2WgEBVvkVtJ3pcf7ocj2vnpLDj//jmLHCTSRYNg= X-Gm-Gg: ASbGncv95F1+SBG5SGYmnyNGeQhyXdoYdQE94Wb0lIjo2zYZFUhzpNBfZHaOZtl/OdG idAsGAB+VNrFUtG5kR6MklJ2+aNTGZZv0SCWsjHjHsa2UiHuG9P4q9X78K2diBWAsaV3oDl+jBA apu0YVbBb41bUUYXX8+AZQJtT+vmDPdhMVYY5QBZgWpYsmiGtxjp2DR7DG5yzvWM8Hp90LDNZGW DUVi304pm2vY95KLZnpZwzKgYjjUK5DFsfrNhe0JOPF7ThwOcq7GUVSnqnwGleJk37BVYkLJK92 SaEzPzrilGg2QMADM417odrDRsFE3ljFdgDisC6gcblqDNVUDPd94z0ZjiQxvVEUwgxfoShBf2z c+fSo5tkvDTHDQhPMoingX5z1F+AFKZiaALrktQhhD1htjXMI5lmIyqYB3+Hr2gTKlR/YZQ== X-Received: by 2002:a0c:bf42:0:b0:883:7783:9a with SMTP id 6a1803df08f44-88377832e51mr89995676d6.0.1763472251567; Tue, 18 Nov 2025 05:24:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRqlXLxm47/RUttNlD6ATYs2pNgJfsISYFm460SZi5po+LnzWhSuIw5Ny6ZU54jqrLTKE3LQ== X-Received: by 2002:a0c:bf42:0:b0:883:7783:9a with SMTP id 6a1803df08f44-88377832e51mr89995376d6.0.1763472251012; Tue, 18 Nov 2025 05:24:11 -0800 (PST) Received: from [10.111.165.185] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-882865bdc76sm113493986d6.55.2025.11.18.05.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 05:24:10 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 21:24:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support To: Krzysztof Kozlowski , Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, quic_jiaymao@quicinc.com, Konrad Dybcio , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, cheng.jiang@oss.qualcomm.com, devicetree@vger.kernel.org, Bjorn Andersson , quic_shuaz@quicinc.com, quic_chezhou@quicinc.com References: <20251113130519.2647081-1-wei.deng@oss.qualcomm.com> <176313578860.3262114.17056319042303889483.robh@kernel.org> <0428a5a5-fd4e-4309-9b28-f94664177692@kernel.org> Content-Language: en-US From: Wei Deng In-Reply-To: <0428a5a5-fd4e-4309-9b28-f94664177692@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: X0PHuiD_D8KiTTyI30XR9JW4wBggYW69 X-Proofpoint-ORIG-GUID: X0PHuiD_D8KiTTyI30XR9JW4wBggYW69 X-Authority-Analysis: v=2.4 cv=G6sR0tk5 c=1 sm=1 tr=0 ts=691c737c cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=tldeaCnzwUXVKdrmyTgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDEwNiBTYWx0ZWRfX2kEF+jvZd5B5 3dR4i+UIXI9aCxugvw7ci2YfnKRXoSvm0QdSZu4kaCVBHki3U2N9T/dmqswyJ9RwPLzE6s/aGeb DjWHVztk7uLDrtSVKFqlsHQB/8gUOV6V0SwYXDN8d2J+ve2Garw0rW3Qmb4FZdA0xI9bFhUc1v6 i4gb2QMFzIZU5Y8zRKhd0gXaYuF4vW5Px/VsFZQZ2noB+tiKyIo8y2AvAdMkpQ6t04kgcHiBPWn S/a+Ne1IyjejhzXSq//6hmvSDhUgk+W9AN6xwaAiJuS+JEU7E7jYFV7VO4puwsdAo8ZtPBunfrf GGAClM0RL7FAzFoojW9qwjY3YdIEMZzRaRdGhm4TwG5UyxrEd9wpuZhWmMM6DAzgjDG60vUyT+W XbwWUdnTXxQdXUpH/BCu2CmoYgH8nA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180106 Hi Krzysztof, Thanks for your comments. On 11/18/2025 3:19 PM, Krzysztof Kozlowski wrote: > On 18/11/2025 08:07, Wei Deng wrote: >> Hi Rob, >> >> Thanks for your comments. >> >> On 11/15/2025 12:18 AM, Rob Herring wrote: >>> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) wrote: >>>> >>>> >>>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote: >>>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make >>>>> Bluetooth work, we need to define the necessary device tree nodes, >>>>> including UART configuration and power supplies. >>>>> >>>>> Since there is no standard M.2 binding in the device tree at present, >>>>> the PMU is described using dedicated PMU nodes to represent the >>>>> internal regulators required by the module. >>>>> >>>>> The module provides a 3.3V supply, which originates from the >>>>> main board’s 12V rail. To represent this power hierarchy in the device >>>>> tree, add a fixed 12V regulator node as the DC-IN source and link it >>>>> to the 3.3V regulator node. >>>>> >>>>> Signed-off-by: Wei Deng >>>>> --- >>>>> arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++ >>>>> 1 file changed, 99 insertions(+) >>>>> >>>> >>>> >>>> My bot found new DTB warnings on the .dts files added or changed in this >>>> series. >>>> >>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings >>>> are fixed by another series. Ultimately, it is up to the platform >>>> maintainer whether these warnings are acceptable or not. No need to reply >>>> unless the platform maintainer has comments. >>>> >>>> If you already ran DT checks and didn't see these error(s), then >>>> make sure dt-schema is up to date: >>>> >>>> pip3 install dtschema --upgrade >>>> >>>> >>>> This patch series was applied (using b4) to base: >>>> Base: attempting to guess base-commit... >>>> Base: tags/next-20251112 (exact match) >>>> Base: tags/next-20251112 (use --merge-base to override) >>>> >>>> If this is not the correct base, please add 'base-commit' tag >>>> (or use b4 which does this automatically) >>>> >>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com: >>>> >>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$' >>>> from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml >>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property >>>> from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml >>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property >>>> from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml >>> >>> This is the 3rd report of your typos. Is there some reason you are >>> ignoring the reports? >>> >> >> Sorry for the delayed response. These warnings are worth addressing >> and will be resolved in the next patch. >> > > > Three of your patchsets have bugs easily pointed out by tools, so please > answer - are you ignoring the reports? Are you doing any tests before > sending? > Testing was completed on the local hardware platform with successful compilation and normal functionality, so the tests in this section were omitted. Prior to the next submission, a dt-binding constraint check will be performed. > Best regards, > Krzysztof -- Best Regards, Wei Deng