From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0886C001DB for ; Mon, 7 Aug 2023 07:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbjHGHnO (ORCPT ); Mon, 7 Aug 2023 03:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjHGHnL (ORCPT ); Mon, 7 Aug 2023 03:43:11 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5352010D4; Mon, 7 Aug 2023 00:43:09 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VpBxhTy_1691394185; Received: from 30.97.48.53(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VpBxhTy_1691394185) by smtp.aliyun-inc.com; Mon, 07 Aug 2023 15:43:06 +0800 Message-ID: Date: Mon, 7 Aug 2023 15:43:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/5] dma: delect redundant parameter for dma driver function To: Kaiwei Liu , Vinod Koul , Orson Zhai , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kaiwei liu , Wenming Wu References: <20230807051907.2713-1-kaiwei.liu@unisoc.com> From: Baolin Wang In-Reply-To: <20230807051907.2713-1-kaiwei.liu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/7/2023 1:19 PM, Kaiwei Liu wrote: > The parameter *sdesc in function sprd_dma_check_trans_done is not > used, so here delect redundant parameter. > > Signed-off-by: Kaiwei Liu The subject line should be "dmaengine: sprd: xxx", and please also change all your following patches. With subject line fixed, you can add: Reviewed-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index 2b639adb48ba..20c3cb1ef2f5 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -572,8 +572,7 @@ static void sprd_dma_stop(struct sprd_dma_chn *schan) > schan->cur_desc = NULL; > } > > -static bool sprd_dma_check_trans_done(struct sprd_dma_desc *sdesc, > - enum sprd_dma_int_type int_type, > +static bool sprd_dma_check_trans_done(enum sprd_dma_int_type int_type, > enum sprd_dma_req_mode req_mode) > { > if (int_type == SPRD_DMA_NO_INT) > @@ -619,8 +618,7 @@ static irqreturn_t dma_irq_handle(int irq, void *dev_id) > vchan_cyclic_callback(&sdesc->vd); > } else { > /* Check if the dma request descriptor is done. */ > - trans_done = sprd_dma_check_trans_done(sdesc, int_type, > - req_type); > + trans_done = sprd_dma_check_trans_done(int_type, req_type); > if (trans_done == true) { > vchan_cookie_complete(&sdesc->vd); > schan->cur_desc = NULL;