From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752276AbdFTPXN (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 11:23:13 -0400
Received: from mga07.intel.com ([134.134.136.100]:23438 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751106AbdFTPXM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 11:23:12 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; 
   d="scan'208";a="116656224"
Subject: Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during
 per-process profiling of STREAM benchmark on Intel Xeon Phi
To: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
        Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
        Valery Cherepennikov <valery.cherepennikov@intel.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
References: <09226446-39b9-9bd2-d60f-b9bb947987c5@linux.intel.com>
 <20170615195618.GA8807@leverpostej>
 <162b1822-06b7-30e0-073c-911ba99b33b7@linux.intel.com>
 <20170620133624.GF28157@leverpostej>
From: Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <cef8113c-0da8-d99e-ac37-7d21af78c0e0@linux.intel.com>
Date: Tue, 20 Jun 2017 18:22:56 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170620133624.GF28157@leverpostej>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20.06.2017 16:36, Mark Rutland wrote:
> On Mon, Jun 19, 2017 at 11:31:59PM +0300, Alexey Budankov wrote:
>> On 15.06.2017 22:56, Mark Rutland wrote:
>>> On Thu, Jun 15, 2017 at 08:41:42PM +0300, Alexey Budankov wrote:
>>>> +static int
>>>> +perf_cpu_tree_iterate(struct rb_root *tree,
>>>> +		perf_cpu_tree_callback_t callback, void *data)
>>>> +{
>>>> +	int ret = 0;
>>>> +	struct rb_node *node;
>>>> +	struct perf_event *event;
>>>> +
>>>> +	WARN_ON_ONCE(!tree);
>>>> +
>>>> +	for (node = rb_first(tree); node; node = rb_next(node)) {
>>>> +		struct perf_event *node_event = container_of(node,
>>>> +				struct perf_event, group_node);
>>>> +
>>>> +		list_for_each_entry(event, &node_event->group_list,
>>>> +				group_list_entry) {
>>>> +			ret = callback(event, data);
>>>> +			if (ret)
>>>> +				return ret;
>>>> +		}
>>>> +	}
>>>> +
>>>> +	return 0;
>>>>   }
>>>
>>> If you need to iterate over every event, you can use the list that
>>> threads the whole tree.
>>
>> Could you please explain more on that?
> 
> In Peter's original suggestion, we'd use a threaded tree rather than a
> tree of lists.
> 
> i.e. you'd have something like:
> 
> struct threaded_rb_node {
> 	struct rb_node   node;
> 	struct list_head head;
> };

Is this for every group leader? Which objects does the head keep?

> 
> ... with the tree and list covering all nodes, in the same order:
> 
> Tree:
> 
>       3
>      / \
>     /   \
>    1     5
>   / \   / \
> 0   2 4   6
> 
> List:
> 
> 0 - 1 - 2 - 3 - 4 - 5 - 6
> 
> ... that way you can search using the tree, and iterate using the list,
> even when you wan to iterate over sub-lists.
> 
> Thanks,
> Mark.
>