From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A723422611 for ; Wed, 8 Jan 2025 23:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736378598; cv=none; b=AsZDbk8p1iKgxcm429/cWoOwTYUYZ4t4NCakECOu3vZMTM4gTzcXB7P44xAJyqewXuUYNe3F6LZiQUx3jm1B+sw5pMH8Lb526FjYKkVptWju6MPWQ+0YmkA2o4boxgZ96Cgk4s2FcpEnSk5iKUSLBlzGOfRqmPz2pFzxUfPX5VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736378598; c=relaxed/simple; bh=YWSZYRuIOr1i0hoeKfTzR3n/6mxUtpAWZAjkf1WBpuA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MqHus8x5gPrdsVNRXmqiU2P/aNSEv3I+QsTCo9oD5hh62RTDDnDvRL2xPyf3rjufpzwnsyIX+66AGQEFiUz2ArBhnV7dGzhlQarpKCeTntVzFrY27Ewkv5YGcaoEvorjGAQiPuc3chWXndz9fNBaUQyr95K+dGWhzxbRmhQ33cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aCHxWQpe; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aCHxWQpe" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-844e61f3902so22617639f.0 for ; Wed, 08 Jan 2025 15:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1736378596; x=1736983396; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mzn00ZfytrdNeZqAzFwZC/i104dlV8ULO69Ct63d0jQ=; b=aCHxWQpe1U8lCoxJ2h5T7EAL3UgufVBTDu4pdxw4ff4ei6K+kSPetr8zwIHcH33UPY /i1O51okqj3lBpu5XJ2O3NMdUEDtRLhiv89Fdh5Jm79C69YTM/KilCd21e3AplqecCHR jYmtGWgyids9x9SNQfqi9QuMkGOip2h+UTE9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736378596; x=1736983396; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mzn00ZfytrdNeZqAzFwZC/i104dlV8ULO69Ct63d0jQ=; b=OgxmVfr3j8lQaeU3sreFAWJWMboFl/ZOeQTfBJQEWMXl8tmCLoymbVb59DUKhvTN5z HO/x6qPg22sFF+kdCq/K4Ol8NpQnICwprEdYHS4dMiWMTEo5nMcehI8IhbQfV39WINoR sUKVc2S0nBRVNIqfWWcxCyp2ANgsyVB4aI/ZCY/pgKXqapDwC2gp5BnqEYGpgA7yx/hS tzVWY3dG8JCOg9jglavogmUBhgTLBHcTzApySU13Tb3cfiMlzpQ+8+NP8hF9V8It6Aim nVrf83wEcZLqNFqoxtCshnkvAZVRjAJCtYqy+lsTgMaHg4hNvR+a+sGw/xkNhvlg2Mhq C2Uw== X-Forwarded-Encrypted: i=1; AJvYcCU+2FUlkHD8wtPddCrcCEPnmd7yGqUNiUJAVGyr9CX1klRDgO+QCrNUc+gHuvQfAZu9K4wAur+iJ9wtYz8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7TQMfg7NI+YqNP+FROSIwhdBkWPxG9Yj3eE7wazXfvCINsfn4 xTGBX34KzJCbHhN5jsjkaSRJ8DHz2J7XVHWoGpu763WXkgqD6Vluwi+CVXMQP44A3/Eb6BTmP86 B X-Gm-Gg: ASbGncuxmt89yS98e9HJPICjwK+4EHLKvaJtXapjxPi26KpVgSYt17ueuNjq2FOXFG4 z7vn9W5fGQYK5Wu99kRcc/U5zhL6Caih1YvS7tG8wVmWCX51bRwdu4gIUG++Gktm1swIumtQRYu yCSUtzDdqZ2ZBF6mMclKpvnYLpPZQ/4HXLTxxSj2eiTDCcCS5TUmu5x+mu86ccMdSBUymTxQ5h5 brjH0VGueFdFFGRlJAPzOEb3nrKUmr3bdnv+fPnx8avPZGRAyrYEj0cjnr3MjI+VsNa X-Google-Smtp-Source: AGHT+IGwSBFteg1yBzTr+ht0Vs+wiAvXeihmvJdKOSSEhZm+icx0U5LWV6uYJxFPhp36KnRBX2lrSA== X-Received: by 2002:a05:6602:6cc6:b0:843:e8d0:a728 with SMTP id ca18e2360f4ac-84ce0092d9dmr490122039f.4.1736378595899; Wed, 08 Jan 2025 15:23:15 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b6292ccsm18029173.73.2025.01.08.15.23.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 15:23:15 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 16:23:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: harness: fix printing of mismatch values in __EXPECT() To: Kees Cook , "Dmitry V. Levin" Cc: Shuah Khan , Gabi Falk , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20250108170757.GA6723@strace.io> <202501081357.BE10EC4403@keescook> Content-Language: en-US From: Shuah Khan In-Reply-To: <202501081357.BE10EC4403@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/8/25 14:57, Kees Cook wrote: > On Wed, Jan 08, 2025 at 07:07:57PM +0200, Dmitry V. Levin wrote: >> intptr_t and uintptr_t are not big enough types on 32-bit architectures >> when printing 64-bit values, resulting to the following incorrect >> diagnostic output: >> >> # get_syscall_info.c:209:get_syscall_info:Expected exp_args[2] (3134324433) == info.entry.args[1] (3134324433) >> >> Replace intptr_t and uintptr_t with intmax_t and uintmax_t, respectively. >> With this fix, the same test produces more usable diagnostic output: >> >> # get_syscall_info.c:209:get_syscall_info:Expected exp_args[2] (3134324433) == info.entry.args[1] (18446744072548908753) >> >> Fixes: b5bb6d3068ea ("selftests/seccomp: fix 32-bit build warnings") >> Signed-off-by: Dmitry V. Levin > > Ah nice, thanks! > > Reviewed-by: Kees Cook > Thank you. Applied to linux-kselftest next for Linux 6.14-rc1. thanks, -- Shuah