From: Lucas Stach <l.stach@pengutronix.de>
To: Richard Zhu <hongxing.zhu@nxp.com>,
bhelgaas@google.com, lorenzo.pieralisi@arm.com
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH] PCI: imx6: Invoke the PHY exit function after PHY power off
Date: Wed, 16 Mar 2022 10:37:55 +0100 [thread overview]
Message-ID: <cf0943a1144e91048fc88fe9b11660bafe1a2d8d.camel@pengutronix.de> (raw)
In-Reply-To: <1646289275-17813-1-git-send-email-hongxing.zhu@nxp.com>
Am Donnerstag, dem 03.03.2022 um 14:34 +0800 schrieb Richard Zhu:
> To balance phy->init_count, invoke the phy_exit() after phy_power_off().
>
This looks okay as a fix, but overall I don't like that we need to have
special PHY handling in the suspend path and PHY init hidden in
imx6_pcie_assert_core_reset() in the resume path. Maybe we can make
this PHY handling a bit more obvious by splitting it out of the core
reset sequence. I don't see the full implications of such a change yet,
but I think we should at least give it a try.
For now, this patch is:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Fixes: 178e244cb6e2 ("PCI: imx: Add the imx8mm pcie support")
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 331490614d55..343fe1429e3c 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -973,6 +973,7 @@ static int imx6_pcie_suspend_noirq(struct device *dev)
> case IMX8MM:
> if (phy_power_off(imx6_pcie->phy))
> dev_err(dev, "unable to power off PHY\n");
> + phy_exit(imx6_pcie->phy);
> break;
> default:
> break;
next prev parent reply other threads:[~2022-03-16 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 6:34 Richard Zhu
2022-03-16 9:37 ` Lucas Stach [this message]
2022-03-17 0:29 ` Hongxing Zhu
2022-03-17 8:58 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0943a1144e91048fc88fe9b11660bafe1a2d8d.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®