mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)
Date: Thu, 21 Feb 2019 21:48:17 +0100	[thread overview]
Message-ID: <cf0a7334-c347-b254-f80d-93640f201b20@linaro.org> (raw)
In-Reply-To: <20190221160648.29785-1-david.abdurachmanov@gmail.com>

On 21/02/2019 17:06, David Abdurachmanov wrote:
> Resending to incl. a proper mailing list and maintainers (not suggested
> by scripts/get_maintainer.pl)
> 
> This is only used on arm and arm64 platforms. Other timers also seem
> to depend on (ARM || ARM64).
> 
> After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
> add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  drivers/clocksource/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index a9e26f6a81a1..7593d80e1c88 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
>  
>  config ARM_TIMER_SP804
>  	bool "Support for Dual Timer SP804 module"
> -	depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
> +	depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP

What about adding the COMPILE_TEST option:

bool "Support for Dual Timer SP804 module" if COMPILE_TEST

but not add the ARM || ARM64 dependency ?

>  	select CLKSRC_MMIO
>  	select TIMER_OF if OF
>  
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2019-02-21 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 16:06 David Abdurachmanov
2019-02-21 20:48 ` Daniel Lezcano [this message]
2019-02-21 21:43   ` David Abdurachmanov
2019-02-22  8:22     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf0a7334-c347-b254-f80d-93640f201b20@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=david.abdurachmanov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®