From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE7629B200 for ; Wed, 10 Jun 2026 16:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781109055; cv=none; b=rDsy5fzBvQE/vcdyLewJb1oH2SR9RNQqmMl7el6mDuf8YwBfYOMt+H5i/NbQHQVNd3bpfwP8dpHbAcI2cRn3ql9dUW9tgjyOF+MA75+vXVBgzNbz9iiNS6Y3nxcZpjwN2Wqn2sXHMW2K0u9FoGJOT43ZBkKWl/BVEEttAA1YNUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781109055; c=relaxed/simple; bh=Kwb5LYuaX+oOnELrTWQjyRTelc2HIC+FXt+Mqu7f6Qg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RPge2AcHY65MRBL3ZKLzJBaqjNSUHKkUsLngHCjcGRkbmWvHMRzo3cBeUdr3x6vGltgz8IrX0x14IrEKX9ccq/qxjv3MXIIPZSrYAA+H4xfHYg+p7DPAmWHIZihNBUUp2CyK0fpZQjlgj6AVgmUMolSOZH+U7jZQcOJLXLN7e+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=NFT2fZ9M; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="NFT2fZ9M" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4gbB994gVqzlh2gF; Wed, 10 Jun 2026 16:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1781109049; x=1783701050; bh=E7qwsXUcQPu7hw7Z8iRm24KX zEKGp8hR4nmn0gcSu7g=; b=NFT2fZ9MxlaUOk1IaGSvtwM/FrMmUmM8+aD60fUM T1+dD/MKy220665obmDNlR2EM2/ymwVq7MPl83ViuyQdPULsYPuzKAAUsTfpL8KR OGQHUdFQXdxVeBjsa7tawRFouaGTH7PbcebZQj8rvu9bGTNlEKxRfrWzo8qG+rEr TZ/+yoCtmfsio21AVJ/gI+68pq3ilwVAAoDkRezQ7ugXJi/B7Mflkr038xRHNuAW F/8CoRf6TAaE/8XjNvSAayD5/F9PMU0CcOln3WDYLUZALey8X6btfJdS4Tf6gZCe kxMZP2YD/Teo/i9j8NG1Lm6kprnTUbBdF2BxeydeFopiEQ== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id pJH2jIy-c6AM; Wed, 10 Jun 2026 16:30:49 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4gbB932jlDzlgyGc; Wed, 10 Jun 2026 16:30:47 +0000 (UTC) Message-ID: Date: Wed, 10 Jun 2026 09:30:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/15] nvme: add Clang context annotations for nvme_subsystems_lock To: Nilay Shroff , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, elver@google.com, gjoyce@linux.ibm.com References: <20260610142743.115898-1-nilay@linux.ibm.com> <20260610142743.115898-10-nilay@linux.ibm.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260610142743.115898-10-nilay@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/10/26 7:27 AM, Nilay Shroff wrote: > - INIT_LIST_HEAD(&subsys->ctrls); > + /* > + * Initializing subsys->ctrls list doesn't need to be protected > + * using @nvme_subsystems_lock. So suppress the Clang's warning > + * declaring context_unsafe. > + */ > + context_unsafe(INIT_LIST_HEAD(&subsys->ctrls)); Why context_unsafe() instead of scoped_guard(mutex_init, ...)? Thanks, Bart.