From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 2/2] nvmem: imx-ocotp-ele: Support accessing controller for i.MX9
Date: Fri, 13 Dec 2024 08:52:49 +0100 [thread overview]
Message-ID: <cf153dd6-f82c-47d9-9ab4-f247437d607e@kernel.org> (raw)
In-Reply-To: <20241212-imx-ocotp-v1-2-198bb0af86a0@nxp.com>
On 12/12/2024 09:24, Peng Fan (OSS) wrote:
> +
> + if (imx_ele_ocotp_check_access(pdev, id)) {
> + of_detach_node(child);
> + dev_err(dev, "%s: Not granted, device driver will not be probed\n",
> + child->full_name);
> + }
> + }
> +
> + imx_ele_ocotp_grant_access(pdev, child);
> + }
> +
> + return 0;
> +}
> +
> +static int imx_ele_ocotp_access_control(struct platform_device *pdev)
> +{
> + struct imx_ocotp_priv *priv = platform_get_drvdata(pdev);
> + struct device_node *soc __free(device_node) = of_find_node_by_path("/soc");
No, you just created undocumented ABI on the name.
Drop/replace or express the ABI (which is impossible, so basically: drop).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-13 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 8:24 [PATCH 0/2] Make i.MX9 OCOTP work as accessing controller Peng Fan (OSS)
2024-12-12 8:24 ` [PATCH 1/2] dt-bindings: nvmem: imx-ocotp: Introduce #access-controller-cells Peng Fan (OSS)
2024-12-12 17:39 ` Frank Li
2024-12-12 8:24 ` [PATCH 2/2] nvmem: imx-ocotp-ele: Support accessing controller for i.MX9 Peng Fan (OSS)
2024-12-12 17:45 ` Frank Li
2024-12-13 4:11 ` Peng Fan
2024-12-13 7:52 ` Krzysztof Kozlowski [this message]
2024-12-13 19:11 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf153dd6-f82c-47d9-9ab4-f247437d607e@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®