From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4274C43334 for ; Mon, 11 Jul 2022 04:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbiGKETr (ORCPT ); Mon, 11 Jul 2022 00:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiGKETp (ORCPT ); Mon, 11 Jul 2022 00:19:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A311F17A96 for ; Sun, 10 Jul 2022 21:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657513183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYSp6HlI0dDBIV/HDsecc6eKbJCd3YWkca9HdFglgEg=; b=LZM117yxang7gt+VslSpKs3tOfpvseM5MwRBI+HwZ7qPzH2Gd2NeOvQ1yTK9wBXIvghiW7 zMDAYsxgbD4uDHSFoyuQVw7Aag9SFVlOEF+4lSda1ekj2Rrb9dKtgoNMmJ5tOTF0sPKZf+ T4GXoYjBVZufAJzq196Yp4LqPR0K7fk= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-27-PUND9Je_OJaFQxYac_N1XA-1; Mon, 11 Jul 2022 00:19:39 -0400 X-MC-Unique: PUND9Je_OJaFQxYac_N1XA-1 Received: by mail-pg1-f200.google.com with SMTP id g34-20020a635662000000b0040d1da6ada4so1361315pgm.1 for ; Sun, 10 Jul 2022 21:19:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iYSp6HlI0dDBIV/HDsecc6eKbJCd3YWkca9HdFglgEg=; b=74yd5g5Mnx0pAmu25qr5LjG1lbHIC4KqILivydbVvWc7nxADPqHHp3JJCTyotdegZZ DH2F7se+EpimVNfiTDw5Dia2F8+CP39GE76BoCa2TGQjHcTd7tmVgVlsYmzOvNjt9wxx TrgYFUBrVEr6xwE2Ng1F2XGRueXVOGVLNYfg0CrVxfk2XMzaSP3ZLGE5oqCWwJyOScu1 Hy+h+NAN/Na46cJV2SMc7ekpMHVlSngVWmKx/H8RLESi6y3kL/1wCU86aBQXXGIzl4GT 7ONZEf/ZOkeX3U5+ZiM09k85thrX2SoIbsUTQYhZWHTE7kZFRcdQxTXjzD43eEsQWE9I nhWw== X-Gm-Message-State: AJIora+LZHZwQGllzan99DO71QAMw1uoouzdzXKnauhhG+tzrndg8JqY ibvzDXO2AktRB0uyvv/ME1VILeu/9k7lvysOGUnzVuhdBV4p4sFwbZuqUa+14fd9R3GLe7JEQZE 7+AQA8IFUXADDjK6b3RZWD6kT X-Received: by 2002:a63:2c47:0:b0:411:54ab:97b6 with SMTP id s68-20020a632c47000000b0041154ab97b6mr14206429pgs.173.1657513178582; Sun, 10 Jul 2022 21:19:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sdLoGKlY/5zCNt7vw/gv0lyzTZM8Mh6bsyCtyMbXMA0uNpORIFIeDfE5UALrqX7MSFep4+Rw== X-Received: by 2002:a63:2c47:0:b0:411:54ab:97b6 with SMTP id s68-20020a632c47000000b0041154ab97b6mr14206416pgs.173.1657513178370; Sun, 10 Jul 2022 21:19:38 -0700 (PDT) Received: from [10.72.14.22] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id h7-20020a170902f54700b0016be4d310b2sm3543056plf.80.2022.07.10.21.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Jul 2022 21:19:37 -0700 (PDT) Subject: Re: [PATCH v4] netfs: do not unlock and put the folio twice To: Matthew Wilcox , David Howells Cc: idryomov@gmail.com, jlayton@kernel.org, marc.dionne@auristor.com, keescook@chromium.org, kirill.shutemov@linux.intel.com, william.kucharski@oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cachefs@redhat.com, vshankar@redhat.com References: <20220707045112.10177-1-xiubli@redhat.com> <2520851.1657200105@warthog.procyon.org.uk> From: Xiubo Li Message-ID: Date: Mon, 11 Jul 2022 12:19:27 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/22 9:26 PM, Matthew Wilcox wrote: > On Thu, Jul 07, 2022 at 02:21:45PM +0100, David Howells wrote: >> - struct folio *folio, void **_fsdata); >> + struct folio **_folio, void **_fsdata); > The usual convention is that _foo means "Don't touch". This should > probably be named "foliop" (ie pointer to a thing that would normally > be called folio). > This looks good to me. I will send out the V5 by fixing this and will merge this patch via the ceph tree as discussed with David in the IRC and will cc the stable at the same time. Thanks! -- Xiubo