From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D013FC64E7A for ; Tue, 24 Nov 2020 09:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E9842158C for ; Tue, 24 Nov 2020 09:39:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IjLPdSae" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731572AbgKXJj2 (ORCPT ); Tue, 24 Nov 2020 04:39:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41890 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731559AbgKXJjW (ORCPT ); Tue, 24 Nov 2020 04:39:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606210760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZ7CehUUaEq2hmE1v+VaSFpw/raxtP/pGzbiD0suVXQ=; b=IjLPdSaeTP+fu24dGv9AviLrWCCzf5bsTJYZcQYjXQFLbZgjbOousTBMmccNGzkyT9fK2B uiOGfCA8xlKQr1BYs5HlClWX5S0KRE3pIzfzhN2Hr2iQ3r9Dyq1gGor7VmC/vKwyLnc7uU bCyVoTjo1Vv0/rUNlZ4Cc2qlZSqUYME= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-7l10wu_iNeWpmqQa5tvLCA-1; Tue, 24 Nov 2020 04:39:18 -0500 X-MC-Unique: 7l10wu_iNeWpmqQa5tvLCA-1 Received: by mail-ej1-f70.google.com with SMTP id a13so6288376ejv.17 for ; Tue, 24 Nov 2020 01:39:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HZ7CehUUaEq2hmE1v+VaSFpw/raxtP/pGzbiD0suVXQ=; b=oP6f7Kw/zmAx4UOo3UTm2pM+/iZ0SmUnTPLIOjBOLMy6n4d5hvpehCvQsBkkAFjCh/ WPPgoQZ3vGQm+HjzLrrxjis1IyUpglV+lPV3bd+cCKAmp5Ve1T0yQh7pGWIscJsZT+Kc 5+lutJ43yqvYO1Hz+zxlvccndPuuJpLRl2c9isJHcDE1qq5but/IRXuP2finl6czUILF bIhcJzs3EIp4vgrmNb2Wt/GITjnZ+HF/YwCknLXUFV1VFl/gk4+sWW4ufVPlRdJhUdjV AlPrd7hdjLu2MvdQ9LmFsquhsU9XhBMo19kot98dZhjdwCoegIgikVvzkn7uut0N2XVc ZffA== X-Gm-Message-State: AOAM530vHRtSun6bKfX7M3jnAZb4tIc7Sv4khpkj0wDk4UPzetd3vr3I xsjNX9l0hu5VOvAcw3P4A8VSHCO9gM8xJpKul0isp7UbWQ8FThx1wnU8AItgAXFtDWtVK5v7xTd +x7Pv1+t1bJTs7VZ+qWd6YWeD X-Received: by 2002:a17:906:490:: with SMTP id f16mr3571787eja.12.1606210757169; Tue, 24 Nov 2020 01:39:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbraEzTC/kvaLqVRH/B6BYCc6j8uc619geaDI8q7jzgkfCLJ33OwqhtWowfW9z4T0+41Z56g== X-Received: by 2002:a17:906:490:: with SMTP id f16mr3571777eja.12.1606210757001; Tue, 24 Nov 2020 01:39:17 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id v27sm6644321edl.82.2020.11.24.01.39.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 01:39:16 -0800 (PST) Subject: Re: [PATCH] input: soc_button_array: fix IRQ-related build errors To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: kernel test robot , Dmitry Torokhov , linux-input@vger.kernel.org References: <20201124001802.10094-1-rdunlap@infradead.org> From: Hans de Goede Message-ID: Date: Tue, 24 Nov 2020 10:39:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201124001802.10094-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 11/24/20 1:18 AM, Randy Dunlap wrote: > Fix these new build errors by adding : > > ../drivers/input/misc/soc_button_array.c: In function ‘soc_button_device_create’: > ../drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function ‘irq_set_irq_type’; did you mean ‘acpi_dev_get_irq_type’? [-Werror=implicit-function-declaration] > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > CC [M] drivers/rtc/rtc-ds1343.o > ../drivers/input/misc/soc_button_array.c:156:26: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function) > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > > Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Hans de Goede > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org Thank you for your fix, but Dmitry already send out the same fix yesterday, so your fix is a duplicate. Regards, Hans > --- > drivers/input/misc/soc_button_array.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20201123.orig/drivers/input/misc/soc_button_array.c > +++ linux-next-20201123/drivers/input/misc/soc_button_array.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include >