From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5CEA3382EC; Thu, 13 Aug 2026 09:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611798; cv=none; b=OX9QVhGunUXwMt+qfGue57hb2vsfsjIae2Bfrlz1xUaG/R4QRqyb+2k71nMCuYF4noJKlcE0dUf1U5KUBer15nW3MPvb2MCacKH1uTHSj5rd2kiDgEXOP6Qt6G5iLs8ZuouVFQTXWFVTFLl219CLGURWBP/gR8PDGaw6IA/zGHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611798; c=relaxed/simple; bh=ASUl725W4Q4DWrQQw4kPCv74EVhOJUa0nFeZmfx4frw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ce2A9f6tBXBqK5trFO3wVLUlnEanLW38zXC1icclrFLrGo6v3GtKysRFApzZ/mJV2o4IUCvumMPiGtZAzxVAbokL36F4LfA70FvXwX7wVfSU3iDxtEerlcx2cDSr6EcQSmONacG9cZ0ID8otytxdIphyWjIYf48BbqigXdQ1lok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ht27A/7P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ht27A/7P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FDD51F000E9; Thu, 13 Aug 2026 09:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786611797; bh=LIUCyI1DmaIJkYpbNrBXxcSosIT/TqoljgTn7CMHNp0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Ht27A/7P5ZRM0WD78BiwoVAkJUPSuCeoGk/qSh0fAfqEDbt6ctl9oMyLiVF+Hun6i XBqb5L1d73+0Cn+G1v0VIGTcNlz5xvFMWiWsCohYJVc4/XJc8Xh7l6sUzxw7R/PAjt Y6RtJsaWMb1C++ybFL5QSiIfsymIDEOnqI9nwfaqg/uK5YXCY2vrYQJeNgtXJ1q1vv 8OXR8rI41EOJsFLvcm8diDqtBsp0ZxlQwm6Tc+h1kTRZUQIBa701J1lUls8D3fM7MG nqW1qR8oD9I9Mnj5MU89/8czjzmiUK5gxy93eSDIn+Ph79+rwLbYJd9/1sBkxDSaI+ eM12gI05bVh0w== Message-ID: Date: Thu, 13 Aug 2026 11:03:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: lcdif: Add endpoint bus-width property To: Alexander Stein , Francesco Dolcini Cc: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Francesco Dolcini , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20260812132954.148571-1-francesco@dolcini.it> <20260813-classy-boa-of-apotheosis-57207e@quoll> <20260813083402.GA19687@francesco-nb> <7661119.LvFx2qVVIh@steina-w> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <7661119.LvFx2qVVIh@steina-w> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/08/2026 10:56, Alexander Stein wrote: > Am Donnerstag, 13. August 2026, 10:34:02 CEST schrieb Francesco Dolcini: >> On Thu, Aug 13, 2026 at 10:10:43AM +0200, Krzysztof Kozlowski wrote: >>> On Wed, Aug 12, 2026 at 03:29:49PM +0200, Francesco Dolcini wrote: >>>> From: Francesco Dolcini >>>> >>>> The DPI output of the LCD interface can be configured with a bus width >>>> of 16, 18, or 24 bits. Introduce a bus-width property to the output >>>> endpoint, specifying the number of parallel RGB bits connected. >>>> >>>> Signed-off-by: Francesco Dolcini >>>> --- >>>> v3: use video-interfaces.yaml >>>> v2: use the common bus-width property instead of the legacy interface-pix-fmt >>>> --- >>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> index 2dd0411ec651..1f3daf002707 100644 >>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> @@ -71,6 +71,15 @@ properties: >>>> $ref: /schemas/graph.yaml#/properties/port >>>> description: The LCDIF output port >>>> >>>> + properties: >>>> + endpoint: >>>> + $ref: /schemas/media/video-interfaces.yaml >>> >>> This won't work, you need to test your DTS. The port schema does not >>> allow video-interfaces properties. You need port-base, like in every >>> other case. >> >> Thanks for the review Krzysztof >> >> Given my testing was not ok, and I am not sure what I did wrong exactly >> on my tests, is this the change I should do? Yes >> >> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> index 1f3daf002707..89cea0c14cf1 100644 >> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> @@ -68,7 +68,8 @@ properties: >> maxItems: 1 >> >> port: >> - $ref: /schemas/graph.yaml#/properties/port >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> description: The LCDIF output port > > With that change: > Tested-by: Alexander Stein Please do not. Build testing is not testing (in the meaning of "Tested-by" tag), otherwise where is Rob's tested-by tag for all the patches he build tested? Best regards, Krzysztof