From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249EF22963A; Tue, 14 Jan 2025 11:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736853718; cv=none; b=XgmSGD1E73HUx/HA9rX4ixeF0HBt+onP/EzKEILq38fQY2CNjLwFzOU0xxVgwkxD9A1p5CZ0sKjjkaKdZJSjlAD1vmpDdurOj28Y77XYEr3umn1rkNtbPs+Q68iAMKR4+QlabN3ooxd3N4CwXgy+o5TMMy+/pWgnR5B+TQYb2NU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736853718; c=relaxed/simple; bh=0zEIL6u4SHqcJ/UmXchjPwnCB/2oWPGe6FVMyqAnMjg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=NErX/q80riubuWAoSsBbbU0gTsFZb4yrwx6loLPF2FHVdnP9Sxk5bfmZJT1ga/Sk4m50v4QWcGTFyalg7brQbS758pIMOWKceDV8KBhr4sOarLa+r3xRWVjEVGRVh2C1yxL1fzTryGiKEk028pUqPSdgMMt6YCc8/Ptkl3jo1z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Am4SVgIn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Am4SVgIn" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50E86JpM020662; Tue, 14 Jan 2025 11:21:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QlOdxO3OmanBBTk+Gz46nfFMr/I29UEEjRPNmLHpDK0=; b=Am4SVgInlAdYnbXR V9vS3ytz5xm/h0T/VT9tW8DlN/fCUohj21Q1eotZeEXE42PlC6lX9OG4cO3iJxmp pd5Vn806SuAYnNt0PaeqVQvaP3Z5E9jqqZLHx7MoNnubq93b1LXVh0ZxH8qCECt9 Oq3/2uBb64LPt2BJIxQw8Wus0F2CUyqJ4KuK/odspnwCOVsYbklX9Y/2JWzVZqok AhIukKctfiuv585h1szbhJRc5rE/jdYWFEx3NVMSrdmNglpWiq7VI0e3SO1qaUVa bNVK1Q1lkHtLCOB2GwH7dfloFcuo1UNaMPeitKhGWu6QQui/TQH3mxNRc3BJerrc Ji8xag== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 445m42gdt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jan 2025 11:21:38 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 50EBLbxk005570 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jan 2025 11:21:37 GMT Received: from [10.64.68.119] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 14 Jan 2025 03:21:31 -0800 Message-ID: Date: Tue, 14 Jan 2025 19:21:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] dt-bindings: display/msm: Document MDSS on QCS8300 To: Krzysztof Kozlowski , Dmitry Baryshkov CC: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , "Simona Vetter" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kuogee Hsieh , Vinod Koul , "Kishon Vijay Abraham I" , Bjorn Andersson , , , , , , References: <20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com> <20250113-mdssdt_qcs8300-v3-3-6c8e93459600@quicinc.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 8G77iWHE67xKFMIAseGtqeUg1yLxU39T X-Proofpoint-GUID: 8G77iWHE67xKFMIAseGtqeUg1yLxU39T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 clxscore=1011 lowpriorityscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501140095 On 2025/1/14 18:11, Krzysztof Kozlowski wrote: > On 14/01/2025 11:00, Dmitry Baryshkov wrote: >> On Tue, 14 Jan 2025 at 09:57, Krzysztof Kozlowski wrote: >>> >>> On Mon, Jan 13, 2025 at 04:03:10PM +0800, Yongxing Mou wrote: >>>> +patternProperties: >>>> + "^display-controller@[0-9a-f]+$": >>>> + type: object >>>> + additionalProperties: true >>>> + >>>> + properties: >>>> + compatible: >>>> + items: >>>> + - const: qcom,qcs8300-dpu >>>> + - const: qcom,sa8775p-dpu >>>> + >>>> + "^displayport-controller@[0-9a-f]+$": >>>> + type: object >>>> + additionalProperties: true >>>> + >>>> + properties: >>>> + compatible: >>>> + items: >>>> + - const: qcom,qcs8300-dp >>>> + - const: qcom,sm8650-dp >>> >>> Parts of qcs8300 display are compatible with sa8775p, other parts with >>> sm8650. That's odd or even not correct. Assuming it is actually correct, >>> it deserves explanation in commit msg. >> >> It seems to be correct. These are two different IP blocks with >> different modifications. QCS8300's DP configuration matches the SM8650 >> ([1]), though the DPU is the same as the one on the SA8775P platform. >> >> [1] https://lore.kernel.org/dri-devel/411626da-7563-48fb-ac7c-94f06e73e4b8@quicinc.com/ > > That's the driver, so you claim that qcs8300, which is a sa8775p, is not > compatible with sa8775p because of current driver code? You see the > contradiction? sa8775p is not compatible with sa8775p because of current > driver patch? > > I don't think it is correct, but let's repeat: if you think otherwise, > this should be explain in commit msg. > > Best regards, > Krzysztof Hi,let me explain this: qcs8300 uses the same DPU as sa8775p, which is DPU_8_4. Therefore, for the DPU driver, qcs8300 reuses the driver of sa8775p. However, for the DisplayPort controller of qcs8300, it's different with sa8775p. qcs8300 only supports one DisplayPort output port, while sa8775p has two DPUs and supports four DisplayPort outputs. Therefore, the DisplayPort controller driver of sa8775p cannot be reused for qcs8300. Additionally, the base offset of qcs8300's DisplayPort controller is the same as that of sm8650, so the DisplayPort controller reuses "qcom,sm8650-dp". I explained this in the commit messages of the previous two bindings, but it might not have been explained in the commit message of this patch.i will update the commit msg in next patchset.