From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167742AbdDXJOm (ORCPT ); Mon, 24 Apr 2017 05:14:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:40027 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1167703AbdDXJOR (ORCPT ); Mon, 24 Apr 2017 05:14:17 -0400 Subject: Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host To: Johannes Thumshirn , "Martin K . Petersen" References: <20170421121141.20701-1-jthumshirn@suse.de> Cc: Christoph Hellwig , Linux Kernel Mailinglist , Linux SCSI Mailinglist , James Bottomley , Jinpu Wang , John Garry From: Hannes Reinecke Message-ID: Date: Mon, 24 Apr 2017 11:14:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170421121141.20701-1-jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/21/2017 02:11 PM, Johannes Thumshirn wrote: > Move scsi_remove_host call into sas_remove_host and remove it from SAS HBA > drivers, so we don't mess up the ordering. This solves an issue with double > deleting sysfs entries that was introduced by the change of sysfs behaviour > from commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive"). > > Signed-off-by: Johannes Thumshirn > Suggested-by: Christoph Hellwig > Cc: Hannes Reinecke > Cc: James Bottomley > Cc: Jinpu Wang > Cc: John Garry > --- > drivers/scsi/aic94xx/aic94xx_init.c | 1 - > drivers/scsi/hisi_sas/hisi_sas_main.c | 1 - > drivers/scsi/isci/init.c | 1 - > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 - > drivers/scsi/mvsas/mv_init.c | 1 - > drivers/scsi/pm8001/pm8001_init.c | 1 - > drivers/scsi/scsi_transport_sas.c | 8 ++++++-- > 7 files changed, 6 insertions(+), 8 deletions(-) > Sadly, you've left out mptsas; that's still in use for VMWare installations. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)