From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759294Ab2CFOKO (ORCPT ); Tue, 6 Mar 2012 09:10:14 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:29969 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759254Ab2CFOKN (ORCPT ); Tue, 6 Mar 2012 09:10:13 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6640"; a="169751760" Message-ID: In-Reply-To: References: <4934441a17d25c3249556f7bf281b1be.squirrel@www.codeaurora.org> <6669559e86c1d13b27e941ff2acf89d2.squirrel@www.codeaurora.org> Date: Tue, 6 Mar 2012 06:10:12 -0800 (PST) Subject: Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device From: merez@codeaurora.org To: "Namjae Jeon" Cc: merez@codeaurora.org, "Seungwon Jeon" , linux-mmc@vger.kernel.org, "Chris Ball" , linux-kernel@vger.kernel.org User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi. Merez. > > Thanks a lot about your performance measurement. > > I think that your measurement is enough and correct and the firmware > of mmc vender should be optimized or change properly rather than > modifying the current patch. > > And currently we can use only write packed cmd by my suggestion. > > I would like to add my reviewd-by tag in updated patches also. > > Reviewed-by: Namjae Jeon > > Thanks. I tend to disagree. Adding a massive amount of code that would be disabled can be risky. In case this code will not be in use it will not be properly tested and its reliability will be uncertain. Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum