From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3C134DCE4 for ; Wed, 4 Feb 2026 05:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770181477; cv=none; b=Ria8E0LQrx7F9Dn32LMPvAO3pBSdAGKtYpw5ZxHzMsI/wsnqBk4lJ++qEo2AcHh7vDFyCB97vGrciZ2EENLHdqIk7rmPL8Ae3wlK/yXLoUECZ8iQDipTMTZ59YfKcf0df0mK7PIGhll6+cixUQ0vfJBawi68Ib2LepS5s29AX0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770181477; c=relaxed/simple; bh=XmFJIuFS/wd5AVgYfDUJizB7VVk4Xa+TsalDeRCDoW8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jLicXEOANYz2Bd3BWhVTbiUAM+mLGxI3jBCeKwcSFZGG86X2RgDtjKlUTOPIUpVx2bmCOnjx+6OMkaIIc2TGgubtM0X5VQVH6bzyZAZ8whRG7w2D1Nks6/Cf8zTtuinNcPtprDPshtBuqEYpPTuJXhOIt62IFp5x2GOi3NOcMmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JIdDP+2z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OQG6tyH+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JIdDP+2z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OQG6tyH+" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613Iliuq2829170 for ; Wed, 4 Feb 2026 05:04:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xSAiik096X5jYd7cFTlpkzc3bCH7olj7yaJbqdjszcQ=; b=JIdDP+2zh0G3cinc xCiDivaKwRWrpGbRtE0pBRjmA+/EVLUC3ZsS/TziqhA4vcMlP1y/9ffLsxEytEkU a9ZX+AGRm73YI38Si24xFkJRQUsoJ3pTdThfAP66+fbI0qevKaPq2UUlwezgKEvp X5gkQS7YhPXMw+UyPAn2WVNL6WzHT10dTV6o6UnC87j2BXSGZwlCDDsXON/BLPYc Wcs78sqQ/ukfdSIwD8Z8I9QtqhyQV+ztMIpRt4Tu9wQPoJN1N0SvNaq2TBmHi0Se +czWIOl7eDIYqGLkXMrc2astUbcgBuqOxBud1dJ8WwKk78jHNhJ69N88Gb32vzM6 jquA5Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3ndvhx1p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 05:04:35 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a863be8508so84152465ad.2 for ; Tue, 03 Feb 2026 21:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770181475; x=1770786275; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xSAiik096X5jYd7cFTlpkzc3bCH7olj7yaJbqdjszcQ=; b=OQG6tyH+HJnNvh8V00TtMGNWevbAbLyzj4vhc+AeSn12ZbLFxB1Kmh4dR4s5ISVxli 3U4mFFPO26Vo8Pftblgw8r1O0vg/3pT0nAFmlP0v5zhpbld9S8sToSJ8nmvi27ZtrHtL L3fy8fwlbaQBy1wUSVomkJblqMib9CXSQnbPCPBwOa8l9ojnd6yxu2zcubBHBUrYiDiK KXKb6awW42uZczoWGx7IzRwlX2CVIocQpi3E57MoK0QHJq4t7m7uwmGckhsi5a61qGxf 3IzHPg8/BwPSKdxx+ToJ4JlEo3mt7ThRdkJ0lFpdDWBFvjp9YO8uK4U7sCjW3nPR3e1F OlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770181475; x=1770786275; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xSAiik096X5jYd7cFTlpkzc3bCH7olj7yaJbqdjszcQ=; b=G+8jUEPQ53+EoKMzcRnUxYaZMohaLj4ilZq1RQi95nWvX7hiPYk7ZIBE4OixQnTmFX KzU7tf47Qh7vi0m2GTPGzps1fknWc0fGb/8umNie34/55gafTQaytuZzOrFJXoNPRhCR U709XxXOpKEz4G4/wRTbCrzGZjuhomqmxvp933/tVpvWcSy/LqqPLiNPo0AgOfgefJ51 hL+RExty1XnnGZ8HuTltEMlP6Sn6PR3CIChN2bS2U9ZNS5ADL9svL5DFflmgiSf6eHgT h7DMySN2P2Tg7o856Q+f9N6O7PfBeCx1MINawYXhx6CLQ4K6t0JPOYIOHcqgiYfVh11I AlsQ== X-Forwarded-Encrypted: i=1; AJvYcCUktpIE0mpWXifhRdZ4KqMqTiP2OG2pGVPK5uTGbQnfBdfa9dbAY4Rf9pxS6j7p5c5H0OA1tRfMcKIANWk=@vger.kernel.org X-Gm-Message-State: AOJu0YwqvLSd7yrTa6N7MJGskcfyf3hGHSWU3zs2ZXGJfEyTojYHhJuQ M6wEQOLV2tSLH8lm7ZYzia+9zSYrXC/17g4y99GwN99O0hEySW2GExis4OS3spZY9Y4QXqiWgFv 93iqvrZ6B5l6WDZFD/LC7nxTQmM81+S8KToAl+Vx3AUzvk0wd/+Xt2jG1T9j/PScMuwY= X-Gm-Gg: AZuq6aL0IxWAmE5F6BgPnslEjDJhxLHbCxJEgK0aghZLNbiuuICPbc+kq8cx8QatXHu 7jcfWakJkuNRJCbDEESy/T+fmPUXo0dsRADCPA871+cwMWxspOSML7MizRRC2uPwTVOPaPFiCD7 h4sOYz1GGHrBgOXVc0exRAByNGJbI62kGH1Vmd8MCV3fMSm+uia8aJvVEF+sEQii45pRvreXsLo OavRmUMKXrgdKqJGoHHPgZeDy9hrO2frV/X8U3sOckimu1m/PCdBFqqCTWCUrRf3+RGASX4rX5U Epoi0siIC4iNcZnAko12A7ibfDiUpl73s1nTkS9vQQ1Qa1InWCTyprX5x9SL+8bL4zeMU1wqoss WmIJivOAFtGXQn72RzLMUu0NmqKHh0tV0Bo7P+XlTEg== X-Received: by 2002:a17:903:3d0c:b0:2a7:5ad3:79eb with SMTP id d9443c01a7336-2a933fa63eamr19784765ad.35.1770181474794; Tue, 03 Feb 2026 21:04:34 -0800 (PST) X-Received: by 2002:a17:903:3d0c:b0:2a7:5ad3:79eb with SMTP id d9443c01a7336-2a933fa63eamr19784455ad.35.1770181474231; Tue, 03 Feb 2026 21:04:34 -0800 (PST) Received: from [10.218.32.171] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8241d468d73sm954264b3a.49.2026.02.03.21.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 21:04:33 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 10:34:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct To: Konrad Dybcio , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-13-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDAzNCBTYWx0ZWRfX4mcgPrtRG26J eHtiTqFLGKYQoMJstJbJcm8N8TsbM3QY/uMZnahznxzCIJO86RCcAmq9RxoLI507q0mAy1Y2E9u VeSmlQ7YByi255utlYPJn17jD+P2j6TqlJmmb3dOkJKLQnOI6c5GPijz08R//Kt4JG4GY90PPX6 CL774F/q5DbCd/SCHu6CU1DGvAM0K9sByx7O60JfVv7BhXIE3MkOu6WVmn2jp7Mo61ISXvMI4fm 2h1QGVp0LLwJdivYGRa0D4bEX4AaAktnXs4oUbbuywfEVZ951UYS+qmH2ttorsj6elMWcqnx/eh WTYVbUJWNaD6geb6Dt3m8coEPaYGEcVFKYxputg8V00VWWZt2wKjgrCfiXYI3E5yYh3lxdPtxUI evnfaGhOGFA3E4ghURCogOkhaW+ThfA6oU3JSMpqFDSD3mRFmdxA4tFU0BUkSXrXGAIseGp91IZ 9JpowQuLA4jVogm+F0A== X-Proofpoint-ORIG-GUID: j67PBc-qLUSeG2ePP84PTiXXoLXSs7O0 X-Proofpoint-GUID: j67PBc-qLUSeG2ePP84PTiXXoLXSs7O0 X-Authority-Analysis: v=2.4 cv=b+W/I9Gx c=1 sm=1 tr=0 ts=6982d363 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Xoixdy55EFV0JJdjLs8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=zZCYzV9kfG8A:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040034 Hi Konrad, On 2/3/2026 5:55 PM, Konrad Dybcio wrote: > On 2/2/26 7:09 PM, Praveen Talari wrote: >> To avoid repeatedly fetching and checking platform data across various >> functions, store the struct of_device_id data directly in the i2c >> private structure. This change enhances code maintainability and reduces >> redundancy. >> >> Acked-by: Viken Dadhaniya >> Signed-off-by: Praveen Talari >> --- > > [...] > >> >> - desc = device_get_match_data(&pdev->dev); >> + gi2c->dev_data = device_get_match_data(&pdev->dev); > > Because you dereference it unconditionally later, this should be > null-checked Initially this was added, but based on Bjorn’s comment like there is no possibility of getting a null value here since we are already adding the platform data to compatibles Thanks, Praveen Talari > > Konrad