From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E0F270540 for ; Thu, 15 Jan 2026 02:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768443307; cv=none; b=iKrQCnogSuPQQr0eSb887bG1hSAx0iqwV5j8RzAgY/JS/pstyCFG5lQLAcsPuaYuy4UiLSHio7uhMs5OfXs7pnGC3rGxnoHGXcm8s9XhR4gIoCNst9xvloLtRWOLPdI68Cyox+j50Koby26qOIGPcyDTyH5fWTVsWfXeL3+1DVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768443307; c=relaxed/simple; bh=eBbieCwBHiWcFUG7hDjEHdyb43nn4ge2y9+D2+InXxU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H9Wi8T53jusRnWBQs4l32rAQrJAehhwEwlLstfPPAlWUNQQOu81U80C3I2dOr54IGmoEAOqNqiaJAqaJY03TLj2miNWiBo3n5j/B3Fb+7icHkUrNStwZL11GYvSMh2Q8GEx3bpjWHGe4iqkTa91Be9GflUqKXzOkVi/7b7a/OZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B1sF1iF7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y8GKr+U8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B1sF1iF7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8GKr+U8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768443305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wVLNaYRdyTd3Y3bYKBBodLvCmiY6IvN6c8AunBjxbBE=; b=B1sF1iF77g7nkwbe7xlbuXaijsKAMNqC14BNYpbxc3SLKCGCMf90TLBVt63PEh7kopax5Y WVLHC9lDAZBlamx0cl2IEIExTz8xmocZZAQjX8ORD+WUXl+gdQ+9Mm/tjkgMlwlWBWfkan pfTHDjPVMoCJEXsnIXtPlh1UbUgMEsE= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-2Jfh9ts1OYaAg2sFi5z6Mw-1; Wed, 14 Jan 2026 21:15:04 -0500 X-MC-Unique: 2Jfh9ts1OYaAg2sFi5z6Mw-1 X-Mimecast-MFC-AGG-ID: 2Jfh9ts1OYaAg2sFi5z6Mw_1768443303 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c52d37d346dso218104a12.3 for ; Wed, 14 Jan 2026 18:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768443303; x=1769048103; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wVLNaYRdyTd3Y3bYKBBodLvCmiY6IvN6c8AunBjxbBE=; b=Y8GKr+U8jmBXyWS8TcOa1SlIXAwukpHGuCqa67fHX1coMUBWiJ0CSIPJcgvo47Tl3B PVihPa5oz1ZTmhy5ekrr0zIiHaaHf3V4X4VEzuzmFUVWo1GA1XdumYJaXxxANNC2R5NF OEVp6b6GX8edFvqvXDxFRt67ox3Y5NE65ILYq5/p+dftkA6k3Ijsbu/HGIhw0b7n8F0U tZgUlSMxnpJxiJh71bJT3t6z3emFrugI21moQPxW8xhZ8rstcHIuIxfHgwz6DozG8el7 xAEHbuBsJbQpQPELS9eqqA+riLVV+n8o9M5HqKLBQXjK6Yq8KHKBOl+GNMEAIyw15Vwn 7LUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768443303; x=1769048103; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wVLNaYRdyTd3Y3bYKBBodLvCmiY6IvN6c8AunBjxbBE=; b=qdUSbZHbqJyCWeeKdAc4B7I3NUn7cHPddOUhoqPpFTgKqKWYNuvwGOQu1iOumjBWSU U76OfXnXGNTRv+HLpDs+QCFbfZ+Nb+nK5Xk5wfXrSoXhOiI9jXXeL+09Kgl5nuKr7UNr /ZzQdHysIkzy4nQAKFhXrskQw3BuBnMMFAA287ZD2O/EtaWgWi2xVNmE5GMidKoOJ/Dq mS266xdCmUn+aCu0a5khxAMqdJeSQkndungWjFPkyAb2eNgTggkSwObU24W0+9TYNejj ZZ5bytPuFICtfVBa6ouYdQ6PD7/fWwbsJ6upWmHF4gVhR8Gdjj6gwNHCABCXB4SNPG+o oGuA== X-Forwarded-Encrypted: i=1; AJvYcCWQxFfJEINBS5NS2yTVm6WbtH/wnmPNEwkdcpG6dr5XMm6op1Jbq+YJQHqg16/gRPCx7HfprqDaVOxTEO4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3C9KqpEq/dnKntAlbWo0fAGufmDjf3aWAfdWYJw56VcHF4T3E 3T3PUvQMHtzv7B3b6glLTGmAxF0ZNsQOBIeRrVkf84szr5tzc+TacNcjcKXFsYSocxb7ZH2GEuF Y0sYT/iWilHOrXENDWpSYAAmCeI1hnerLbdJhMDBmxuonI2DDzC8DMMKBDMeNmbvA1g== X-Gm-Gg: AY/fxX42/WdHtHeF5jHPQLWPXW1TdYcbLXh26dvxU8DD1K0GFqTMSKDuzKxjkiOiDUD iSHWM/w4CFLTf2souRq8igG+qfSX9sT8+uQ2j8HdjyeV6nlQ8sU3IcNpcTcuFmCMSdGhNGBToJf X2ZnbWYB2yyderFlUmKp6pwNJ3u/ndEP0LdJbTaM/es4B5U9Dv7YE/KM21briiM7pwbGPS+iWW2 y2qnZ1wZuoKO2SGlVIiLZtcpv0dbZ9AC8DrYhk60wEe8/CMVtGh/QxmrZbEKszgK9bYT46oDdLs f/z13iqt83J0wWNugZJs2/qd8IonxzrF+JES2h0PcsIBUY4SLLQBG3TV3xfi5Hv7wrGqXzdvbeq RxZGth3bA2i8= X-Received: by 2002:a05:6a20:7f96:b0:361:2c56:fca8 with SMTP id adf61e73a8af0-38bed1ca1c6mr4829253637.50.1768443302924; Wed, 14 Jan 2026 18:15:02 -0800 (PST) X-Received: by 2002:a05:6a20:7f96:b0:361:2c56:fca8 with SMTP id adf61e73a8af0-38bed1ca1c6mr4829208637.50.1768443302510; Wed, 14 Jan 2026 18:15:02 -0800 (PST) Received: from [10.72.112.168] ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cbfc2f481sm23240011a12.10.2026.01.14.18.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 18:15:01 -0800 (PST) Message-ID: Date: Thu, 15 Jan 2026 10:14:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/47] arm_mpam: Use non-atomic bitops when modifying feature bitmap To: Ben Horgan Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, james.morse@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev References: <20260112165914.4086692-1-ben.horgan@arm.com> <20260112165914.4086692-3-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260112165914.4086692-3-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/13/26 12:58 AM, Ben Horgan wrote: > In the test__props_mismatch() kunit test we rely on the struct mpam_props > being packed to ensure memcmp doesn't consider packing. Making it packed > reduces the alignment of the features bitmap and so breaks a requirement > for the use of atomics. As we don't rely on the set/clear of these bits > being atomic, just make them non-atomic. > > Reviewed-by: Jonathan Cameron > Signed-off-by: Ben Horgan > --- > Changes since v2: > Add comment (Jonathan) > --- > drivers/resctrl/mpam_internal.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Gavin Shan