From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2063.outbound.protection.outlook.com [40.107.92.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A77156F55 for ; Wed, 18 Dec 2024 06:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734502873; cv=fail; b=nHIlb5iptkSA4JuDn7YZ3LHkS2m7VH0TNzu8vc8l3CaPEsyr3neNG5zT7YvDMX90xakA9frJlgjnwed38tJPDk6uk2xRlFwWXSgg3rnzUHyVgibN7d6YtTWL/Rg5Bv+egNJk4U0JoIG59eemverlhw3c4zPlO2Pp4powsFG8QTE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734502873; c=relaxed/simple; bh=O+001SG0Y2ylp0oOHxwuGN5Nh6T/w8pD/oTbmUM6TfE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Vx4qFI54t2C02v3wvTy2WJAIKqwm+ntZEXLr/GfegFGbPX/d42hDl1AwT8IDFqygyFoaGP3sW7ix4hnwBJzePKNS6aZEjsMzhnBOLRMwnoeiWY0QdGLpFiPdC6d9nrIkrOBvcP+jFCNseWNtjVsc0jIMbtNcokmTXIwrEMDPo1Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=LWZqYSWF; arc=fail smtp.client-ip=40.107.92.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="LWZqYSWF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j/i4WUeyhUjhr2lzQzeudTKdFO5Hco7D5wHNeROfiPvKkvsHwesvqVRxnI/5HMEMsJTj+gp9GOl2rGmT7ketnPyWbTh1OHqBmqhqJjQcIN+oq7sc+YLr67iAAfUtTF3I+i3l0/ciuYbxTT3KAJsB8RUCPkbcnmgtIHkbOKD6FgLgR2vdLjcCPm2fcE9W9pJWsjovjY/p+I5XzLivagVaUbYs7Dmwu8ZjP0hoOpPFx1g59IHf9DSabHIW6OzGCaaa1G5jltWKdmzPjWpZM0gsw8uFFu/kkLRFIR1U4RpeqaEn74Tpnrb+LXXp9/r8QkAPPVDRQxmpJ1tMWF6wiPgstA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bO1UnnNuCCRbAgHX8OVY4xCM9f1/SKlP+1rv7c0EqXE=; b=ZRC+Wc7RHo2lNdfaet8Jr0U72L0asxHL58k6M1Dd+RDtXfVoE4ODURdGZdfcwOAfAsneFUGoz6DeOVM4mqAbkx5rAWTij1H1CHA85+vQwqwUCvttDlaMk07Is9YhAp0CnXMay11f/iBWzkduryxS10+zhnYdGSJFAPHmBR4+excDy4Ejch4Y38TZGKDr+EyHcN7T9xL90Can7IIsOcEF6EppYgptzjtQl94lUC0yWP1fynDZ9GwjEyxIdQ561xZgjMGnADkLgnw2vrk7GkXHf2BK/sAE+5xfSca4bL6oDcWHiaNxWDesjVsp1ZRi9t8VWfhu0tdRz7g87VStPJ+1Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bytedance.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bO1UnnNuCCRbAgHX8OVY4xCM9f1/SKlP+1rv7c0EqXE=; b=LWZqYSWFV9Gjk6WPp7OcTwXGHcy4xoo5S7xevWR+sJ2U6nJ8R4Kqn+6F1x6zP0qGMP3O3nyctqOKBVDvgZ7yIywki6Cd6Px5eQg78jrwP3XTgtoz+8ZSOLwqJh7tOiQEnhNI1avtzE+f0XvwQntn/6qrXSjuY5YNeUxzrC3fGF0= Received: from SJ0PR05CA0022.namprd05.prod.outlook.com (2603:10b6:a03:33b::27) by DS7PR12MB6142.namprd12.prod.outlook.com (2603:10b6:8:9a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Wed, 18 Dec 2024 06:21:08 +0000 Received: from SA2PEPF000015C7.namprd03.prod.outlook.com (2603:10b6:a03:33b:cafe::41) by SJ0PR05CA0022.outlook.office365.com (2603:10b6:a03:33b::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.8 via Frontend Transport; Wed, 18 Dec 2024 06:21:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF000015C7.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Wed, 18 Dec 2024 06:21:07 +0000 Received: from [10.136.34.246] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Dec 2024 00:21:03 -0600 Message-ID: Date: Wed, 18 Dec 2024 11:51:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu To: Chuyi Zhou , , , , , , , , , CC: , References: <20241216122357.1276382-1-zhouchuyi@bytedance.com> <20241216122357.1276382-4-zhouchuyi@bytedance.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20241216122357.1276382-4-zhouchuyi@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C7:EE_|DS7PR12MB6142:EE_ X-MS-Office365-Filtering-Correlation-Id: eb1a784f-d0aa-432d-584c-08dd1f2c2847 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y0hsT2hmamhSbkdtSEExay9VVE9JZyt4eFZoUnpmblNVT21yTi9UYWNlQXFs?= =?utf-8?B?Q2twTHZUK1RlRjBnQmVBN3V3NU8vakJDc1BtbXJqQThmRno1dmtoNGJXUlV6?= =?utf-8?B?QnlqYk1mVk01UEwrVUJNY2xST1RSd2hWUjZWb0drTVQvNGlQdzRKaHB5YmlS?= =?utf-8?B?UzdneXYzRmVGeFExYXVsU09sV012Wkt5RWo5WTlwbWtyVjBxZ0RxVm1scTN1?= =?utf-8?B?M2l3bUxuaDY0QUM4V0RBdy8wRnpDVSt6bU5VWXI0T3RiaWUrczI2S3J6dHQ1?= =?utf-8?B?RGdLMnkwYkxSdXdwN2oxK1pFU0lSQzRoRXFCeTlMdjlBdnQrM2xOcDNNMkIv?= =?utf-8?B?akd4MXlLTlExY2x1cVNVK243UjdUOUVDVzNFVmdRU2xGc1hrZHhmSTluUnhV?= =?utf-8?B?S0EvSWxZOEY0MzRJa1RCUktxUE5nZFNCMk1iWUpRN1VEaWJjeUJNN091UTBs?= =?utf-8?B?N05RN1A5L1NUWjBsTitXRVFBUmcyTW1xQ2dVUXIyQ1BxRW5iZWJxWHQvTERW?= =?utf-8?B?dEdMN0FyN1Vtc3JuMkJJb2hsalpRRFBRVnVVTmRRaUdKNTFFZ0VFSzNSZHF4?= =?utf-8?B?Tk1jamtYMC8zL3U4VUJhRkN2U0pmUWVwb1E1UUEzc28vS0t2ZnhCVWZ3aDNu?= =?utf-8?B?UGFCcVVPSzVYcm02OVN5UE1lcGJNMGVHNml6ZFJtYi9nSWJIV24xZlFCTXFx?= =?utf-8?B?WWhKUUFLOE1TTGtHUTZsNXlHdmMwQTZNK1BBankxbXJ2dEN5ZGQ4Y1FVeW5v?= =?utf-8?B?VzJadkVEc3J1MnhacmlvY3ZvV0hDQlNCdldyNHl3Y1lxRHpEZ25paWdoWlpB?= =?utf-8?B?ZVk5TjBQTWxBVHlwREgzV1RSdnptR1RyS2VGdFRjbVB5UU9qU0lON0ZzUWJx?= =?utf-8?B?MEFSM08vdFRhdzZkQ3FDUTIzVzkrRU5Sb25ZOHJ3MnVSMWJrVkFVSjUzNVhE?= =?utf-8?B?SFpUNmlPR1MyeVIwTjZ2RGJPUWVJQmU0NWQ5QmpKWnVCK2p1STRWaHdGR1Vx?= =?utf-8?B?M0NsZG8wR1ptVzFZcm5MZTh6Tis0MnVuay9LMzNiQVdCajAySFFwQ0lJdTlx?= =?utf-8?B?V1NvakVVNEhkdjdzU2hkTnNhS3B4SU5BcjFjYTNiNDQ4bGZBSzRDZ1N2SFcy?= =?utf-8?B?dXZDczRiNXhVUEh1eVgrOHFDNHl5WnNYbU5tcW1xaENhYm92YUIvWlRlUmJj?= =?utf-8?B?Z2p4cjZGbHFibnVBdXFsbXJzZjZNSkVjU2o0VkdkWXRMM0xpWXpkeW9xL1pF?= =?utf-8?B?dTVZNkQ4Ry8rRFlxRFdOZkhkQlJjbmMvSUUwU2txNWpsVDhDc202dllUdGQw?= =?utf-8?B?SUJiOU1kV1JJWlhkWXN6NWY2UThPcVJHVnY3UElYdDNiTGN3RytQS29OYkZC?= =?utf-8?B?VTFjZ1dJMUxJdll4MjZFM3dvR05wdFk4cGgyZk5OMENNem8vWTRUaWdCdVNn?= =?utf-8?B?YnAzMXRWN1AvTk1wN0JacmxuQzhBVmxDN0tjQ0JzRFpDMGVKNGhrb1MwelBn?= =?utf-8?B?Ukd5dTdBSmlFV093M3hEd3JyWWcxUVptekFVKzd4UEpRR2REaU1FVkRRcUNB?= =?utf-8?B?Y0NoeEJkN1Z6Sm16bnVJQTR0QmVZSWRxWGpuNjlDVVlPY1dFaW55cU9XRXBi?= =?utf-8?B?YXJNbVRXOC8yZitGbzVIbHk2NFJ1RXgrWUpMUFY0ZzB3YXRxWXU1ODduRW55?= =?utf-8?B?Y1I4SWg1N3ljTGxFcDdZanoyUXkvdXRsZzA5UllCc3YxMGVMZFo4RStNVjdL?= =?utf-8?B?V1VpMTAzaGRqQ2JGTTJ3YWZJV0FBczJ0dHhiYnB0ZHNNL1JSRUIvU0theVNz?= =?utf-8?B?T3FpK0ZOWnZJZGRTRlU3L3REWHNCUWUxN1hQMHdYT3d3OWdXd2xpU2ZnQXp1?= =?utf-8?B?RGUxSnJ2cENMSjViQ3BRU2YzQUhSeVUvSEViS29EVDN0TjhsUXdkcnNJN0g2?= =?utf-8?B?Y1pTMWRtaTBheTVKbDZKYVdEcFBIVmFhSlVNdzdDakpnbDVvcGNDbUxYcWs4?= =?utf-8?B?eFlOcU15STZrdE8zWitaUURKRW9XbWFaSmNKeEVnem9McDhxMGdkVjBTOGsw?= =?utf-8?Q?Lpxse3?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 06:21:07.0639 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb1a784f-d0aa-432d-584c-08dd1f2c2847 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6142 Hello Chuyi, On 12/16/2024 5:53 PM, Chuyi Zhou wrote: > [..snip..] > @@ -2081,6 +2081,12 @@ numa_type numa_classify(unsigned int imbalance_pct, > return node_fully_busy; > } > > +static inline bool numa_migrate_test_cpu(struct task_struct *p, int cpu) > +{ > + return cpumask_test_cpu(cpu, p->cpus_ptr) && > + housekeeping_cpu(cpu, HK_TYPE_DOMAIN); > +} > + > #ifdef CONFIG_SCHED_SMT > /* Forward declarations of select_idle_sibling helpers */ > static inline bool test_idle_cores(int cpu); > @@ -2168,7 +2174,7 @@ static void task_numa_assign(struct task_numa_env *env, > /* Find alternative idle CPU. */ > for_each_cpu_wrap(cpu, cpumask_of_node(env->dst_nid), start + 1) { Can we just do: for_each_cpu_and(cpu, cpumask_of_node(env->dst_nid), housekeeping_cpumask(HK_TYPE_DOMAIN)) { ... } and avoid adding numa_migrate_test_cpu(). Thoughts? > if (cpu == env->best_cpu || !idle_cpu(cpu) || > - !cpumask_test_cpu(cpu, env->p->cpus_ptr)) { > + !numa_migrate_test_cpu(env->p, cpu)) { > continue; > } > > @@ -2480,7 +2486,7 @@ static void task_numa_find_cpu(struct task_numa_env *env, > > for_each_cpu(cpu, cpumask_of_node(env->dst_nid)) { Same modifications can be made for this outer loop. -- Thanks and Regards, Prateek > /* Skip this CPU if the source task cannot migrate */ > - if (!cpumask_test_cpu(cpu, env->p->cpus_ptr)) > + if (!numa_migrate_test_cpu(env->p, cpu)) > continue; > > env->dst_cpu = cpu;