Re: [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword

[James Smart <james.smart@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On 11/17/2020 11:42 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index c8b9434..a71df87 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3336,7 +3336,7 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
>    *
>    * This function is called with hbalock held.
>    **/
> -void
> +static void
>   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
>   {
>   	union lpfc_wqe128 *wqe = &pwqeq->wqe;

Zou, Thank You .  I just submitted the same patch.   Either one Martin 
wants to take.. :)

-- james

Reviewed-by: James Smart <james.smart@broadcom.com>


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]