From: Daniel Borkmann <daniel@iogearbox.net>
To: Hou Tao <houtao@huaweicloud.com>, Byeonguk Jeong <jungbu2855@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Yonghong Song <yonghong.song@linux.dev>,
bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/bpf: Add test for trie_get_next_key()
Date: Fri, 25 Oct 2024 14:03:01 +0200 [thread overview]
Message-ID: <cf3f3926-7684-4e0d-b8cc-5514ff71647b@iogearbox.net> (raw)
In-Reply-To: <836aeb86-ea15-339a-7dbd-2d3157022e0c@huaweicloud.com>
On 10/25/24 1:54 PM, Hou Tao wrote:
> On 10/25/2024 6:26 AM, Byeonguk Jeong wrote:
>>
>> Okay, I will submit them in a series of patches. Btw, ASSERT_* macros
>> are not defined for map_tests. Should I add the definitions for them,
>> or just go with CHECK?
>
> For tests in map_tests, I think using CHECK() will be fine.
Given there is no alternative infra, agree. Would be nice to convert this
over at some point.
Best,
Daniel
next prev parent reply other threads:[~2024-10-25 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 1:45 [PATCH] bpf: Fix out-of-bounds write in trie_get_next_key() Byeonguk Jeong
2024-10-22 9:43 ` Toke Høiland-Jørgensen
2024-10-22 19:51 ` Alexei Starovoitov
2024-10-23 1:29 ` Byeonguk Jeong
2024-10-23 8:44 ` Byeonguk Jeong
2024-10-23 2:03 ` Hou Tao
2024-10-23 7:30 ` Byeonguk Jeong
2024-10-23 9:59 ` Hou Tao
2024-10-24 1:48 ` Byeonguk Jeong
2024-10-24 3:19 ` Hou Tao
2024-10-24 9:08 ` [PATCH] selftests/bpf: Add test for trie_get_next_key() Byeonguk Jeong
2024-10-24 9:41 ` Daniel Borkmann
2024-10-24 22:26 ` Byeonguk Jeong
2024-10-25 11:54 ` Hou Tao
2024-10-25 12:03 ` Daniel Borkmann [this message]
2024-10-25 11:53 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3f3926-7684-4e0d-b8cc-5514ff71647b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=houtao@huaweicloud.com \
--cc=jungbu2855@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®