From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>
Cc: kernel@pengutronix.de,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] firmware: raspberrypi: Convert to platform remove callback returning void
Date: Wed, 27 Dec 2023 17:43:08 +0100 [thread overview]
Message-ID: <cf5303ee-6474-4212-b8a9-f1e99ef98ab7@broadcom.com> (raw)
In-Reply-To: <5df31ef3c069f45634631c9c639bbb60ab1d4798.1703693980.git.u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On 12/27/2023 5:26 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-12-27 16:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 16:26 [PATCH 00/11] firmware: " Uwe Kleine-König
2023-12-27 16:26 ` [PATCH 01/11] firmware: arm_scmi: " Uwe Kleine-König
2023-12-27 16:26 ` [PATCH 02/11] firmware: arm_scpi: " Uwe Kleine-König
2023-12-27 16:26 ` [PATCH 03/11] firmware: coreboot_table: " Uwe Kleine-König
2023-12-28 3:12 ` Tzung-Bi Shih
2023-12-27 16:26 ` [PATCH 04/11] firmware: imx-dsp: " Uwe Kleine-König
2023-12-27 16:26 ` [PATCH 05/11] firmware: mtk-adsp-ipc: " Uwe Kleine-König
2023-12-27 16:26 ` [PATCH 06/11] firmware: qemu_fw_cfg: " Uwe Kleine-König
2023-12-27 17:07 ` Philippe Mathieu-Daudé
2023-12-27 20:46 ` Michael S. Tsirkin
2023-12-27 16:26 ` [PATCH 07/11] firmware: raspberrypi: " Uwe Kleine-König
2023-12-27 16:43 ` Florian Fainelli [this message]
2023-12-27 16:26 ` [PATCH 08/11] firmware: stratix10-rsu: " Uwe Kleine-König
2024-01-04 12:22 ` Dinh Nguyen
2023-12-27 16:26 ` [PATCH 09/11] firmware: stratix10-svc: " Uwe Kleine-König
2024-01-04 12:22 ` Dinh Nguyen
2023-12-27 16:26 ` [PATCH 10/11] firmware: turris-mox-rwtm: " Uwe Kleine-König
2023-12-28 15:32 ` Marek Behún
2023-12-27 16:26 ` [PATCH 11/11] firmware: zynqmp: " Uwe Kleine-König
2024-01-02 10:00 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5303ee-6474-4212-b8a9-f1e99ef98ab7@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®