From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jianping.Shen@de.bosch.com, jic23@kernel.org, lars@metafoo.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dima.fedrau@gmail.com, marcelo.schmitt1@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Christian.Lorenz3@de.bosch.com,
Ulrike.Frauendorf@de.bosch.com, Kai.Dolde@de.bosch.com
Subject: Re: [PATCH v7 0/2] iio: imu: smi240: add bosch smi240 driver
Date: Tue, 17 Sep 2024 18:59:14 +0200 [thread overview]
Message-ID: <cf53cbb5-104b-4f60-8890-98a53c27d176@kernel.org> (raw)
In-Reply-To: <20240913100011.4618-1-Jianping.Shen@de.bosch.com>
On 13/09/2024 12:00, Jianping.Shen@de.bosch.com wrote:
> From: Shen Jianping <Jianping.Shen@de.bosch.com>
>
> Add the iio driver for bosch imu smi240. The smi240 is a combined
> three axis angular rate and three axis acceleration sensor module
> with a measurement range of +/-300°/s and up to 16g. This driver
> provides raw data access for each axis through sysfs, and tiggered
> buffer for continuous sampling. A synchronous acc and gyro sampling
> can be triggered by setting the capture bit in spi read command.
>
> dt-bindings:
> v1 -> v2
> - Add more detail in description
> - Add maintainer
> - Add vdd and vddio power supply
> - Use generic node name
> - Order the properties according to DTS coding style
>
> v2 -> v3
> - Improve description
> - Improve supply definition
> - Make supply definition as required
> - Add supply definition in example
>
> v3 -> v4
> - No changes
>
> v4 -> v5
> - No changes
>
> v5 -> v6
> - Fix checkpatch findings
>
> v6 -> v7
> - No changes
>
> imu driver:
> v1 -> v2
> - Use regmap for register access
> - Redefine channel for each singel axis
> - Provide triggered buffer
> - Fix findings in Kconfig
> - Remove unimportant functions
>
> v2 -> v3
> - Use enum für capture mode
> - Using spi default init value instead manual init
> - remove duplicated module declaration
> - Fix code to avoid warning
>
> v3 -> v4
> - Use DMA safe buffer
> - Use channel info instead of custom ABI
> - Fix other findings
>
> v4 -> v5
> - Merge the implementation in one simple file
> - Add channel info for acc/gyro data channel
> - Fix other findings
?
>
> v5 -> v6
> - Fix checkpatch findings
> - Fix review findings
? What exactly happened? Your changelog is way too vague.
What happened with our reviews? Why did you get multiple of them?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-17 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 10:00 Jianping.Shen
2024-09-13 10:00 ` [PATCH v7 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240 Jianping.Shen
2024-09-13 17:54 ` Conor Dooley
2024-09-17 16:58 ` Krzysztof Kozlowski
2024-09-17 20:42 ` Conor Dooley
2024-09-13 10:00 ` [PATCH v7 2/2] iio: imu: smi240: add driver Jianping.Shen
2024-09-14 16:32 ` Jonathan Cameron
2024-09-16 20:32 ` Shen Jianping (ME-SE/EAD2)
2024-09-17 11:13 ` Jonathan Cameron
2024-09-17 13:13 ` Shen Jianping (ME-SE/EAD2)
2024-09-28 14:36 ` Jonathan Cameron
2024-09-17 16:59 ` Krzysztof Kozlowski [this message]
2024-09-18 8:14 ` [PATCH v7 0/2] iio: imu: smi240: add bosch smi240 driver Shen Jianping (ME-SE/EAD2)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf53cbb5-104b-4f60-8890-98a53c27d176@kernel.org \
--to=krzk@kernel.org \
--cc=Christian.Lorenz3@de.bosch.com \
--cc=Jianping.Shen@de.bosch.com \
--cc=Kai.Dolde@de.bosch.com \
--cc=Ulrike.Frauendorf@de.bosch.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®