From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ashish Mhetre <amhetre@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
dmitry.osipenko@collabora.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [Patch V2] memory: tegra: Remove clients SID override programming
Date: Tue, 22 Nov 2022 12:14:34 +0100 [thread overview]
Message-ID: <cf5422a7-351a-6780-ff7f-e20bc81f94c7@linaro.org> (raw)
In-Reply-To: <20221122053103.17895-1-amhetre@nvidia.com>
On 22/11/2022 06:31, Ashish Mhetre wrote:
> On newer Tegra releases, early boot SID override programming and SID
> override programming during resume is handled by bootloader.
> Also, SID override is programmed on-demand during probe_finalize() call
> of IOMMU which is done in tegra186_mc_client_sid_override() in this same
> file. This function does it more correctly by checking if write is
> permitted on SID override register. It also checks if SID override
> register is already written with correct value and skips re-writing it
> in that case.
> Hence, removing the SID override programming of all clients.
>
> Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming")
I could not get from commit msg what is the bug being fixed. You just
said "more correctly", but usually things are either correct or not.
What are visible effects of the bug?
Otherwise it sounds more like optimization or a bit better approach, but
not a bugfix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-22 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 5:31 Ashish Mhetre
2022-11-22 11:14 ` Krzysztof Kozlowski [this message]
2022-11-24 10:20 ` Ashish Mhetre
2022-11-24 11:34 ` Krzysztof Kozlowski
2022-11-25 3:49 ` Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5422a7-351a-6780-ff7f-e20bc81f94c7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amhetre@nvidia.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®