From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750869AbdBRFEE (ORCPT ); Sat, 18 Feb 2017 00:04:04 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:47830 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbdBRFED (ORCPT ); Sat, 18 Feb 2017 00:04:03 -0500 X-Originating-IP: 1.144.64.48 Subject: Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Joe Perches , linux-kernel@vger.kernel.org References: <89288c2354690be744b72b27e39f317cb1c5310d.1487314667.git.joe@perches.com> Cc: Alex Deucher , David Airlie , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org From: "Edward O'Callaghan" Message-ID: Date: Sat, 18 Feb 2017 16:03:46 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5QcFV2hM9LMj73vVNf6Nmbf3wwdB44lXE" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5QcFV2hM9LMj73vVNf6Nmbf3wwdB44lXE Content-Type: multipart/mixed; boundary="XF5DJvdlIoiBWcI1aDTdedCsuGIBpR1gW"; protected-headers="v1" From: Edward O'Callaghan To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Joe Perches , linux-kernel@vger.kernel.org Cc: Alex Deucher , David Airlie , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Message-ID: Subject: Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn References: <89288c2354690be744b72b27e39f317cb1c5310d.1487314667.git.joe@perches.com> In-Reply-To: --XF5DJvdlIoiBWcI1aDTdedCsuGIBpR1gW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2017 01:22 AM, Christian K=C3=B6nig wrote: > Am 17.02.2017 um 08:11 schrieb Joe Perches: >> To enable eventual removal of pr_warning >> >> This makes pr_warn use consistent for drivers/gpu >> >> Prior to this patch, there were 15 uses of pr_warning and >> 20 uses of pr_warn in drivers/gpu >> >> Signed-off-by: Joe Perches >=20 > Acked-by: Christian K=C3=B6nig . Reviewed-by: Edward O'Callaghan >=20 >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- >> drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 2 +- >> drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 ++-- >> drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 >> +++++++------- >> drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 ++-- >> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 ++-- >> 6 files changed, 15 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> index b1de9e8ccdbc..83266408634e 100644 >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> @@ -1535,7 +1535,7 @@ static int smu7_get_evv_voltages(struct pp_hwmgr= >> *hwmgr) >> if (vddc >=3D 2000 || vddc =3D=3D 0) >> return -EINVAL; >> } else { >> - pr_warning("failed to retrieving EVV voltage!\n")= ; >> + pr_warn("failed to retrieving EVV voltage!\n"); >> continue; >> } >> diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h >> b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h >> index 072880130cfb..f3f9ebb631a5 100644 >> --- a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h >> +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h >> @@ -37,7 +37,7 @@ >> #define PP_ASSERT_WITH_CODE(cond, msg, code) \ >> do { \ >> if (!(cond)) { \ >> - pr_warning("%s\n", msg); \ >> + pr_warn("%s\n", msg); \ >> code; \ >> } \ >> } while (0) >> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c >> b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c >> index 0f7a77b7312e..5450f5ef8e89 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c >> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c >> @@ -2131,7 +2131,7 @@ uint32_t fiji_get_offsetof(uint32_t type, >> uint32_t member) >> return offsetof(SMU73_Discrete_DpmTable, >> LowSclkInterruptThreshold); >> } >> } >> - pr_warning("can't get the offset of type %x member %x\n", type, >> member); >> + pr_warn("can't get the offset of type %x member %x\n", type, >> member); >> return 0; >> } >> @@ -2156,7 +2156,7 @@ uint32_t fiji_get_mac_definition(uint32_t valu= e) >> return SMU73_MAX_LEVELS_MVDD; >> } >> - pr_warning("can't get the mac of %x\n", value); >> + pr_warn("can't get the mac of %x\n", value); >> return 0; >> } >> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c >> b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c >> index ad82161df831..51adf04ab4b3 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c >> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c >> @@ -122,7 +122,7 @@ static void >> iceland_initialize_power_tune_defaults(struct pp_hwmgr *hwmgr) >> break; >> default: >> smu_data->power_tune_defaults =3D &defaults_iceland; >> - pr_warning("Unknown V.I. Device ID.\n"); >> + pr_warn("Unknown V.I. Device ID.\n"); >> break; >> } >> return; >> @@ -378,7 +378,7 @@ static int >> iceland_get_std_voltage_value_sidd(struct pp_hwmgr *hwmgr, >> return -EINVAL); >> if (NULL =3D=3D hwmgr->dyn_state.cac_leakage_table) { >> - pr_warning("CAC Leakage Table does not exist, using vddc.\n")= ; >> + pr_warn("CAC Leakage Table does not exist, using vddc.\n"); >> return 0; >> } >> @@ -394,7 +394,7 @@ static int >> iceland_get_std_voltage_value_sidd(struct pp_hwmgr *hwmgr, >> *lo =3D >> hwmgr->dyn_state.cac_leakage_table->entries[v_index].Vddc * >> VOLTAGE_SCALE; >> *hi =3D >> (uint16_t)(hwmgr->dyn_state.cac_leakage_table->entries[v_index].Leakag= e * >> VOLTAGE_SCALE); >> } else { >> - pr_warning("Index from SCLK/VDDC Dependency Table >> exceeds the CAC Leakage Table index, using maximum index from CAC >> table.\n"); >> + pr_warn("Index from SCLK/VDDC Dependency Table >> exceeds the CAC Leakage Table index, using maximum index from CAC >> table.\n"); >> *lo =3D >> hwmgr->dyn_state.cac_leakage_table->entries[hwmgr->dyn_state.cac_leaka= ge_table->count >> - 1].Vddc * VOLTAGE_SCALE; >> *hi =3D >> (uint16_t)(hwmgr->dyn_state.cac_leakage_table->entries[hwmgr->dyn_stat= e.cac_leakage_table->count >> - 1].Leakage * VOLTAGE_SCALE); >> } >> @@ -414,7 +414,7 @@ static int >> iceland_get_std_voltage_value_sidd(struct pp_hwmgr *hwmgr, >> *lo =3D >> hwmgr->dyn_state.cac_leakage_table->entries[v_index].Vddc * >> VOLTAGE_SCALE; >> *hi =3D >> (uint16_t)(hwmgr->dyn_state.cac_leakage_table->entries[v_index].Leakag= e) >> * VOLTAGE_SCALE; >> } else { >> - pr_warning("Index from SCLK/VDDC Dependency Table= >> exceeds the CAC Leakage Table index in second look up, using maximum >> index from CAC table."); >> + pr_warn("Index from SCLK/VDDC Dependency Table >> exceeds the CAC Leakage Table index in second look up, using maximum >> index from CAC table."); >> *lo =3D >> hwmgr->dyn_state.cac_leakage_table->entries[hwmgr->dyn_state.cac_leaka= ge_table->count >> - 1].Vddc * VOLTAGE_SCALE; >> *hi =3D >> (uint16_t)(hwmgr->dyn_state.cac_leakage_table->entries[hwmgr->dyn_stat= e.cac_leakage_table->count >> - 1].Leakage * VOLTAGE_SCALE); >> } >> @@ -423,7 +423,7 @@ static int >> iceland_get_std_voltage_value_sidd(struct pp_hwmgr *hwmgr, >> } >> if (!vol_found) >> - pr_warning("Unable to get std_vddc from SCLK/VDDC >> Dependency Table, using vddc.\n"); >> + pr_warn("Unable to get std_vddc from SCLK/VDDC Dependency= >> Table, using vddc.\n"); >> } >> return 0; >> @@ -2146,7 +2146,7 @@ uint32_t iceland_get_offsetof(uint32_t type, >> uint32_t member) >> return offsetof(SMU71_Discrete_DpmTable, >> LowSclkInterruptThreshold); >> } >> } >> - pr_warning("can't get the offset of type %x member %x\n", type, >> member); >> + pr_warn("can't get the offset of type %x member %x\n", type, >> member); >> return 0; >> } >> @@ -2169,7 +2169,7 @@ uint32_t iceland_get_mac_definition(uint32_t >> value) >> return SMU71_MAX_LEVELS_MVDD; >> } >> - pr_warning("can't get the mac of %x\n", value); >> + pr_warn("can't get the mac of %x\n", value); >> return 0; >> } >> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c >> b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c >> index 0e26900e459e..deec874d874f 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c >> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c >> @@ -2180,7 +2180,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, >> uint32_t member) >> return offsetof(SMU74_Discrete_DpmTable, >> LowSclkInterruptThreshold); >> } >> } >> - pr_warning("can't get the offset of type %x member %x\n", type, >> member); >> + pr_warn("can't get the offset of type %x member %x\n", type, >> member); >> return 0; >> } >> @@ -2207,7 +2207,7 @@ uint32_t polaris10_get_mac_definition(uint32_t= >> value) >> return SMU7_UVD_MCLK_HANDSHAKE_DISABLE; >> } >> - pr_warning("can't get the mac of %x\n", value); >> + pr_warn("can't get the mac of %x\n", value); >> return 0; >> } >> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c >> b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c >> index 331b0aba4a13..4d1439a498eb 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c >> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c >> @@ -2657,7 +2657,7 @@ uint32_t tonga_get_offsetof(uint32_t type, >> uint32_t member) >> return offsetof(SMU72_Discrete_DpmTable, >> LowSclkInterruptThreshold); >> } >> } >> - pr_warning("can't get the offset of type %x member %x\n", type, >> member); >> + pr_warn("can't get the offset of type %x member %x\n", type, >> member); >> return 0; >> } >> @@ -2681,7 +2681,7 @@ uint32_t tonga_get_mac_definition(uint32_t val= ue) >> case SMU_MAX_LEVELS_MVDD: >> return SMU72_MAX_LEVELS_MVDD; >> } >> - pr_warning("can't get the mac value %x\n", value); >> + pr_warn("can't get the mac value %x\n", value); >> return 0; >> } >=20 >=20 > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --XF5DJvdlIoiBWcI1aDTdedCsuGIBpR1gW-- --5QcFV2hM9LMj73vVNf6Nmbf3wwdB44lXE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYp9WyAAoJEP4bvbfZuWjbN18QAM+M2JXuH6IP6K/YkpNEWwZZ kEzSW/kO7nRs0zoFF4kKOLtYlRmpAVV/Wv4DqSTImmys4/ac5xICBE9Ke1b+l5a5 ui7Ie1QX7rs5JBEm3fOIKAhgMIapVsDf978VNRvx7Z7hWgbP4aXKyqwpPmznbtae ufiPHhHarvmBvMKcaNi7HPUJxz5TZAKNrrHHAmnU6BG5MdRB+mMjwk09x26LHw5c 06/9wRqasjB3i/pfrho/bux+0bPr5hfuED3nRuY3QfsbJcF0cv3M6W5buxATkJXz umNR2d431iFizR/oMSQ7nsIdFCgIYH+cgM6iTKyqXhUIvEv6NzJDcCGyacOB8Ugq XUvv/a3Ar8Hm2LkJyK1B38A1DvDu864jxMAJZMs3K3hi5muWmYkfxENayC+yjuYT A7kGWwkc0/NVrQtR5BiDveAUiL4otgtyovuDrrJrObNF8cfM4quhs/AfDRIcR6z0 Wo9QBrFZprjW3ya9+1RnWGU7u4PelM8laBW9rLviIq8hPh4jwmABTDxfAyRBiywa NwN2icN0WSdXfLsphdMkLOHWwxTL1r4l6qq2OH7H14rNdfx3KLZKKtuhwsHPoXcH NTDJeUJtnV3H3VR8VbX6Nz8UnTtncWKraXevthBlLLs85n66Uxs1PuCbwhBQ2+Gw ot8/tF9VY5ZfIkXRr8oZ =NCga -----END PGP SIGNATURE----- --5QcFV2hM9LMj73vVNf6Nmbf3wwdB44lXE--