mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Christoph Lameter <cl@linux.com>,
	linux-alpha@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCH 01/23] alpha/time: Migrate to new 'set-state' interface
Date: Thu, 16 Jul 2015 16:56:13 +0530	[thread overview]
Message-ID: <cf58aab697e42e20563c848901ef601dd4898879.1437044517.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1437044517.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1437044517.git.viresh.kumar@linaro.org>

Migrate alpha driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

rtc clockevent device wasn't doing anything in set-mode and so its
set-state callbacks aren't implemented.

Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: linux-alpha@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 arch/alpha/kernel/time.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/arch/alpha/kernel/time.c b/arch/alpha/kernel/time.c
index 643a9dcdf093..5b6202a825ff 100644
--- a/arch/alpha/kernel/time.c
+++ b/arch/alpha/kernel/time.c
@@ -93,7 +93,7 @@ rtc_timer_interrupt(int irq, void *dev)
 	struct clock_event_device *ce = &per_cpu(cpu_ce, cpu);
 
 	/* Don't run the hook for UNUSED or SHUTDOWN.  */
-	if (likely(ce->mode == CLOCK_EVT_MODE_PERIODIC))
+	if (likely(clockevent_state_periodic(ce)))
 		ce->event_handler(ce);
 
 	if (test_irq_work_pending()) {
@@ -104,13 +104,6 @@ rtc_timer_interrupt(int irq, void *dev)
 	return IRQ_HANDLED;
 }
 
-static void
-rtc_ce_set_mode(enum clock_event_mode mode, struct clock_event_device *ce)
-{
-	/* The mode member of CE is updated in generic code.
-	   Since we only support periodic events, nothing to do.  */
-}
-
 static int
 rtc_ce_set_next_event(unsigned long evt, struct clock_event_device *ce)
 {
@@ -129,7 +122,6 @@ init_rtc_clockevent(void)
 		.features = CLOCK_EVT_FEAT_PERIODIC,
 		.rating = 100,
 		.cpumask = cpumask_of(cpu),
-		.set_mode = rtc_ce_set_mode,
 		.set_next_event = rtc_ce_set_next_event,
 	};
 
@@ -161,12 +153,12 @@ static struct clocksource qemu_cs = {
  * The QEMU alarm as a clock_event_device primitive.
  */
 
-static void
-qemu_ce_set_mode(enum clock_event_mode mode, struct clock_event_device *ce)
+static int qemu_ce_shutdown(struct clock_event_device *ce)
 {
 	/* The mode member of CE is updated for us in generic code.
 	   Just make sure that the event is disabled.  */
 	qemu_set_alarm_abs(0);
+	return 0;
 }
 
 static int
@@ -197,7 +189,9 @@ init_qemu_clockevent(void)
 		.features = CLOCK_EVT_FEAT_ONESHOT,
 		.rating = 400,
 		.cpumask = cpumask_of(cpu),
-		.set_mode = qemu_ce_set_mode,
+		.set_state_shutdown = qemu_ce_shutdown,
+		.set_state_oneshot = qemu_ce_shutdown,
+		.tick_resume = qemu_ce_shutdown,
 		.set_next_event = qemu_ce_set_next_event,
 	};
 
-- 
2.4.0


  reply	other threads:[~2015-07-16 11:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 11:26 [PATCH 00/23] ARCH: Migrate clockevent drivers to " Viresh Kumar
2015-07-16 11:26 ` Viresh Kumar [this message]
2015-07-16 11:26 ` [PATCH 02/23] ARC/time: Migrate to new " Viresh Kumar
2015-07-20 10:55   ` Vineet Gupta
2015-07-16 11:26 ` [PATCH 03/23] AVR32/time: " Viresh Kumar
2015-07-20  7:40   ` Hans-Christian Egtvedt
2015-07-16 11:26 ` [PATCH 04/23] blackfin/time-ts: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 05/23] c6x/timer64: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 06/23] cris/time: " Viresh Kumar
2015-07-17 18:47   ` Rabin Vincent
2015-07-16 11:26 ` [PATCH 07/23] hexagon/time: " Viresh Kumar
2015-07-21 22:28   ` rkuo
2015-07-16 11:26 ` [PATCH 08/23] m68k/coldfire/pit: " Viresh Kumar
2015-07-16 12:42   ` Greg Ungerer
2015-07-16 11:26 ` [PATCH 09/23] microblaze/timer: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 10/23] mn10300/cevt-mn10300: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 11/23] nios2/time: " Viresh Kumar
2015-07-17  9:01   ` Tobias Klauser
2015-07-21 10:03     ` [Nios2-dev] " Ley Foon Tan
2015-07-16 11:26 ` [PATCH 12/23] openrisc/time: " Viresh Kumar
2015-07-16 13:42   ` Jonas Bonn
2015-07-16 11:26 ` [PATCH 13/23] powerpc/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 14/23] s390/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 15/23] score/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 16/23] sh/localtimer: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 17/23] sparc/time: " Viresh Kumar
2015-07-16 18:13   ` David Miller
2015-07-16 11:26 ` [PATCH 18/23] tile/time: " Viresh Kumar
2015-07-20 21:02   ` Chris Metcalf
2015-07-21 13:11   ` Chris Metcalf
2015-07-21 14:09     ` Viresh Kumar
2015-07-16 11:26 ` [PATCH 19/23] um/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 20/23] unicore/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 21/23] xtensa/time: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 22/23] drivers/hv: " Viresh Kumar
2015-07-16 11:26 ` [PATCH 23/23] kernel: broadcast-hrtimer: " Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf58aab697e42e20563c848901ef601dd4898879.1437044517.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=cl@linux.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=rth@twiddle.net \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®