From: Conor Dooley <conor.dooley@microchip.com>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: "Matthieu Baerts" <matthieu.baerts@tessares.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andy Whitcroft" <apw@canonical.com>,
"Joe Perches" <joe@perches.com>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Kai Wasserbäch" <kai@dev.carbon-project.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, mptcp@lists.linux.dev
Subject: Re: [PATCH v3 0/4] docs & checkpatch: allow Closes tags with links
Date: Fri, 31 Mar 2023 11:08:43 +0100 [thread overview]
Message-ID: <cf5a3e73-c97d-4f98-80d7-4bcc68eb557a@spud> (raw)
In-Reply-To: <2194d19d-f195-1a1e-41fc-7827ae569351@leemhuis.info>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On Fri, Mar 31, 2023 at 11:39:22AM +0200, Thorsten Leemhuis wrote:
> -Please check the link to make sure that it is actually working and points
> -to the relevant message.
> +If the URL points to a bug report that is fixed by the patch, use 'Closes:'
> +instead.
This is not specifically a comment about your additional diff, but this
sprang to mind (again) while reading it.
I have been wondering if this sort of thing will lead to inconsistency.
Reports sometimes report more than one issue at once. Other times a
patch that is (intentionally) not a complete fix for the problem.
Using Closes: in those cases is not really true, as it does not close
the report.
Having a series of N patches, each of which purport to close an issue,
also doesn't seem quite right.
The word Closes has a meaning and "forcing" the use of Closes: for
reports implies meaning that may not be present.
I suppose it is true that just because documentation or checkpatch says
to do something, doesn't mean that you **have** to do it but I don't
want to be the one on the Rx side of a rant...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-31 10:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 18:13 Matthieu Baerts
2023-03-30 18:13 ` [PATCH v3 1/4] docs: process: " Matthieu Baerts
2023-03-30 18:13 ` [PATCH v3 2/4] checkpatch: use a list of "link" tags Matthieu Baerts
2023-03-30 18:13 ` [PATCH v3 3/4] checkpatch: allow Closes tags with links Matthieu Baerts
2023-03-30 22:43 ` Joe Perches
2023-03-31 9:43 ` Matthieu Baerts
2023-03-30 18:13 ` [PATCH v3 4/4] checkpatch: check for misuse of the link tags Matthieu Baerts
2023-03-31 8:57 ` Thorsten Leemhuis
2023-03-31 9:44 ` Matthieu Baerts
2023-03-31 10:09 ` Thorsten Leemhuis
2023-03-31 10:16 ` Matthieu Baerts
2023-03-31 9:39 ` [PATCH v3 0/4] docs & checkpatch: allow Closes tags with links Thorsten Leemhuis
2023-03-31 10:08 ` Conor Dooley [this message]
2023-03-31 10:34 ` Thorsten Leemhuis
2023-03-31 10:13 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5a3e73-c97d-4f98-80d7-4bcc68eb557a@spud \
--to=conor.dooley@microchip.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=kai@dev.carbon-project.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lukas.bulwahn@gmail.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®