mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Duncan <lduncan@suse.com>
To: linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com
Cc: linux-kernel@vger.kernel.org, hare@suse.com, jthumshirn@suse.de,
	hch@infradead.org, Lee Duncan <lduncan@suse.com>
Subject: [PATCH 16/17] Update the Micron PCIe SSD driver to use ida helper functions.
Date: Wed, 16 Sep 2015 10:50:34 -0700	[thread overview]
Message-ID: <cf60d82bf8a4f7e8ed92fda68638176dae188efc.1442263513.git.lduncan@suse.com> (raw)
In-Reply-To: <cover.1442263513.git.lduncan@suse.com>
In-Reply-To: <cover.1442263513.git.lduncan@suse.com>

Signed-off-by: Lee Duncan <lduncan@suse.com>
---
 drivers/block/mtip32xx/mtip32xx.c | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 4a2ef09e6704..ccff4119b554 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3821,15 +3821,7 @@ static int mtip_block_initialize(struct driver_data *dd)
 	}
 
 	/* Generate the disk name, implemented same as in sd.c */
-	do {
-		if (!ida_pre_get(&rssd_index_ida, GFP_KERNEL))
-			goto ida_get_error;
-
-		spin_lock(&rssd_index_lock);
-		rv = ida_get_new(&rssd_index_ida, &index);
-		spin_unlock(&rssd_index_lock);
-	} while (rv == -EAGAIN);
-
+	rv = ida_get_index(&rssd_index_ida, &rssd_index_lock, &index);
 	if (rv)
 		goto ida_get_error;
 
@@ -3981,9 +3973,7 @@ init_hw_cmds_error:
 block_queue_alloc_init_error:
 	mtip_hw_debugfs_exit(dd);
 disk_index_error:
-	spin_lock(&rssd_index_lock);
-	ida_remove(&rssd_index_ida, index);
-	spin_unlock(&rssd_index_lock);
+	ida_put_index(&rssd_index_ida, &rssd_index_lock, index);
 
 ida_get_error:
 	put_disk(dd->disk);
@@ -4051,9 +4041,7 @@ static int mtip_block_remove(struct driver_data *dd)
 	}
 	dd->disk  = NULL;
 
-	spin_lock(&rssd_index_lock);
-	ida_remove(&rssd_index_ida, dd->index);
-	spin_unlock(&rssd_index_lock);
+	ida_put_index(&rssd_index_ida, &rssd_index_lock, dd->index);
 
 	/* De-initialize the protocol layer. */
 	mtip_hw_exit(dd);
@@ -4092,9 +4080,7 @@ static int mtip_block_shutdown(struct driver_data *dd)
 		dd->queue = NULL;
 	}
 
-	spin_lock(&rssd_index_lock);
-	ida_remove(&rssd_index_ida, dd->index);
-	spin_unlock(&rssd_index_lock);
+	ida_put_index(&rssd_index_ida, &rssd_index_lock, dd->index);
 	return 0;
 }
 
-- 
2.1.4


  parent reply	other threads:[~2015-09-16 17:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 17:50 [PATCH 00/17] Create and use ida and idr helper routines [RESEND] Lee Duncan
2015-09-16 17:50 ` [PATCH 01/17] Add ida and idr helper routines Lee Duncan
2015-09-16 17:50 ` [PATCH 02/17] Update scsi hosts to use idr for host number mgmt Lee Duncan
2015-09-16 17:50 ` [PATCH 03/17] Update the st driver to use idr helper functions Lee Duncan
2015-09-16 17:50 ` [PATCH 04/17] Update the ch " Lee Duncan
2015-09-16 17:50 ` [PATCH 05/17] Update the md " Lee Duncan
2015-09-16 17:50 ` [PATCH 06/17] Update the infiniband uverbs " Lee Duncan
2015-09-16 18:39   ` Doug Ledford
2015-09-16 17:50 ` [PATCH 07/17] Update the memstick " Lee Duncan
2015-09-16 17:50 ` [PATCH 08/17] Update the mmc " Lee Duncan
2015-09-16 17:50 ` [PATCH 09/17] Update the virtgpu " Lee Duncan
2015-09-16 17:50 ` [PATCH 10/17] Update the DCA DMA " Lee Duncan
2015-09-16 17:50 ` [PATCH 11/17] Update the rtsx multifunction " Lee Duncan
2015-09-16 17:50 ` [PATCH 12/17] Update the TI Flash Media " Lee Duncan
2015-09-16 17:50 ` [PATCH 13/17] Update the SCSI disk driver to use ida " Lee Duncan
2015-09-16 17:50 ` [PATCH 14/17] Update the rsxx flash adapter " Lee Duncan
2015-09-16 17:50 ` [PATCH 15/17] Update the NVMe SSD " Lee Duncan
2015-09-16 17:50 ` Lee Duncan [this message]
2015-09-16 17:50 ` [PATCH 17/17] Update the ARM soc base " Lee Duncan
  -- strict thread matches above, loose matches on Subject: below --
2015-09-15 16:46 [PATCH 00/17] Create and use ida and idr helper routines Lee Duncan
2015-09-15 16:46 ` [PATCH 16/17] Update the Micron PCIe SSD driver to use ida helper functions Lee Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf60d82bf8a4f7e8ed92fda68638176dae188efc.1442263513.git.lduncan@suse.com \
    --to=lduncan@suse.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®