From: Markus Elfring <Markus.Elfring@web.de>
To: Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <julia.lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Fri, 19 Jun 2020 17:03:18 +0200 [thread overview]
Message-ID: <cf6ab028-4297-dfab-35a7-cb6589fe61ac@web.de> (raw)
> Changes in v2:
…
> - assignment operator used
I would prefer the distinction for the application of corresponding metavariables.
> Changes in v3:
…
> - \(&E1\|&E2\) changed to &\(E1\|E2\)
Would it be more helpful to mention the movement of the ampersand
before SmPL disjunctions?
…
> +virtual context
> +virtual report
> +virtual org
Can the following SmPL code variant become more attractive?
+virtual context, report, org
…
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;
How do you think about the following SmPL code variant?
+expression subE1 <= as.E1,
+ subE2 <= as.E2,
+ as.E1,
+ as.E2,
+ E3;
…
> +coccilib.report.print_report(p2[0],
> +f"WARNING: same struct_size (line {p1[0].line})")
Please align such function parameters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=5e857ce6eae7ca21b2055cca4885545e29228fe2#n93
+coccilib.report.print_report(p2[0],
+ f"WARNING: same struct_size (line {p1[0].line})")
Regards,
Markus
next reply other threads:[~2020-06-19 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 15:03 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 10:20 [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks Denis Efremov
2020-06-19 13:13 ` [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6ab028-4297-dfab-35a7-cb6589fe61ac@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=garsilva@embeddedor.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome