From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02951D555 for ; Mon, 27 Jul 2026 13:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785159961; cv=none; b=dxcvwXGyZJ7ONeGaricsUG5o9Cgy5rUV6QzesxOGSzOH2QjjK70qxm2kvXrNGCP5oN/sIKwF96t1B/WDtmwbvyTDYUGEqc4zL7/F6uJjbpnN04kp5N0lTZ9TD90XGWaK17aaU9fPhcGz5Oykbjvco5LVXg9YmMULjuyPgu5oEC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785159961; c=relaxed/simple; bh=ZAdXlptvW7/luciaw/bQsN13K7E6dyysYrpPEUuQG6o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pR2M3dhhZj+c5d8w6vVeqKNd4jz+xHqnVahMmbZgVzQ+r2hAJdfEzSOynipr8tp+P1oNJe9ozmDaTlssSFOS2wAR/afImVvVe+EpNX7WMoTxXYliK3ASqkJ/IlV/Y85z9FEKIo6mnRnaeeT1cLmq6hJdD0szwtrgY4yfNKdvwkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MZ7XYaZq; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MZ7XYaZq" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7eb1dc6bd53so1512612a34.2 for ; Mon, 27 Jul 2026 06:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785159959; x=1785764759; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=27xxIauuK05vKGL5dQ5O20x7vu0xdxg2ow4luyIKsSc=; b=MZ7XYaZqWVBTtZdBj9+YWMCSgIcmoY9AzdCvl8/bv5vNcpN90y3DXdFUHDFRC/4Rgd G0/vB/IetoZGW3nlerd7kyQklzqmI17OOFF4NqO9+/1JvMTG9AzWhEtSjrUmk4wXNYzX L2CSpxFmJjW12qA+CQOVw3lzZQ5kXynMhrHx0uLys6kMEAJB4VvF7om3LfQyJ8tDkCYk 83Aca8bLHJF+mn046tJLWlqOOwUpsYisiuY/mlZc9R5MTG3B7Rw0eY+Rjk9+DUDCo+Hf NO3PdmHXgVnkhZKkL6Cd3+czJ3PWM2KY6z46py4lpG9NfCUP9xfDy3rBtu8LKgIaaWXr S8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785159959; x=1785764759; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=27xxIauuK05vKGL5dQ5O20x7vu0xdxg2ow4luyIKsSc=; b=qIXUfxG7+BAD4ySsQkrp63uHVwhDMhlhu/gYnnFincUvxN6eGWq1esn0BgP/5HDwg4 qJD9jBzRCZREdt6BPWKp4K2Oxq2ghYcinkCH6a+loJ6unpChvTiCgfb53SmBoW3OPP5c 8DnCqF8HTwkMwl1xFx5zkwrOavHFQmUd+TA6DRPIcBgTiGvfJJi2mQ+jWXWA+s/X/4Iy 5qlaYIIGsBQDd2R8V6n6UHA2U8oInHtAWcdRLPhGJrfMgurdapa5fbwrWPeFF+dD9Mfe 6RugUdrorxP2404HC1PC3lURFSmxau6cE4vWIxngc47gBZXddwQowqPVzAHo6hwjZoBb cu3g== X-Forwarded-Encrypted: i=1; AHgh+Rrb+3esx0ow6Y/qWdeSre6V7Z3VT4cN02JxYaXXHphQgRTjPoKAWmNHpRBtow117fgH/ZGoBwy61TUD3Jk=@vger.kernel.org X-Gm-Message-State: AOJu0YxGkJ1ilRiKlwnWs82hQ4IkGSoGG62UfD2+8cZjiUd49NLGPI7L fy+XfltqYoJV6XNqOZAE7Pqt7Totp7TNVrgMPrRlKSkAGZl1cI3VE76+nxtZYBlObwU= X-Gm-Gg: AR+sD11k++928rC4CGs9aRSFszsjwuLiljN2z28vJAbpR5c884zcFXdIcBJwn/Vj/Ya Ab/dXOcn4+P+UR1/B30APYeE25WMLL5ffhJ3xV90MkEczJ58DcFMAKdVg80gOMA2/B0nlbvJNsd 7y1oFXZZUfeoz6zjL8s0JWnXpPXlr9DOGBBP6eLGAT2hr4sWU8ilbnYa0RfXstusSbZUOcYAPh1 Eq36owxSusyQ7ZUw4Vgih+mWIch0Se/JAoWQD1lWs1ULN087T7mZC9jTdaJ8fAWqmCAAJOAS7Jc nzc5VDACqaioQ5cclxmHOfqxgGWVGQQo9u+XJ8e+KYjhHOPPLf2TTWguPVV1U96hXttRNM8lCpP 2P0Wjjxh+pefwQc2XdLaA1GKhvUI7DzNDs9/CXqAf6sjKs49PsNVc0NQm+ihMzf88m2nhabXITj RTPUthvnniEsjWXiZ7W5P/bp8lOv3ighD0r7+eVTlJTLhRT3Un4hH/ X-Received: by 2002:a05:6830:6f8e:b0:7e6:f7fb:9678 with SMTP id 46e09a7af769-7ee78c0a489mr7133180a34.1.1785159958709; Mon, 27 Jul 2026 06:45:58 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:41b4:f2ef:8a0a:2104? ([2600:8803:e7e4:500:41b4:f2ef:8a0a:2104]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ee39e9e9d1sm11181298a34.16.2026.07.27.06.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 06:45:58 -0700 (PDT) Message-ID: Date: Mon, 27 Jul 2026 08:45:57 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] iio: adc: ti-ads112c14: add continuous mode support To: Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Chris Hall , Patrick Edwards , Kurt Borja , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260724-iio-adc-ti-ads112c14-continuous-mode-v1-0-9eb0b7a4f020@baylibre.com> <20260724-iio-adc-ti-ads112c14-continuous-mode-v1-2-9eb0b7a4f020@baylibre.com> <20260727024559.513fadff@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260727024559.513fadff@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/26/26 8:45 PM, Jonathan Cameron wrote: > On Fri, 24 Jul 2026 15:13:11 -0500 > "David Lechner (TI)" wrote: > >> Add support for continuous mode in the TI ADS112C14 ADC driver. In this >> mode the ADC itself is starting each conversion, so we add a trigger >> based on the DRDY interrupt to read each sample. This mode is also >> limited in that only one channel can be enabled at a time since the >> chip does not have a sequencer or simultaneous sampling capability. >> Continuous mode will only be used when this new trigger is the current >> trigger. >> ... >> +static int ads112c14_buffer_predisable(struct iio_dev *indio_dev) >> +{ >> + struct ads112c14_data *data = iio_priv(indio_dev); >> + int ret, ret2; >> + >> + if (!ads112c14_using_drdy_trigger(indio_dev)) >> + return 0; >> + >> + guard(mutex)(&data->lock); >> + >> + ret = regmap_write(data->regmap, ADS112C14_REG_CONVERSION_CTRL, >> + ADS112C14_CONVERSION_CTRL_STOP); >> + ret2 = regmap_assign_bits(data->regmap, ADS112C14_REG_DEVICE_CFG, >> + ADS112C14_DEVICE_CFG_CONV_MODE, >> + ADS112C14_DEVICE_CFG_CONV_MODE_SINGLE_SHOT); > > This is odd looking code. Needs comments on why we should prefer returning > the error for the second call over that for the first. It is arbitrary, I just went with first error wins. Other option would be to return early since the hardware is going to be in a broken state anyway. > >> + if (ret2) >> + return ret2; >> + >> + return ret; >> +} > >