mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pratyush Brahma <quic_pbrahma@quicinc.com>
To: Ling Xu <quic_lxu5@quicinc.com>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>
Cc: <quic_kuiw@quicinc.com>, <quic_ekangupt@quicinc.com>,
	<quic_kartsana@quicinc.com>, <kernel@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove cdsp compute-cb@10
Date: Tue, 11 Feb 2025 14:14:53 +0530	[thread overview]
Message-ID: <cf78b342-6655-4cde-b877-8f498ed0e6bf@quicinc.com> (raw)
In-Reply-To: <4c9de858fda7848b77ea8c528c9b9d53600ad21a.1739260973.git.quic_lxu5@quicinc.com>


On 2/11/2025 1:44 PM, Ling Xu wrote:
> From: Karthik Sanagavarapu <quic_kartsana@quicinc.com>
>
> Remove the context bank compute-cb@10 because these SMMU ids are S2-only
> which is not used for S1 transaction.
>
> Fixes: f7b01bfb4b47 ("arm64: qcom: sa8775p: Add ADSP and CDSP0 fastrpc nodes")
> Cc: stable@kernel.org
> Signed-off-by: Karthik Sanagavarapu <quic_kartsana@quicinc.com>
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 0aa27db21f3d..81b2fba94841 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -4585,14 +4585,6 @@ compute-cb@9 {
>   						dma-coherent;
>   					};
>   
> -					compute-cb@10 {
> -						compatible = "qcom,fastrpc-compute-cb";
> -						reg = <10>;
> -						iommus = <&apps_smmu 0x214a 0x04a0>,
> -							 <&apps_smmu 0x218a 0x0400>;
Commit description seems misleading as these are nested sids and not 
S2-only. You may say you don't need it for your
usecase which is a different thing altogether.
> -						dma-coherent;
> -					};
> -
>   					compute-cb@11 {
>   						compatible = "qcom,fastrpc-compute-cb";
>   						reg = <11>;

-- 
Thanks and Regards
Pratyush Brahma


  reply	other threads:[~2025-02-11  8:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  8:14 [PATCH v3 0/2] arm64: dts: qcom: sa8775p: modify compute-cb nodes Ling Xu
2025-02-11  8:14 ` [PATCH v3 1/2] arm64: dts: qcom: sa8775p: Remove extra entries from the iommus property Ling Xu
2025-02-11  8:14 ` [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove cdsp compute-cb@10 Ling Xu
2025-02-11  8:44   ` Pratyush Brahma [this message]
2025-02-13  7:55     ` Ling Xu
2025-04-16 18:10 ` [PATCH v3 0/2] arm64: dts: qcom: sa8775p: modify compute-cb nodes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf78b342-6655-4cde-b877-8f498ed0e6bf@quicinc.com \
    --to=quic_pbrahma@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_ekangupt@quicinc.com \
    --cc=quic_kartsana@quicinc.com \
    --cc=quic_kuiw@quicinc.com \
    --cc=quic_lxu5@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®