From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 410C82FFFA4; Sun, 29 Mar 2026 13:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774792340; cv=none; b=dA3J0JrUc0sn+NK9PxCMOfwUziLguBw82g/g7NR4vZgveHtYz9pKQdDc9ZmXIVs9uxMw1+pZwWJe2FwVeIPzrrWdnQN1UlA7mvvHZnb06mLuvOqcXR1nK/rsyYH+ScZdN+5G8TtygKXdR7wKR5y1BuyWtKrHiHlyY1Cl93mxrY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774792340; c=relaxed/simple; bh=bHKNWaGCUGSGNZ7LHJw78ILCBmetKycG76Sp7kzNxfQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S7+xqvSvvVoxfryqvshDXJHcDDKQ6eaisLrj9FlojbQfxvPu/sdyjYOcNd2J/u0floWDdWXi65RycJiuW2RLsR5IYeQh3W5N1JyqntpGRIFKPsUwMszniTMliKcABCYPTdwwa1APT2C9NS6/M+tYPuaS79HQFZ3YP9gIeaeasYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Xmve8yqE; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Xmve8yqE" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JiOXC5tUqwiQgWrex87guzd4v1xV7Ik/86legiQ+FcI=; b=Xmve8yqEmVWKin35alRy1MlzuL U5IhH0uL+VCS9S8e2BAsfJngSi45SCdy9zhq3lf7BkIxBf1hvwXvPAaY/U/X5lVqa2AMxvX8wTJME SOTg3OMHKpg2GDTbUeUrfdMEdI+7Tsr9gbqyRPdnPzIMITzh8J+EZgB6tmxxaqxwX+n8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w6qYd-00Dtqy-3a; Sun, 29 Mar 2026 15:52:03 +0200 Date: Sun, 29 Mar 2026 15:52:03 +0200 From: Andrew Lunn To: Alexander Popov Cc: Jakub Kicinski , David Miller , Eric Dumazet , Paolo Abeni , Simon Horman , Maxime Chevallier , Michal Kubecek , Gal Pressman , Kory Maincent , Oleksij Rempel , Ido Schimmel , Heiner Kallweit , Greg KH , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, security@kernel.org, notify@kernel.org Subject: Re: [PATCH] ethtool: don't touch the parent device of a net device being unregistered Message-ID: References: <20260322075917.254874-1-alex.popov@linux.com> <3c07c51a-421b-456f-9819-9021ddd7b22e@lunn.ch> <20260323150827.24a6259c@kernel.org> <1c41e408-15f2-4c83-8a0f-24b46b1ec1c1@linux.com> <676733D7-814A-4B66-9E49-93DD1259ED48@linux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <676733D7-814A-4B66-9E49-93DD1259ED48@linux.com> > >> That's not sufficient detail. ethnl_parse_header_dev_get() is under RCU > >> and unregistration does an RCU sync after delisting the device. Also > >> not sure you're distinguishing struct net_device and struct device. > >> > >> How did you hit this issue? What are the net devices involved? > > > >I've provided additional details about the reproducer of this vulnerability to Jakub and to security@kernel.org. > > Hello! May I ask about the decision on this patch? > > At patchwork.kernel.org, it is marked as "Changes Requested": > > > However, I don't have any instructions on what to change in it. You need to add to the commit message to explain how it can happen. My question said i _think_ devices are arranged in a tree, and release happens from the leaves towards the root. So a parent should not be release first. If i'm correct, this crash indicates a problem somewhere else, not here. So we should fix that. Your commit message needs to convince me the change is fixing the real problem, not papering over the cracks. Andrew