From: Hannes Reinecke <hare@suse.de>
To: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: snitzer@kernel.org, axboe@kernel.dk, dw@davidwei.uk,
brauner@kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/7] block: check for valid bio while splitting
Date: Mon, 4 Aug 2025 08:54:34 +0200 [thread overview]
Message-ID: <cf845a0e-b8ae-4eef-b6ac-377790771735@suse.de> (raw)
In-Reply-To: <20250801234736.1913170-2-kbusch@meta.com>
On 8/2/25 01:47, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> We're already iterating every segment, so check alignment for a valid
> IO at the same time. We had depended on these constraints were already
> checked prior to splitting, but let's put more responsibility here since
> splitting iterates each segment before dispatching to the driver anyway.
> This way, upper layers don't need to concern themselves with it.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> block/blk-merge.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-08-04 6:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 23:47 [PATCH 0/7] direct-io: even more flexible io vectors Keith Busch
2025-08-01 23:47 ` [PATCH 1/7] block: check for valid bio while splitting Keith Busch
2025-08-04 6:54 ` Hannes Reinecke [this message]
2025-08-01 23:47 ` [PATCH 2/7] block: align the bio after building it Keith Busch
2025-08-04 6:54 ` Hannes Reinecke
2025-08-04 14:08 ` Keith Busch
2025-08-04 16:47 ` Keith Busch
2025-08-05 6:54 ` Hannes Reinecke
2025-08-01 23:47 ` [PATCH 3/7] block: simplify direct io validity check Keith Busch
2025-08-04 6:55 ` Hannes Reinecke
2025-08-04 17:11 ` Keith Busch
2025-08-05 6:57 ` Hannes Reinecke
2025-08-01 23:47 ` [PATCH 4/7] iomap: " Keith Busch
2025-08-04 6:57 ` Hannes Reinecke
2025-08-01 23:47 ` [PATCH 5/7] block: remove bdev_iter_is_aligned Keith Busch
2025-08-04 6:57 ` Hannes Reinecke
2025-08-01 23:47 ` [PATCH 6/7] blk-integrity: use simpler alignment check Keith Busch
2025-08-04 6:58 ` Hannes Reinecke
2025-08-01 23:47 ` [PATCH 7/7] iov_iter: remove iov_iter_is_aligned Keith Busch
2025-08-02 2:02 ` Mike Snitzer
2025-08-04 14:16 ` Keith Busch
2025-08-04 15:25 ` Mike Snitzer
2025-08-04 15:27 ` Mike Snitzer
2025-08-04 22:26 ` Mike Snitzer
2025-08-04 22:57 ` Keith Busch
2025-08-05 0:24 ` Mike Snitzer
2025-08-02 15:37 ` [PATCH 0/7] direct-io: even more flexible io vectors Jens Axboe
2025-08-04 17:06 ` Keith Busch
2025-08-04 23:45 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf845a0e-b8ae-4eef-b6ac-377790771735@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dw@davidwei.uk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®