Re: [PATCH v2 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

[Yijie Yang <yijie.yang@oss.qualcomm.com>]

On 2025-07-25 14:51, Krzysztof Kozlowski wrote:
> On 24/07/2025 10:15, Yijie Yang wrote:
>> The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of
>> the Hamoa IoT SoM and a carrier board. Together, they form a complete
>> embedded system capable of booting to UART.
>>
>> This change enables and overlays the following peripherals on the carrier
>> board:
>> - UART
>> - On-board regulators
>> - USB Type-C mux
>> - Pinctrl
>> - Embedded USB (EUSB) repeaters
>> - NVMe
>> - pmic-glink
>> - USB DisplayPorts
>>
>> Written with contributions from Shuai Zhang (added Bluetooth) and Yongxing
>> Mou (added USB DisplayPorts).
>>
>> Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
>> ---
> 
> This still wasn't tested. Use the automated tools instead of community
> reviewers... Your internal guideline documents how to do it.

Thanks for pointing that out. I’ll update the node name from 
wcn_usb_sw_n_state to wcn-usb-sw-n-state to align with the schema 
pattern and eliminate unevaluated property warnings.

Regarding the regulator properties for wcn7850-pmu, as discussed in the 
previous version, the required supplies are already configured via UEFI. 
Therefore, redefining them in the device tree would be redundant. To 
satisfy schema validation without introducing unnecessary definitions, I 
plan to use a dummy regulator as a placeholder.

Here’s the pseudocode I intend to use:

dummy_reg: regulator-dummy {
     compatible = "regulator-dummy";
};

wcn7850_pmu: wcn7850-pmu@xxxx {
     compatible = "qcom,wcn7850-pmu";
     reg = <0x...>;
     vdd-supply = <&dummy_reg>;
     vddaon-supply = <&dummy_reg>;
     vdddig-supply = <&dummy_reg>;
     vddrfa1p2-supply = <&dummy_reg>;
     vddrfa1p8-supply = <&dummy_reg>;
};
This approach ensures the DTB passes schema checks while keeping the 
implementation clean and consistent with the actual platform setup. Do 
you think this is appropriate?

> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Yijie