Re: [PATCH v2 1/2] dt-bindings: net/nfc: ti,trf7970a: Add ti,rx-gain-reduction option

[Andrew Lunn <andrew@lunn.ch>]

On Tue, Jun 24, 2025 at 02:42:46PM +0200, Paul Geurts wrote:
> Add option to reduce the RX antenna gain to be able to reduce the
> sensitivity.
> 
> Signed-off-by: Paul Geurts <paul.geurts@prodrive-technologies.com>
> ---
>  Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> index d0332eb76ad2..066a7abc41e0 100644
> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> @@ -55,6 +55,12 @@ properties:
>      description: |
>        Regulator for supply voltage to VIN pin
>  
> +  ti,rx-gain-reduction:

You should include the units, "ti,rx-gain-reduction-db"

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Specify a RX gain reduction to reduce antenna sensitivity with 5dB per
> +      increment, with a maximum of 15dB.

Given that description i think you can provide a list of values, [0,
5, 10, 15] and the tools will validate values in .dts files.

> +
>  required:
>    - compatible
>    - interrupts
> @@ -95,5 +101,6 @@ examples:
>              irq-status-read-quirk;
>              en2-rf-quirk;
>              clock-frequency = <27120000>;
> +            ti,rx-gain-reduction = <3>;

Err, how does 3 fit into 5dB increments?

	Andrew