From: Finn Thain <fthain@linux-m68k.org>
To: James Bottomley <jejb@linux.ibm.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
martin.petersen@oracle.com, megaraidlinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: megaraid_mbox: return -ENOMEM on megaraid_init_mbox() allocation failure
Date: Thu, 21 Oct 2021 09:50:26 +1100 (AEDT) [thread overview]
Message-ID: <cf8da58-de8b-e171-5a40-2b10983d447@linux-m68k.org> (raw)
In-Reply-To: <670213ce9e6c3b625e9f8ed66b9fad8ea2843322.camel@linux.ibm.com>
On Wed, 20 Oct 2021, James Bottomley wrote:
> >
> > ... and arguably they would be correct.
>
> Well, yes ... that's why I don't want one "fix" that generates a
> cascading sequence of further "fixes".
>
OTOH, if you don't "fix" it, it generates a cascading sequence of
copy-and-paste antipatterns in new code, and poor training data for those
of us reading old code.
Anyway, I agree that the churn would be too risky. But it sure would be
nice if automatic tools were able to perform a program transformation of
this kind at the source level, being that the compiler will surely do it
anyway at a lower level.
There's a lot to be said for source code that reflects the compiler's
understanding of the logic, rather than the human's.
prev parent reply other threads:[~2021-10-20 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:53 Jiapeng Chong
2021-10-19 11:44 ` James Bottomley
2021-10-20 2:56 ` Finn Thain
2021-10-20 12:13 ` James Bottomley
2021-10-20 22:50 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8da58-de8b-e171-5a40-2b10983d447@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=jejb@linux.ibm.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®