From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC5E638D694 for ; Thu, 19 Mar 2026 20:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773953662; cv=none; b=l8OlyYITVBkxU9TSGvnfk04Y7ExjMp9t8b9YG11MlZ8n2oG4GK8cg50DSM7/SWI+YoGb7yWpphdqGa+bzJm6rhXwBrMRJxsPdp++dFdI7PlPym2abfZaRJJ8S0QruGn5AX7feWHcWCWj61CkoAkARPBM/5DCT2vCHUtqdnmeD6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773953662; c=relaxed/simple; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TaH6EWiV5D0cVH4Aaorw4Uoc3/teGfbolpm8MIp20hQrS5cW4aPHXo4l497fqMdWta25/e81SEO4r5aWANti3OUbiAMBxgXVQcWKKUJQL+lFf3PjjbH3YYC3r4yOpsQtyiUAA8UG29yQWjyA5aVVSiNUEi+4oVgxzkGaTCU7Glk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b6GFm+jD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qh79wZc3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b6GFm+jD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qh79wZc3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773953659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=b6GFm+jDuNBhkRfjTSwJgD7Aakyhg7eTGMDNDONjK/5W4Hl0Wtlh1Yi6lyPZiwEmU87D3Z LU5JOA5GNESmCBjV5hnv0G/mTZ9utDY4Qs2n+1zCTiKmZF2A1P1e3l38qaK9zBlbnMtrKG WPxUFl7rYdNyVJpGzMUe/Qi4Uu6SYuQ= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-JdbI9eQpM-C80vaQsil4MA-1; Thu, 19 Mar 2026 16:54:18 -0400 X-MC-Unique: JdbI9eQpM-C80vaQsil4MA-1 X-Mimecast-MFC-AGG-ID: JdbI9eQpM-C80vaQsil4MA_1773953658 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5091327215dso133108701cf.1 for ; Thu, 19 Mar 2026 13:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773953658; x=1774558458; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=qh79wZc3ATR/C5skVMrlzK8KGEJR54RDEKvr4zyolVp+utRHYQMQNkVPKILnqhBUoT zi/24fDcj3+tTuZGLxepAGrZ+iIwasF/e6irvLv1gqURJWBKDWQhxDdjw51hseGNxUze PZpt15AmjZRMCz9xXibYmEyP2HUn1zPQ2JL8LfIiwPDwRpF76ezEDrrs7Ajxy31+Xg7K xRntHsHtMBnXyvIFviWymZXDWlNY0jK3b7VP1pS7EfrEsI9mMvs4rp8tJRxhcDuFGPPc llBGhKXiAVxDfwhTgezMgkBUNe31htJQVuxjstEUjAOo7SrSMp/giLn6nCWVdrSrf685 WaVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773953658; x=1774558458; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=dHEWP1Cientdh2iscs1uEMLfiEvKV3FJAI6Q/6kklTcuLGbXG6TP+XeO4tfgSsBYLg dSsxaU0xAx89p8iK+P4tIegPZ1yvNt2EmOlLbgqpys9oD3nKHaL1bEs1TqBfxJNCucFd +Kn/dFdeB+Bze1w4tzbSgn8/KRKCOFv+VH+fNFP1QlNzthAL2qLUjJkBdB0BpaRmQX0k puOk1mpAG0UTqi7bY1+VJLKDm3VBK2tGCq/Nuh5nlYGDbZVgQ+yt6K+PDJD/pr6znnh6 Tno+y7aRfVwgp1xsGSBPXa6Mown4hc80gzfrJe4XYUkdH6CDZZelwheCtgjitrD4C8ST B3DQ== X-Forwarded-Encrypted: i=1; AJvYcCWCOqmN2hKjs4hacQ/oPwf5nnGo7mvfSeRNwS/guBBiDcSfxoN4qn653+U4J8h9xAqYVeleVmgBzaPR4lc=@vger.kernel.org X-Gm-Message-State: AOJu0YwZdC5jXogDzDQj8V6QimdZCR3UyTyOvtbThQ14G5x9Pt+raWxh lQP+auISYXJD7ISR3Y/uBbP4F+FoQU4fYukmyYVkxO8qXWGbHVcRVJJAlxLV0yjD04pGlbFEhoJ iSBogqZoWsCTUczFVEPRQb/TWv8wgZEMkDYmvLn6hPJYK/5kymeoq6pOxGh9DKJitxA== X-Gm-Gg: ATEYQzxUShtFvY2D/wXW/fgBqg66HfIhu+55WH41i0pRVObPFm5kGpp3+94eAOonZQi FUT8fuSD74fp3HRPgrKV/cqqt/nIZeJv/b613AWbEGqMQQ0IdMut3cDN7KEIT+ovyPcDFicRZnN 8rb6mByDi4GRHHr6QqXnqllpCoqlKR6XQE+jIWntF+oUKyc5GUUD0VwWkq9MFdhP46NL1+i3WWD Ph9kZcIu5+3dA75gY1Zedy5X56UhgLkajvk2JPc03s3oi0eP637xdfgiY5HcowX5wmS9wETAf0f tBTqiy1StQ4BM6aqUxueBWtlu7q3ONOgpdvtpvetzbHdBJnphsNuwYmW3rtssMDSMYQE4iJEQ/Z /cEZ/8WqF4CpJ11GdIDAZ3Q0KN1F+f0Pl8WzXA55ib0Ib6qeccce9DZ5ghoEjDEBrlKVxPKTyOe 3/hpBXkYocLVFZ/g== X-Received: by 2002:ac8:7f54:0:b0:509:4e1e:1b9a with SMTP id d75a77b69052e-50b37586c7cmr10127051cf.54.1773953658126; Thu, 19 Mar 2026 13:54:18 -0700 (PDT) X-Received: by 2002:ac8:7f54:0:b0:509:4e1e:1b9a with SMTP id d75a77b69052e-50b37586c7cmr10124851cf.54.1773953655634; Thu, 19 Mar 2026 13:54:15 -0700 (PDT) Received: from thinkpad-p1.localdomain (pool-174-112-193-187.cpe.net.cable.rogers.com. [174.112.193.187]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b36e350c3sm6518601cf.19.2026.03.19.13.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 13:54:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v9 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains From: Radu Rendec To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , Martin Blumenstingl , Krzysztof Kozlowski , Lad Prabhakar , Konrad Dybcio Date: Thu, 19 Mar 2026 16:54:12 -0400 In-Reply-To: References: <20260316-qcom-sa8255p-emac-v9-0-c58934e76ff2@oss.qualcomm.com> <64d282fd94be1546df75d7df5b47eacc0479797a.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-17 at 15:12 +0100, Bartosz Golaszewski wrote: > On Mon, Mar 16, 2026 at 7:31=E2=80=AFPM Radu Rendec = wrote: > >=20 > > On Mon, 2026-03-16 at 13:05 +0100, Bartosz Golaszewski wrote: > > > Add support for the firmware-managed variant of the DesignWare MAC on > > > the sa8255p platform. This series contains new DT bindings and driver > > > changes required to support the MAC in the STMMAC driver. > > >=20 > > > It also reorganizes the ethqos code quite a bit to make the introduct= ion > > > of power domains into the driver a bit easier on the eye. > > >=20 > > > The DTS changes will go in separately. > >=20 > > I'm seeing some weird behavior with this version. The probe part looks > > good (but see below), but when I try to bring an interface up, it fails > > with ETIMEDOUT. The relevant part of the stack trace leading to the > > error is this: > >=20 > > dwmac4_dma_reset+0x208/0x220 [stmmac] > > stmmac_reset+0x2c/0x68 [stmmac] > > stmmac_init_dma_engine+0x108/0x400 [stmmac] > > stmmac_hw_setup+0x5c/0x538 [stmmac] > > __stmmac_open+0xc8/0x2a0 [stmmac] > > stmmac_open+0xcc/0x238 [stmmac] > > __dev_open+0x138/0x2a8 > >=20 > > Now dwmac4_dma_reset() is very simple. It sets the soft reset bit in > > the DMA_BUS_MODE register, then waits for the hardware to clear it, and > > that never happens. > >=20 > > Now, getting back to the probe part, there is one extra message > > (compared to my previous successful test on v7), which I see at the > > very end of the probing: > >=20 > > =C2=A0 qcom-ethqos 23040000.ethernet: clk_csr value out of range (0xfff= fff00 > > =C2=A0 exceeds mask 0x00000f00), truncating > >=20 > > This is a sa8775p ride board, so there are two stmmac devices. I only > > see that message for the 2nd one, which is also the one I'm trying to > > enable, and which fails. > >=20 > > I realize this may or may not be related to your changes. But there is > > no way to test on a SCMI-pd board without them. I'm not sure how > > relevant it would be to test on the non-SCMI variant. I'm assuming the > > DMA part should work the same way (regardless of SCMI-pd), so if I can > > reproduce it there, and since I know it works on mainline Linux (that's > > where I tested v7), I could bisect and see which commit in net-next > > breaks it. If you don't have any better idea, let me know and I can > > try. Meanwhile, I'll keep poking at v9. > >=20 >=20 > Does current net-next on its own still work? Or is the second > interface broken even without this series? I don't think there is a way to test net-next on its own (without your series) on a board with SCMI-pd firmware. It would require the qcom-ethqos driver to have direct access to the clocks, but the clocks would not be there. What I could test though is a board with the "other" firmware (without SCMI-pd). And on that board, I do *not* see the problem even with your series applied. In fact, I tested the exact same kernel build I had previously tested on the SCMI-pd board. I'm not sure what to make of that or what else I could try. FWIW, the "clk_csr value out of range" message I mentioned before is still there on the board where everything works, so it's probably a red herring. --=20 Radu