From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A06FC678D5 for ; Tue, 10 Jan 2023 10:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231518AbjAJKJ3 (ORCPT ); Tue, 10 Jan 2023 05:09:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbjAJKJZ (ORCPT ); Tue, 10 Jan 2023 05:09:25 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 864DA4FCC5 for ; Tue, 10 Jan 2023 02:09:24 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id j7so6147030wrn.9 for ; Tue, 10 Jan 2023 02:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4xYMRRUsS1/+nnFrFeQgPKlK9gLI7LgQiZoVUnSBgI4=; b=qv97nGmxcMwyDTmIwBmhhqeVq7UvyuI6iU7kvOwVo8BBBun+sOpEaBXhRZuXzF2lwK MCMbDYxMR0eOlY04P3bmwdWu7EN8bpri+p40F5B/q5+dLnMOsfb2Xsfa+Y7KdqoktCbX iXg80PPWBS1Y1e+d3/jV+b17UIoDmmWLMK7VJwaAdH5/r9nlajOsaZzzwf6dGExTjAPQ Qc6ST8MYR/Up7JBw21L2A83NoNKolRor6JH8DuFInuWFmPMe2tdlM7xbH9GhpUKELP9y k3QkZJWdaA9SjGyBcr/MR/eo2hzOMNCo3VnhsTUM12Zzpwx7NdV0JXlLTGrk4PVXKQW4 wJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4xYMRRUsS1/+nnFrFeQgPKlK9gLI7LgQiZoVUnSBgI4=; b=lybR7VV4X2a9CCzyxUlL5EEgI4iRYUMFDGoyai8f89hulK6YRKXtgRFgmcP1cZDlPa nsrwoS1AzXWYzyB5N0F9e2wQpNbSSnMrRL61PvokhKXHZHb4HCraWOkCWsdHgYI4jy/T afqYSxDgNGXtJfUu2RL4Ea6AkngjwuBe7cKlk57Vwwmeg/LZzqvEk9FD+BAbsWbaV995 Dc0KefXbZw47YYC+6dl6+hdAzce3sGdZZzOmeNN0ALKqz9/Po8fYLIegY80S7lJEf3AR hMFVFJGpRdfaKYmx43hg/vJWT+78A4dWe6CgPllElq7fr/nzFu7Wj+VmrEQz9jNdh4wg Y23Q== X-Gm-Message-State: AFqh2kq4hTucrISFlBXH11xphMOOITlcg6M0TPHlCG89klx3yQc8Ebhf 0P4Caa5cdCD7C3LMx+eoRUKGcQ== X-Google-Smtp-Source: AMrXdXvgLV7H2Uc2y/x8gtRgon6k5ihb8NLU90cU65YiJ7wiU3KJIYxoeQYWyHlRrsCA7g0NdwEfAA== X-Received: by 2002:adf:ec85:0:b0:291:4088:a634 with SMTP id z5-20020adfec85000000b002914088a634mr25413839wrn.40.1673345363032; Tue, 10 Jan 2023 02:09:23 -0800 (PST) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id u5-20020adfdb85000000b002ba2646fd30sm12631012wri.36.2023.01.10.02.09.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 02:09:22 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 10:09:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH bpf-next] bpftool: Add missing quotes to libbpf bootstrap submake vars Content-Language: en-GB To: James Hilliard , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , linux-kernel@vger.kernel.org References: <20230110014504.3120711-1-james.hilliard1@gmail.com> From: Quentin Monnet In-Reply-To: <20230110014504.3120711-1-james.hilliard1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-01-09 18:45 UTC-0700 ~ James Hilliard > When passing compiler variables like CC=$(HOSTCC) to a submake > we must ensure the variable is quoted in order to handle cases > where $(HOSTCC) may be multiple binaries. > > For example when using ccache $HOSTCC may be: > "/usr/bin/ccache /usr/bin/gcc" > > If we pass CC without quotes like CC=$(HOSTCC) only the first > "/usr/bin/ccache" part will be assigned to the CC variable which > will cause an error due to dropping the "/usr/bin/gcc" part of > the variable in the submake invocation. > > This fixes errors such as: > /usr/bin/ccache: invalid option -- 'd' > > Signed-off-by: James Hilliard Acked-by: Quentin Monnet Thanks