From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D10B314B76 for ; Tue, 23 Jun 2026 06:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782196448; cv=none; b=jq1Teml7Pv5MldKIZq1ind6X/18Gk6Q8tGs/SJnswKXA+uvi0LgBCp5wdixjz1IyW6JdPtYPg5OmZV0DgdDc9/knOgOovPdZ0r3BQ3jsA54CAh28gOr17QHO9tolkxBc4QmYTbrTDr3Y/0jJzSgPExAtNjEfOW8mrrXG1i62Zvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782196448; c=relaxed/simple; bh=c41GS6byMdgzPlJMdkS6ltuAmcNP5Cpu8h+GhWoORiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=by5i9tijzSyywQEKm6sEXvyhKmJyHtczdUd98CrtApcW1ACVg45GMK//oiQ6gHteq81fTUiBjmrh9mAEr+1O/kRee5Hc324o1BSQtqykni/gT4cDAvCzndgA/KF6ZAaCIY/kEcrLe6h2IPiHwTTPrShqOcVQiPrudc37URQNDbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QnEWeU+R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XQqOz4kU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QnEWeU+R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XQqOz4kU" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N0l2XF2869382 for ; Tue, 23 Jun 2026 06:34:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RWx0gdwex8o21W9NKWEoQBE03/Z8wuoolfwNIjEcNC0=; b=QnEWeU+RNdBmYzjb yjV8ezRCkvGMiRrlnzjNRtMMfI59QNSM6VfY6YoWCZoCAnkE300qqgyCfb+3TrqP R1sx+1cxftHUSZivgVKmMbcbWwxtZwyTS03Ec3be4PbC9ajmG9okmlbFSapPCdPm gUXH2NeAiB13VH7kTsnDQemmBCEk6do5GUc03K7g17xiqPrt76kyeaVdLVtMm0/T Zo/ZikfMwBhRNYhS+SZe19D+ETU+NoIKamuZn7Xk9hwLzDjKVKhM6hfAgCTXfNRr 0C0Zf4GX98CCPKFkbnWbXnJD4W9pxMyFGdBlku0Ly1Y78j2qaWg5d3uHN2k1k44l KlGghA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey6tmu1jt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 06:34:05 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-37ca93a9253so3455928a91.1 for ; Mon, 22 Jun 2026 23:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782196444; x=1782801244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RWx0gdwex8o21W9NKWEoQBE03/Z8wuoolfwNIjEcNC0=; b=XQqOz4kUF18Uv9xzl5Ynp3QuF/lx3bdH8lgRPrhKyg2lcNTzELjKf5h949Gy5gpG6P dfuWVicvDVzRjJvTGFLA4gBi6uiPl6sIAex8RpwJA0V+uDanQrqm9RAg7WdlZz8o+lGO BFZCh4V29wvENGDaTZUs3PFFceGEB5fmAT6411zzPI8SNa8C4vSqV/ptCj6Kovi9K8NV KuzsJMnmThwjXsZL9zzZln9A7odr9dgU/4J7VkMNHGvE3xNf4OzQUDHtXZpYbfbW9S2g r/K0RTUSLNSD+3BHU97KanboGyQbOM7WuAcPUqPbywxUxFcnxyQw39menS1GfSklx7py 2puw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782196444; x=1782801244; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RWx0gdwex8o21W9NKWEoQBE03/Z8wuoolfwNIjEcNC0=; b=s/bvyGpkCncQwiSBplOdwMwtOVTU7bJYHzYX7AlZ6LoowtkOFjCsL20eXh6HNNxjJF uTyk6YoQYrbLGTLdwnJxxnGC3wkNAkGoyi/DVp4b75wmVDXTl928eXHd0i468auqza7P tDo4GoJ50Lh6tAb0sKcwH9DMptj3gsVL3ryCzcfcBqJitnok6iS7hFpo+BDX6HmU9JqA LbYCai8eUvejcU7VIGhd1Xo4UR/Viw6ikSZblbW0b7SGlwbQaqNaKqJ91R4lMjb1bQ/m kxhWIM8s/08HhU4+IZFs7SShr13cKM4KrbZFkTp+UphrVpBUbkv/1f0OhYIPXqqJIOLm oDuw== X-Forwarded-Encrypted: i=1; AHgh+RoyRZmVgkcDvQY5vNy8YbujGrIZqFjUVmhXqA/vvRlEHtQrv3xk55UNzNOfjjf23dlrM9iFUpFGiwHwPFA=@vger.kernel.org X-Gm-Message-State: AOJu0YztlWuebN8ycEuuy6XGSbI+mh36Ot9f3AFlUmzN0huQ9TFoNiLr r1n84MmhpyTR+i+YRd7izR+kPwhEqFbA9lAdiMrLLF42GnLN5fqDXlw0c+/vl6TOCb3BNLAML3J ttJ+sGfCwcuSkScfVgq3M/Tq6DvhzQtzVUlSzlYDbV/reJLqSIpd3W+j0Fc1EwT0KkIc= X-Gm-Gg: AfdE7cl/mdO4axomdZUZNmWmXbjYbKAg+Ghx9rtY+ZorfxGxvRTpb6Rbeu+MFJ0Zwo6 ZbcTq7VnCnpjrgZLrQZccWUWb4tJ6ZqEk126oS9Bkgzve40GyyW2cxVteqfZXPPM+CHDhHStt9b W0yT6QMXiLAKC+skHAcs/I07OPjDkBEEfGmQa4zbpQF34fAtw493pfIWsj73sFcozPLaDz4Uw9m YMsxmv/+i71V0GtomPSSb872mXjVek5xoa19LY8dSYO8mX7uAKX8iiUSbPIuJo3tM1JUNbhWpFT qhuflHGF9RHpSDmfzvE7MM+PsaaPenII4R5yc7xTWRJIuT4ZxDI5pYxy75qriOlupsHwwx6M2Ef UnL026nd3XHNqXEsQHKCDBmY9TpNj9nMN8NM8b4cxGLEGxhK4MQ6sPHCHXVb+ X-Received: by 2002:a17:90b:1f91:b0:37c:83ec:1641 with SMTP id 98e67ed59e1d1-37d4d71d7d0mr13004091a91.5.1782196444316; Mon, 22 Jun 2026 23:34:04 -0700 (PDT) X-Received: by 2002:a17:90b:1f91:b0:37c:83ec:1641 with SMTP id 98e67ed59e1d1-37d4d71d7d0mr13004063a91.5.1782196443843; Mon, 22 Jun 2026 23:34:03 -0700 (PDT) Received: from [10.137.71.130] ([106.198.36.229]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d15df815csm12594916a91.15.2026.06.22.23.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 23:34:03 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 12:03:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath6kl: fix use-after-free in aggr_reset_state() To: Daniel Hodges , linux-wireless@vger.kernel.org Cc: tglx@kernel.org, mingo@kernel.org, joe@perches.com, vthiagar@qca.qualcomm.com, rmani@qca.qualcomm.com, jouni@qca.qualcomm.com, kvalo@qca.qualcomm.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260206185207.30098-1-git@danielhodges.dev> Content-Language: en-US From: Vasanthakumar Thiagarajan In-Reply-To: <20260206185207.30098-1-git@danielhodges.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA1MSBTYWx0ZWRfXzxfforGvN2Eo 9vc/n7kS3uGg8Yn+EtrAlp9T3bx8RBBT9qPF3lksrpE70vVSLxBp9S2QB7w5iod+raWNhP/548a V5xrpG0Fz71fjZixLaJEJcbCI0Tp4YI= X-Proofpoint-GUID: aEzmLNBH29_YWhHiqrk32pq3WaJpdLuR X-Proofpoint-ORIG-GUID: aEzmLNBH29_YWhHiqrk32pq3WaJpdLuR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA1MSBTYWx0ZWRfX3sG7HPNp4HjE V43ozVfKcrIEUoEtSkAj/6sZ93PIokJxvf4vV5iNFyfpQMvIzpAedQsz/+fpksllDWVmPEVi29r ZiCXAJVJcwnScN0ItabDxOwBDnRu6d/WNG/wmsTL3YmNB296GAlUDmPlQi8GUZHL8rty4430Kbm agqmfs+e/WWOjiywctJUjGhcQyxgAGv8eWfID4j22T3OyRhcd+iJH1kr1+2kD6JPRlKjzkkV3Qm qtg3HJ6wEk8coHBp1XiiO6HvHv0IdpCAuN3aITL+Ol4fHYLFdbSpQua72xj8wqOrKe7+Pb3ABq/ aUTS5sdQ3zUXv2xLr3Uw8ONePmzhQt1q0FKYr3uT5UnYmpBM2IShwBKXG1qwOvAYuwRgvUiRInn CJIZ3xjK9wBCxOysUW5/UEcrk3tQ1YNaee4JGsZuyd7g7ICOxDOHz2XikzsZXTwles1jzHc2e4t KbZwoqHP1kyOsftWtLw== X-Authority-Analysis: v=2.4 cv=H4HrBeYi c=1 sm=1 tr=0 ts=6a3a28dd cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=6/2MXK9rXRWb21GBy9lArw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=yrwDRl_2H5AUk312M7UA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_01,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230051 On 2/7/2026 12:22 AM, Daniel Hodges wrote: > The aggr_reset_state() function uses timer_delete() (non-synchronous) > for the aggregation timer before proceeding to delete TID state and > before the structure is freed by callers like aggr_module_destroy(). > > If the timer callback (aggr_timeout) is executing when aggr_reset_state() > is called, the callback will continue to access aggr_conn fields like > rx_tid[] and stat[] which may be freed immediately after by > kfree(aggr_info->aggr_conn) in aggr_module_destroy(). > > Additionally, the timer callback can re-arm itself via mod_timer() while > aggr_reset_state() is running, creating a more complex race condition. > > Use timer_delete_sync() instead to ensure any running timer callback > has completed before returning. > > Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Hodges > --- > drivers/net/wireless/ath/ath6kl/txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/txrx.c b/drivers/net/wireless/ath/ath6kl/txrx.c > index c3b06b515c4f..25ff5dec221c 100644 > --- a/drivers/net/wireless/ath/ath6kl/txrx.c > +++ b/drivers/net/wireless/ath/ath6kl/txrx.c > @@ -1828,7 +1828,7 @@ void aggr_reset_state(struct aggr_info_conn *aggr_conn) > return; > > if (aggr_conn->timer_scheduled) { > - timer_delete(&aggr_conn->timer); > + timer_delete_sync(&aggr_conn->timer); > aggr_conn->timer_scheduled = false; > } > Reviewed-by: Vasanthakumar Thiagarajan