From: Leilk Liu <leilk.liu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-spi@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 5/6] dt-bindings: spi: support mediatek,need_ahb_clk flag
Date: Mon, 14 Feb 2022 09:53:35 +0800 [thread overview]
Message-ID: <cf97cd654fc2549065cbfc78e9c45ecb06232059.camel@mediatek.com> (raw)
In-Reply-To: <YgaV6w1ooAzTpYNz@robh.at.kernel.org>
On Fri, 2022-02-11 at 10:59 -0600, Rob Herring wrote:
> On Wed, Feb 09, 2022 at 07:19:37PM +0800, Leilk Liu wrote:
> > this patch support mediatek,need_ahb_clk flag.
> >
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> > .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 5
> > +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index 241c0f5880d3..af12c1711182 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -71,6 +71,11 @@ properties:
> > specify which pins group(ck/mi/mo/cs) spi controller used.
> > This is an array.
> >
> > + mediatek,need_ahb_clk:
>
> s/_/-/
>
> But really, this should be implied by the compatible string or
> presence
> of the clock in 'clocks'.
so I can only add "spi-hclk" in clocks' and don't need
"mediatek,need_ahb_clk" again? thanks
>
> Rob
next prev parent reply other threads:[~2022-02-14 1:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 11:19 [spi: mediatek: add single/quad mode support] Leilk Liu
2022-02-09 11:19 ` [PATCH 1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode Leilk Liu
2022-02-11 11:44 ` Krzysztof Kozlowski
2022-02-14 1:41 ` Leilk Liu
2022-02-11 16:55 ` Rob Herring
2022-02-14 1:49 ` Leilk Liu
2022-02-09 11:19 ` [PATCH 2/6] spi: mediatek: add IPM single mode design support Leilk Liu
2022-02-09 11:19 ` [PATCH 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode Leilk Liu
2022-02-11 11:44 ` Krzysztof Kozlowski
2022-02-14 1:43 ` Leilk Liu
2022-02-09 11:19 ` [PATCH 4/6] spi: mediatek: add spi memory support Leilk Liu
2022-02-09 11:19 ` [PATCH 5/6] dt-bindings: spi: support mediatek,need_ahb_clk flag Leilk Liu
2022-02-11 16:59 ` Rob Herring
2022-02-14 1:53 ` Leilk Liu [this message]
2022-02-09 11:19 ` [PATCH 6/6] spi: mediatek: add need_ahb_clk support Leilk Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf97cd654fc2549065cbfc78e9c45ecb06232059.camel@mediatek.com \
--to=leilk.liu@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®