From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792715973; b=xqI0nU+eKk3hyKWxrFnpYrb5frdhBQi3YXzBY0rXqdZlFgliAWENZZKhTWqixR8cEEXY sDWtU+d7IMKnFR66GK3/G91xFnaR1HB5XaC8eGM4T5TQwP2LEHKyHOtrq8Z9HZONSOSS1 Qmj6xJZ31hZlhQzGfJc/offg8vfyrFLDizrrUIJ8NL9eP1Jfn8eUkS19V8bv0uKoe4hz4 3jQ7oLrNm1Fiyx5q+fxkCgsZFNBNpp4ubt7xbgEQiH9oKxW+ZY0fC6EbTvtNbjudzFvug 41FQ7D3Ea0Ei+2WHwyIorfa16AjEEzQNIs6N/BFamtkOX6c9EC6thV58tTBjnra9PUw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792715973; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=A6RNJ/XouteAEf4O3iDFpm3n3GqxKKGhT7l2XrAWWds=; b=xOdV3J6Kj4WmZhdWBpI1Rm3WvJ7SDuCJQ8jtZE9NkH4UNDyx9+Q9hcG+IvyBxxewmsjy KlsXFHq9C/n6dWSTt1dqYjQS1aZ3j/yoRCjl1dkftYZJx2pregQp/w89UwjYRcSfbx2qL 9CiqB/pFvcVvttS6wPR9ldMjRBq8mOYUOyKKfyT1RcTXQPUM38mdObd7i+LN6EMaYCKcI Le4Z2hN5JIjZ876gxK0d7V9kNQXmVqiFjA/HUnC0W6B3tqUL3xdM1bV/vXCCopW/DMyM9 a7b6rJhXtOSE2IpqiyXmdLzkSwhd8jU5JHZlSsg3oV/kzS28tys1RxUwTTN8alL4pYA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mpT76HSW; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=jNUyCMFC; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEFBE606A31E for ; Fri, 23 Oct 2026 00:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AEFBE606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mpT76HSW; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=jNUyCMFC Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69MMFDMq2012911 for ; Fri, 23 Oct 2026 00:39:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A6RNJ/XouteAEf4O3iDFpm3n3GqxKKGhT7l2XrAWWds=; b=mpT76HSWOTccoYwd cWDIYcLt612dCn+7YSprQ1P6L6p9IKEURGiENAPpAV7QxXyapgu1EZmZPPVhYvN6 2PKQIkNe0I9xsfTOnhPP+DFyCvo8Avct+uFzL3nuYxaFn/EvGtrhoT9PA2xn9cJ/ 8zatABrIFqQCZqVb22TVssyXpauAP44+nh9TqBc4+tPYCdMsoL97upYC30PEE9h8 Ne5hLDe4B+DHLTspxK6GQVEV315onVUNE5OdkgPaEGhHHRUImZySB69ZcpDPuCQn GN9IESREjDyOP+oVyMw5Bn5oWs1Wx04BsBsMua5AzGzttME0y28G2vz5pr3y1fYf RMK5ug== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hfqmp9688-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Oct 2026 00:39:18 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-3580c07911eso1066192eec.0 for ; Thu, 22 Oct 2026 17:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792715958; x=1793320758; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A6RNJ/XouteAEf4O3iDFpm3n3GqxKKGhT7l2XrAWWds=; b=jNUyCMFCK0Cr58JWnDOYJl4CZquc8AVfkFAd8GEyKzethHc4FvbqofEjjoM5XcBAS2 yTrMFZTRHCg3qcb1BUxLrtoC4cZ+OHUnVUMfLOe1a95AOV7MmmTcNdZhOo5RgyzOBWHY e1MV+67OLL8SjCxUGXPjkbO0EyalHmDTNlhmWL8g5T1Pi8xmKwYldcSN0a3CnzzvYGbG qNp4HTOWGoavXEwTM+uT9QfOdoC1+9/eAfLUTyDmDXmxj3GnSoMBUcu0iVPwH0Z9Ws+t Qmnw3Sr+U9jhcG6bLdq9wnJrn3pERvLLuz6TOdEcyFL+QXxoy7FvS5n4BNH18iiUsgKZ bliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792715958; x=1793320758; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A6RNJ/XouteAEf4O3iDFpm3n3GqxKKGhT7l2XrAWWds=; b=Mt0v56G21il3AYwwi90XuSaaR29Q6+tPJ5XMOs4DU8gUiSJUXiymAulNHhE5bODprA eWCZPFtoEgHaVE+KvSUEpwa45CI0zHmyx8uAkaGYp/F+2MRsuD7p7tUQ2Ov7pG/Ze7og v0x8qOuLdy5RVFoVAn2pDuuvScw0YSLsD4NjmazynOgRGHAQyurgecFGmWv9YGsgdzvm h9fuet1IjZIPYH7uXyJlOXt0HwlVWk0xVgUaiAR0zhS79vrX+r+DEdXxVTI/JteJswOT TRVTqEN146T7L1BIeRksXdUo1oS9EOQz9sz2gtFghZqXfWIFgGq32Rrg1/0UfEPDJvF/ sx9g== X-Forwarded-Encrypted: i=1; AKwUvBzsma7AjJGlWlRnS/8+v5j6epZoVA1zagmj/TCbbwFKDqLYDGK1PBt4yKn/bY737Lo07pRW/gJ4SjtVANw=@vger.kernel.org X-Gm-Message-State: AFq9FYJwAOK7q89yYu3d2R0sq4aPesIwEHGKI9aZO4+OolfZNAPF/H78 hi967waaPc4YdFCqv54hdMxjtLAFcDPvV8Zvki6+6WYyOBJRZ7AbzfcE8OwPHSsVF7OsXGwjyIj /w+1qkjRb4PwLAFCoX0PtVgOTZ8YL41o+A8ZOowU9wroYFL34r8/G4Z5YqZtThfLQHtI= X-Gm-Gg: AYBFou0s586YAc7HotTamz66pA/QdzHpTzCkKFzuY0GUdS4Q1+KNHeW4C5UXtODyvFA 7JJKxJ6hokkyIRAA/KImJQvHxBwqz5DPV/4a5zTFajXM2vG4O74p0MeSlxZ5pYeXR5MD2NLLhKf 4TfwCexlWDtk2gctoAgJFJlSmaPVBVX54pRBohremwa15VCRz90QCzqgZfoIytl+oFe6vpgLg2d 97HnU5XYeY759khn2OpPRIcmKfzxRzlhukL33riSvbWqqGoYwDbDiXSBcftFrAGUEzEZS0CoZnG VyAJ7TYaGKhE4BM82nVYRUqgrQ2FM+1XS1fXgKPpyDLvzO9z6QTHr5Ne77kZh6aORAxw1O+mFY9 RoWzBTqLDJoneyyAIzZR+dFB4k2/lkq0jTxqAvjaOhHOnqZKFiitRDiJfAQ== X-Received: by 2002:a05:7300:8810:b0:367:174d:c8d4 with SMTP id 5a478bee46e88-369d971f2camr945859eec.7.1792715958050; Thu, 22 Oct 2026 17:39:18 -0700 (PDT) X-Received: by 2002:a05:7300:8810:b0:367:174d:c8d4 with SMTP id 5a478bee46e88-369d971f2camr945827eec.7.1792715957498; Thu, 22 Oct 2026 17:39:17 -0700 (PDT) Received: from [10.71.181.181] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-369d9dac9casm1449378eec.15.2026.10.22.17.39.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 17:39:17 -0700 (PDT) Message-ID: Date: Thu, 22 Oct 2026 17:39:14 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] phy: core: add generic MIPI C-PHY configuration API To: Loic Poulain , Bryan O'Donoghue Cc: Bryan O'Donoghue , david@ixit.cz, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vladimir.zapolskiy@linaro.org, mchehab@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gjorgji.rosikopulos@oss.qualcomm.com, jigarkumar.zala@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, linux-media@vger.kernel.org, krzysztof.kozlowski@oss.qualcomm.com, daniel@quora.org, konrad.dybcio@oss.qualcomm.com, christopher.obbard@linaro.org, alex.vinarskis@gmail.com References: <20261017041733.3946816-1-anusha.nandi@oss.qualcomm.com> <20261017041733.3946816-2-anusha.nandi@oss.qualcomm.com> <324dcc61-6085-446c-8bf7-564486f319bd@kernel.org> Content-Language: en-US From: Anusha Arun Nandi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIzMDAwMSBTYWx0ZWRfX8FWOQm6Akhky x8rMoE6eHtofaf6wY9B3j/o/35QhcDj5WBxd72Qx0P/l6tAlrV2K+rKBrmDl/4wGwztfKMmVQhD z4xgMVJmvmTlPKFEvWHW7Wi8DH5LKVg= X-Proofpoint-GUID: XksWuubp0Pwc2klWTDK_OCTurSU_cPyC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIzMDAwMSBTYWx0ZWRfXwwsIoe2mXCRJ GIUrio7mK7DhBWMAjaijjuKv8pjtRUavfOaxdidTKwJq8yWezhkIlpRFRtgh8nyxq7UTRyLTt5O R/ccRSaqn2bzCYhjLQqA237SEUNyTk7fup+qNC6Uw7eGazGr2bnse0zyt5Or+jKLdUhapPCUoMD R81p7WyUqhDA3JZEU7XOt4zP2nvoXdi1HorTuXsqMRHkx1hmXxRAk02rMhCYi/jbrnhaQqvnCTk v+YRSZQnWudD3nE0AhenxqDsB+jJdwBjiyVrdw8tyfpZ4u1H8SryjnqdOqPxjbhCZl8lRBhBtKW mkSfXcE9r8kmWLRdZZiEV9mR2Wk/0cx2bITIL6kb7KJF7yM+2wgi5N3nNSd4xbE2L9/PhSD7l66 G7/sICgOmChBlhOLIxcsVKiGY72OWXxeSlY2RpRkeaDmyLiZz80vsduRN2GZ5v6NHM3p8/w4HM3 FuBbC7rYRIvIkHTCtWw== X-Proofpoint-ORIG-GUID: XksWuubp0Pwc2klWTDK_OCTurSU_cPyC X-Authority-Analysis: v=2.4 cv=BdBNQbt2 c=1 sm=1 tr=0 ts=6adaacb6 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=rkvrVZJLu5XtR-8f-ggA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-22_07,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610230001 On 10/19/2026 7:15 AM, Loic Poulain wrote: > On Mon, Oct 19, 2026 at 1:24 PM Bryan O'Donoghue wrote: >> >> On 19/10/2026 11:24, Bryan O'Donoghue wrote: >>> On 18/10/2026 00:00, Bryan O'Donoghue wrote: >>>>> + unsigned int lanes; >>>> >>>> This statement and how you go about using the data aren't consistent. >>> >>> Re-reading this. >>> >>> unsigned int trios; would be fine too => data_lanes and lane_polarities >>> is a multiple of trios - always three - does it imply that the first >>> three entries in data-lanes == the first trio ? >>> >>> Presumably. >>> >>> That would work too. >>> >>> data-lanes = <4 5 6 1 2 3>; >>> >>> => >>> >>> trios = 2 >>> >>> => >>> >>> data_lanes[4, 5, 6, 1, 2, 3]; >>> >>> trio[0]:lanes == [4, 5, 6]; >>> trio[1]:lanes == [1, 2, 3]; >>> >>> Probably "trios" instead of "lanes" makes more sense here and the driver >>> just always validates that count(data_lanes) % 3 is always false. >>> >>> --- >>> bod >> >> I'm going to argue with myself. >> >> data-lanes = <1> >> >> => >> >> lanes = 1; // not trios no need to introduce a new term > > I earlier recommended using "trios" in the other C-PHY series to be > more accurate and emphasize the distinction from D-PHY's (two-wire > lanes), and because it is the terminology commonly used in the C-PHY > specification. That said, I'm fine with either term, but yes, we > should be consistent and avoid mixing "lanes" and "trios" within the > same structure. > Completely agree. I will be using data_lanes to clear ambiguity.>> >> => >> >> three pads on the Soc >> >> => >> >> The question is - is data_lanes required for the CPHY opts struct ? For >> the qcom CAMSS case the answer ~ always no - we will be attaching a >> sensor and will read-back the positions from that endpoint. >> >> It is conceivable that other systems may want to pass data-lanes down to >> the driver because they won't have a media-graph but, I'd say we should >> arbitrate that then - leave it up to someone who needs the fields to add >> them. >> >> => >> >> lanes // the CSID and PHY should agree >> symbol_rate // so both the CSID and phy agree on symbols per second >> >> Remove: >> >> - lane_positions >> - lane_polarities >> >> Since at least for this series, they won't be needed. >> >> The CSID still needs to know the number of lanes and how many symbols so >> that it can calculate bandwidth so .... lets just include the data we >> know we need. >> >> struct cphy_opts {lanes; rate/symbols}; dropping lane_positions and >> lane_polarities. >> >> I've no objection to the low-level timing variables myself but OTOH we >> don't require them at this point in time. >> >> Perhaps drop unless/until someone can show a need for them. >> >> Excellent bod, agree with you now. >> >> --- >> bod