From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC73030B514 for ; Wed, 14 Jan 2026 05:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768369385; cv=none; b=CnGO6jROBYzlu2Ll+aSipoJ33/0OyZv7yX/+JbcWXbNIeQ3hW7LlQyHttG+h44FvTIpo9boICbm9Bpx1PQbXZ6629TrGTUh14J/jj8Q91WsYnBRpu0Acr6RHy5ZlB5IRzm8qY5WJpNyRVYLp78htrywLRMnVvkHlq1WpEREc0wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768369385; c=relaxed/simple; bh=JJTMFk75Gutd2cMz2WE3Y+uKgBt/r2fjdYpl1po23nc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gHW1zmBYzx+KxB7wLbFBD4zVjEzGdg5xRIUDNLqSCOQbMAWMh6b58exmfzxWTpDVIZMc1xoSzEEOawrD3apWCO0aBcUJn5sCkLUBG9K7cq2REw0j2zWyxeTmC7jO7iW9xdL7PPacCE4y2iitUu0/r91iyLZV0DC9tFpTEiKfEr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P/o+CV+S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J/6DRws8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P/o+CV+S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J/6DRws8" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E5EY9n2653527 for ; Wed, 14 Jan 2026 05:42:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VxdvyYzIZyOHUwmxqd8hJRQXBpXJoAEPCSYU7mtFibg=; b=P/o+CV+Su1NYNCVk rrJMjpCGKB97iInfMqhn816TuCnId5jDZQFcrxYKsiKFxXw03Ez6b//ucOJOBacS Hrqq85OyN6prLm1FF2bRcqizP7rMPV1bPzy1i00pX3n3XMZI0grqOJa9R8fbkqPQ daTqxfG7E+NDbJB07sqxT5b7AfcOSy8zcdJJ2VhFJ57fKp5tgmBt/Or65vec9KrE Mvw3x7Hx0yEJWgLPKKQW1tqsZ1EJlMYcRvPHLL7AdeYcg+GShI1PjUzXHFKcykxh SW0ape/gZbSZkdIvXdfOnCpG9cHM2SnVJRPd14fsGfZEsOyVSidvAmX3zohKyCxr J5gTsA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnt63t8bf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 05:42:53 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34abec8855aso7829721a91.0 for ; Tue, 13 Jan 2026 21:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768369372; x=1768974172; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VxdvyYzIZyOHUwmxqd8hJRQXBpXJoAEPCSYU7mtFibg=; b=J/6DRws8eWNKJkF0SttomNs8FM7m77MyqPeFJa4nPu7cxfYyjDAR2ZvnWjRZQXi88s gYrVMIVV8XvyLChEd+exRu+CJaRhC63sjqxDuVqgYyEjZLAImcU6A6Eet21+9MiWEuAO C+QaGYJqZSvQvNnmsWx+DoBg7wxOL13gkL2OurCl+0EtTmRsdTykCWqxizb13XPEMSnW kg0jxjJQ82xSqRtSqO/gELBuO2nKLBzRBfoffTXDln/EkWPu30Tl1O2l0DLrEhdt2H5b VJPK/ipqzNsIxmshljJSuKoeuW1C5VIGJBLDCpKUvIlZ0cGRU2sFxW2R9+R8R+Ec7jHv syXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768369372; x=1768974172; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VxdvyYzIZyOHUwmxqd8hJRQXBpXJoAEPCSYU7mtFibg=; b=jYkIYq6Ym7sgP3rZzDieYobRCgxOtH91cXZwVhUSH8uvmMJaCKOZfO4+JoQ264/4Ty OcRu2D9biVQQd8mnvn45MLm06tZ+ghBjqT7X6pUbydU0lw3XoVTk/eU2X+IH6bkRhNui ++nWZCX3ug7Zm4Vr+viMoBSw5U18WNkqEa4dpYs1c2WMdmL46ehyDN6OPeA7k6wa6vtS IaXsHJY4XyZwL/lxd954qqAHo9+0wsN6mFgjgU3juHn3AQxPNUqW1WJ6J/XJTUCidhQ2 aDK1ZKOVS3zSNVZWMNUoGL3/j3R8RezXf+eNeC/8nhdGo8cIDaCW8U8l7DNsCYtTB93m k1bA== X-Forwarded-Encrypted: i=1; AJvYcCVIiJqIjL1lUN2xx78Od32zbBOZXp6od0ViyumKwbdtO4pwDD6c1wg7HpAwMRScKQgC/vLxrITpH1w0bbo=@vger.kernel.org X-Gm-Message-State: AOJu0YxO6+iHYKYKxMLHj0ONyZ489StohXrgpfBQPaMqDKLzyc+1ohci jz1V/2IkcTimdArDm5Txa6B9K6OZyCLxwxrSogY30ejS7vFHkRJ1lprcMKFhHF/gW137jVKucI0 bjqx6LVMfzbzDCf9LCAAtXbfpUKDxmtjp8QyHIgSrYJYFUN4M1CajWAaO9PJqFieXJaI= X-Gm-Gg: AY/fxX7AzKJd6QDoDQb3GHe7jsnIeuERMu+9k+MokGUUEfVtRBz0u1RNf1aoQH+Iw62 tPW/DgAdRttHR8g18WRxFydz6pH1wefTHYRESaineT95q0ZsPl0a2g9moJPCgtkbuwwQdH323DT EVkCPN8w+ds+sqKo6yMsz3z7DgOS6YG+w2OMVQDFi916aiKnvBVa+/tM8sU4s6fRccBCot/4m7W cMjXghftCfbO1MDCzZAkukdsCkAlvKvTkf89S8H5mCQr7SU3WShQJrl0zqN/x0fYRXFyw+vADUv aMIvA0Q+10eXhcpDBIdQYoGH27PLVv3ojTJEPU059UPWoDGvZc/04GJ3PfG7xfckaVO7JvFsf9J W1Bg2qRAYBFuZAVKGX6WGGoQx1HIH4ZBbE7ZC/1DnUpbCEGJN X-Received: by 2002:a17:90b:3806:b0:34c:75d1:6f90 with SMTP id 98e67ed59e1d1-35109129c2bmr1727999a91.17.1768369372421; Tue, 13 Jan 2026 21:42:52 -0800 (PST) X-Received: by 2002:a17:90b:3806:b0:34c:75d1:6f90 with SMTP id 98e67ed59e1d1-35109129c2bmr1727981a91.17.1768369371938; Tue, 13 Jan 2026 21:42:51 -0800 (PST) Received: from [10.151.36.141] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35109c78f20sm784491a91.13.2026.01.13.21.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 21:42:51 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 11:12:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/9] remoteproc: qcom_q6v5_wcss: add native ipq9574 support To: "Alex G." , andersson@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com, linux-remoteproc@vger.kernel.org, Konrad Dybcio Cc: mathieu.poirier@linaro.org, robh@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, sboyd@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20260109043352.3072933-1-mr.nuke.me@gmail.com> <14283f23-31cc-4bf8-9762-f0348c30618d@oss.qualcomm.com> <4814455.tdWV9SEqCh@nukework.gtech> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: <4814455.tdWV9SEqCh@nukework.gtech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA0MSBTYWx0ZWRfXysDo/APi4bMZ 1vbLMEUcfBcOc1uVNv00yemsWBsWgXKyfsE8n/XPp9tTVCqzMEhOpIpuBvv9P/OjIth+TvKd/1x zES64B07qBpM5KxPTnRYP1o1FNFfVXQpFyz0jxnjQat/GOsDE1mVhuVxWvy16UmPeH49omZktp4 /9XJb7pV9UOH9QD4U7Qqy7P4E3cVKYMc8RjZgL4YbYX8nN4HGP+tMFm+5BYwEjZQhOYSF1ED+Vi Cy96mpeJTgnm4IT7I/B1RJ+C0JH3TRcc41I3VEZcuCUhaztQr/8ZbNz+scnyE18scCQAbvRLpNs W9ZMCdwmDMoCXTEVAAbH27L5qoUqQzbZMpbHgCWbnb1Nlo/2+y5/6DSZbn3cJ6ctHpL3qLMrTeK yQdjjkZIpC7khqbDo7RYLW3/3uzMqr34++CMV3vqB+zYMQDX1iIkI0TdfiEPugiKhk66ZGOpa28 FvxIXRFhid1MQkjDpng== X-Proofpoint-ORIG-GUID: qBXb2a0DmbtvI4iOQjtZLdAkcMX6aRdO X-Proofpoint-GUID: qBXb2a0DmbtvI4iOQjtZLdAkcMX6aRdO X-Authority-Analysis: v=2.4 cv=EujfbCcA c=1 sm=1 tr=0 ts=69672cdd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=MOnJJczUH92I72-_oswA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140041 On 1/14/2026 9:24 AM, Alex G. wrote: > On Tuesday, January 13, 2026 8:28:11 AM CST Konrad Dybcio wrote: >> On 1/9/26 5:33 AM, Alexandru Gagniuc wrote: >>> Support loading remoteproc firmware on IPQ9574 with the qcom_q6v5_wcss >>> driver. This firmware is usually used to run ath11k firmware and enable >>> wifi with chips such as QCN5024. >>> >>> When submitting v1, I learned that the firmware can also be loaded by >>> the trustzone firmware. Since TZ is not shipped with the kernel, it >>> makes sense to have the option of a native init sequence, as not all >>> devices come with the latest TZ firmware. >>> >>> Qualcomm tries to assure us that the TZ firmware will always do the >>> right thing (TM), but I am not fully convinced >> >> Why else do you think it's there in the firmware? :( > > A more relevant question is, why do some contributors sincerely believe that > the TZ initialization of Q6 firmware is not a good idea for their use case? > > To answer your question, I think the TZ initialization is an afterthought of > the SoC design. I think it was only after ther the design stage that it was > brought up that a remoteproc on AHB has out-of-band access to system memory, > which poses security concerns to some customers. I think authentication was > implemented in TZ to address that. I also think that in order to prevent clock > glitching from bypassing such verification, they had to move the initialization > sequence in TZ as well. Exactly, the TZ interface is present to address the security concerns. Also, as I mentioned in [1], on some platforms, TZ might access protect the clocks and registers which might prevent the remoteproc bringup and throw an access violation. We can keep this support added for IPQ9574, as it is good to have, but can we keep the default compatible in ipq9574 DTSI to use the TZ interface, which has already picked up an R-b in this series [2]. [1] https://lore.kernel.org/linux-remoteproc/21468f66-56df-43ea-99c2-7257d8d6bb7c@oss.qualcomm.com/T/#m688033ab79c63a8953e38f5575d1c0ff6b37b13a [2] https://lore.kernel.org/linux-remoteproc/20260113092021.1887980-1-varadarajan.narayanan@oss.qualcomm.com/T/#t > > Alex > > > > > >