From: Brad Love <brad@nextdimension.cc>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Brad Love <brad@nextdimension.cc>,
Michael Ira Krufky <mkrufky@linuxtv.org>,
Hans Verkuil <hansverk@cisco.com>, Thomas Meyer <thomas@m3y3r.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type
Date: Thu, 3 May 2018 20:41:07 -0500 [thread overview]
Message-ID: <cfa44c99-3ff7-899e-ad54-af24b0ea5b04@nextdimension.cc> (raw)
In-Reply-To: <20180424131907.5817-1-luc.vanoostenryck@gmail.com>
Acked-by: Brad Love <brad@nextdimension.cc>
On 2018-04-24 08:19, Luc Van Oostenryck wrote:
> The method dvb_frontend_ops::search() is defined as
> returning an 'enum dvbfe_search', but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'enum dvbfe_search' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/media/dvb-frontends/lgdt3306a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
> index 7eb4e1469..32de82447 100644
> --- a/drivers/media/dvb-frontends/lgdt3306a.c
> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
> @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct dvb_frontend *fe,
> return 0;
> }
>
> -static int lgdt3306a_search(struct dvb_frontend *fe)
> +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe)
> {
> enum fe_status status = 0;
> int ret;
prev parent reply other threads:[~2018-05-04 1:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:19 Luc Van Oostenryck
2018-05-04 1:41 ` Brad Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa44c99-3ff7-899e-ad54-af24b0ea5b04@nextdimension.cc \
--to=brad@nextdimension.cc \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®