From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4015418054 for ; Wed, 24 Jan 2024 09:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706090092; cv=none; b=oLVPr6UOIKoj7zkfA2JAcbmB1xydHxJ3Z8/LRakMrDtKf0EeG3WjFoegW2cw/1QPhtVt1S/Pc32BegdBoE7qxU7AtVOwZ0Mla/0uod9hH75g5W8QQ8BijOH7Wgf2zCUuW27vlZu9L3PrGulwfO5tfrxOYOC0YMBCOkItnHbRYEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706090092; c=relaxed/simple; bh=bYZ6BcoUiLvgt9L9SyWiOViDz1Wa3JdvKJ85QZM5CKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gx0bWl6ut5m02K9kh+bug/IoLm3tZ/OZHhcjl+txhcSQLEANX7YifxHVMCQ8X9Wl7FIOoPzW7rGOZNGkakJIa1PDPnAkxIwKhf2qAgkDNe6As16QGEYpTRYM/8kVNQHWTRtrg9NE3pAxNeBb/ocXNr9mPTnh6hKp9OipkK7IJ/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lhx8cX/z; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lhx8cX/z" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-337d05b8942so5992253f8f.3 for ; Wed, 24 Jan 2024 01:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706090088; x=1706694888; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S3GSiQnBTV0mEFAoqjBQs54WUmtsc4sMdeFUUjaDKbM=; b=lhx8cX/z3q3zc2ZQiyz9PV5A+gLMu+b2Uv1E31jVljXYBFL08akwYpo4gh8umehtP4 nxKyODfcnmJx2xuiXAkWDdF8knXk4IWFLXLuLZSsyDnjdWscuxwhxsTrivgDn1FHpGEf upTVO4Mf6RA7/LwhMeWIbOAIzX2oVWHNdfimJ6lImWpJAYtBiGSz+SROxwIeoUNn8SEk hb/sM9hjo/XL7Pg7s9F3WqVuyRlOAcubbq9/w9fgspPD898N5vxYIOWRRIMmITlZ/Jee zy8YHdST0XEu30c+LKO5PVG7j6bEgw2434AxPk1CVCPuJD1HafNmbs3h4uwpJbhrCvB1 FHBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706090088; x=1706694888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3GSiQnBTV0mEFAoqjBQs54WUmtsc4sMdeFUUjaDKbM=; b=t+hYsZV25U/PbEgeEIcIqd7h8xOAH/I+xhieWYxLKxttjaKIl4kI88griHfhDg7UPS aRw1FL/SE3qdLASmp35KdV84zsOIetnN3wRDshsDZRmnGtfsEaD4UyXrZOHOznsP5UlP lKhbwoHBzoA6RXtvYjAJG7udWuu++1MP0zKTINyEp4iulxZYqExr9XsrMzF6+3qRgcjY 3kbMf9H0RGJp6+hoa95FAuxZ0U5ThREdpGAg0lYunhyebgs0fOspos3oVxKrwgl/kAI7 /AssJWreH3n8pHHf5eJFmMHxvWirbbWAVsvtFw3ZSy7OaxkD722XEWxn96VpNVDqKRIm 6WPQ== X-Gm-Message-State: AOJu0YxteZ23fVNkXYaHgJhN4PGp2YTrxswxaRu2PQTObwFsw2p/DeQU AMdP4TYlHXEJ5uRCbWwWztYLTp7FmEuu8bl3UT9MIBtz24l9zHTZWo+XzRnc5Ls= X-Google-Smtp-Source: AGHT+IFpeuF4hWuOGs+LehseKTmKoFf3z77/xE/nT0VhW+XrLS6lAPOETImXeRgTYDlFkrcyXCZZMg== X-Received: by 2002:a05:600c:4195:b0:40e:8a7c:cc1e with SMTP id p21-20020a05600c419500b0040e8a7ccc1emr1091371wmh.147.1706090088469; Wed, 24 Jan 2024 01:54:48 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id u21-20020a05600c139500b0040e4a7a7ca3sm45237569wmf.43.2024.01.24.01.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 01:54:48 -0800 (PST) Message-ID: Date: Wed, 24 Jan 2024 09:54:46 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/21] spi: s3c64xx: add missing blank line after declaration Content-Language: en-US To: Sam Protsenko Cc: broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com References: <20240123153421.715951-1-tudor.ambarus@linaro.org> <20240123153421.715951-17-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/23/24 19:28, Sam Protsenko wrote: > On Tue, Jan 23, 2024 at 9:34 AM Tudor Ambarus wrote: >> >> Add missing blank line after declaration. Move initialization in the >> body of the function. >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/spi/spi-s3c64xx.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index f5474f3b3920..2abf5994080a 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -1273,8 +1273,9 @@ static int s3c64xx_spi_suspend(struct device *dev) >> { >> struct spi_controller *host = dev_get_drvdata(dev); >> struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); >> + int ret; >> >> - int ret = spi_controller_suspend(host); >> + ret = spi_controller_suspend(host); > > Why not just moving the empty line below the declaration block, > keeping the initialization on the variable declaration line? > just a matter of personal preference. I find it ugly to do an initialization at variable declaration and then to immediately check the return value in the body of the function. But I'll do as you say, just cosmetics anyway.