From: Dave Hansen <dave.hansen@intel.com>
To: Borislav Petkov <bp@alien8.de>, Mikhail Paulyshka <me@mixaill.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] x86/rdrand: disable RDSEED on AMD Cyan Skillfish
Date: Tue, 17 Jun 2025 13:21:23 -0700 [thread overview]
Message-ID: <cfb12298-5214-4fc1-859c-2218c7da4ce3@intel.com> (raw)
In-Reply-To: <20250617200551.GIaFHKnyPV_XsSjlMP@fat_crate.local>
On 6/17/25 13:05, Borislav Petkov wrote:
> + /* Disable RDSEED on AMD Cyan Skillfish because of an error. */
> + if (c->x86_model == 0x47 && c->x86_stepping == 0x0) {
> + clear_cpu_cap(c, X86_FEATURE_RDSEED);
> + msr_clear_bit(MSR_AMD64_CPUID_FN_7, 18);
> + pr_emerg("RDSEED is not reliable on this platform; disabling.\n");
> + }
Heh, maybe if x86_init_rdrand() did RDSEED too, this wouldn't have
slipped through QA.
next prev parent reply other threads:[~2025-06-17 20:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 14:53 Mikhail Paulyshka
2025-05-24 16:11 ` Borislav Petkov
2025-06-17 20:05 ` Borislav Petkov
2025-06-17 20:21 ` Dave Hansen [this message]
2025-07-07 10:17 ` Mikhail Paulyshka
2025-07-07 15:25 ` Borislav Petkov
2025-07-07 15:34 ` Dave Hansen
2025-07-06 16:42 ` Mikhail Paulyshka
2025-07-06 17:07 ` Borislav Petkov
2025-07-06 20:31 ` Mikhail Paulyshka
2025-07-08 14:50 ` [tip: x86/urgent] x86/CPU/AMD: Disable INVLPGB on Zen2 tip-bot2 for Mikhail Paulyshka
2025-07-08 19:50 ` tip-bot2 for Mikhail Paulyshka
2025-07-08 14:50 ` [tip: x86/urgent] x86/rdrand: Disable RDSEED on AMD Cyan Skillfish tip-bot2 for Mikhail Paulyshka
2025-07-08 19:50 ` tip-bot2 for Mikhail Paulyshka
2026-01-14 20:52 [PATCH v2 1/1] x86/rdrand: disable " Travis B
2026-01-14 21:28 ` Borislav Petkov
2026-01-14 21:41 ` Travis B
2026-01-14 22:09 ` Travis B
2026-01-15 10:28 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb12298-5214-4fc1-859c-2218c7da4ce3@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=me@mixaill.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®