From: Suman Anna <s-anna@ti.com>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>,
Rob Herring <robh+dt@kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Nishanth Menon <nm@ti.com>, Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example
Date: Mon, 20 Sep 2021 15:57:49 -0500 [thread overview]
Message-ID: <cfb1b8eb-327f-1f2b-9939-df06c9d5f692@ti.com> (raw)
In-Reply-To: <20210920123152.32751-1-sinthu.raja@ti.com>
On 9/20/21 7:31 AM, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> The example includes a board-specific compatible property, this is wrong
> as the example should be board agnostic and should represent the particular
> binding. Also, the file includes two similar examples but with a different
> compatible. So, drop the entire second example
>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
Acked-by: Suman Anna <s-anna@ti.com>
>
> ---
>
> Changes in V3:
> Addressed review comment, that includes adding Suggested By: tag to the
> commit message
>
> V2: https://lore.kernel.org/all/20210917170805.5079-1-sinthu.raja@ti.com/
> V1: https://lore.kernel.org/all/20210917094740.18891-1-sinthu.raja@ti.com/
>
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
> 1 file changed, 1 insertion(+), 32 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> index ae1b37dbee75..0a955c7b9706 100644
> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> @@ -39,39 +39,8 @@ additionalProperties: false
> examples:
>
> - |
> - /* OMAP4 SoCs */
> - hwspinlock: spinlock@4a0f6000 {
> + spinlock@4a0f6000 {
> compatible = "ti,omap4-hwspinlock";
> reg = <0x4a0f6000 0x1000>;
> #hwlock-cells = <1>;
> };
> -
> - - |
> - / {
> - /* K3 AM65x SoCs */
> - model = "Texas Instruments K3 AM654 SoC";
> - compatible = "ti,am654-evm", "ti,am654";
> - #address-cells = <2>;
> - #size-cells = <2>;
> -
> - bus@100000 {
> - compatible = "simple-bus";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
> - <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>; /* Main NavSS */
> -
> - bus@30800000 {
> - compatible = "simple-mfd";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>;
> -
> - spinlock@30e00000 {
> - compatible = "ti,am654-hwspinlock";
> - reg = <0x00 0x30e00000 0x00 0x1000>;
> - #hwlock-cells = <1>;
> - };
> - };
> - };
> - };
>
next prev parent reply other threads:[~2021-09-20 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:31 Sinthu Raja
2021-09-20 20:57 ` Suman Anna [this message]
2021-09-23 13:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb1b8eb-327f-1f2b-9939-df06c9d5f692@ti.com \
--to=s-anna@ti.com \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®