From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795020147; b=j2qk5tc0MNypKlSJUNJu5GA9dFHKBt1ZlkOKvVZZ+1iNMxqdxJQoWUU9CZRX180FoRaX 7RSp1+amvJxTvkuOvPe+t+/NDa8IUtBIO3dO6lO0cmuvg88wCaIAiZ9KImK8BHgosRsOj lQe1KMcC46JFnXt5be1hpTOH2M8DCSKNwuVGaC5lIZmEZWpFjm+xsyfRn+WPO9+cgPz39 jvDXSu5LyjKSv0UqCHGx/571leB3i5wP/fNdSxGSGQY+m7BF8O3dH8S/4INCs47sB3Vu9 3ErxryZutvfXFQrLPnxd65QnguAXuGEnTLmzGX8B95nDhtZoGYm7ZiuXyLbSjYgVk7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795020147; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=Qo/P/wbaNkEjPm8HGz4npHC5JZBaCO0dOmWlqnF5GUA=; b=E287p0qhO3IU9jZT3tsrrqKMplVF7brw9WOf0JiSQOMxoCR+d6Usx9WXxmFxqoU5vCJP 38TfuadelVY4Kr7ZMidLvWoH/E2qBRuqc9YfSWA5liDhpb/GS3AGJK5peP7hKOrAvXO9O tNQTP/EZVJIcJGKcVwFYe3K2eWQxmPJogL2srVyz9aUS4JM0CURzcaT95FKTwIyBD7/rK SwgpQ/qNLpydeqrmNM1u0CWFZLEKqu8/+GBcrdGjfOTpbPuWtjwmCk+HtmIYXYRv0wV6a D+OQOh9nZo5Xl51YbYe8NtfO4knBHTPAXosAfIv9u5YUwG0lmoVmsHs28eY/Y6UEeuA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ursulin.net; spf=pass smtp.mailfrom=ursulin.net; dkim=pass header.d=ursulin.net header.i=@ursulin.net header.a=rsa-sha256 header.s=google header.b="Tk/ZRkDe"; arc=none smtp.remote-ip=209.85.221.47 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30C6606A331 for ; Wed, 18 Nov 2026 16:42:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D30C6606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin.net header.i=@ursulin.net header.a=rsa-sha256 header.s=google header.b=Tk/ZRkDe Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-490f38e9688so15f8f.0 for ; Wed, 18 Nov 2026 08:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin.net; s=google; t=1795020145; x=1795624945; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qo/P/wbaNkEjPm8HGz4npHC5JZBaCO0dOmWlqnF5GUA=; b=Tk/ZRkDev4KXK3QoBw2RLqAbomT0us52EkaZBDylAc0yxZJOKLz/HT+wNKJPx3Qwv4 VweXqPuooVRSFNClGeEp+aXvPzmwI7GfDzVGM5F5yO7Z/ZCjWHD2CdO0v7Q1a+mt1k0n Faw/elrgenKw2nP83PbWfrIsAOfL2Wm784UcGwBDaJK4jhIwb7kWRxPz8IQg8rEXftOm sVvm1LelEi3V5/hpraZHWOSXnWVrg4KiX9/ggTyMyCTsF8h0JIIXdGUs2lgdftxpHOk1 ywtHjdjlCSjQxkNzj/hBy8VA4VIVhAEf3ECmGbQ5DokP9r62663REixmep0lRgpCrbf+ dV5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795020145; x=1795624945; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qo/P/wbaNkEjPm8HGz4npHC5JZBaCO0dOmWlqnF5GUA=; b=du+a3JKyGA/AC/XOcw23rtUHfvW0LU5+oV/JOFb8PYIW8e85Ah3pMzwpVnmfbcli7O OBGA6R6q1uEiWWCt2oQPpUPAGlK737F+zuwT6upCUJg109yNh4uhVxKNxP2GYlhO2k90 HTCFicXLnYvnmkVDu6CCcWgm54Kk2YYKhSw96+XVpy1KcTLqOuzcsiURrzv074PBbDbc Bx1lWc+AbZr4e3HXsX60fbsgQ2IxVt5J02LsMXD1J8LL7x2l02zu/JZB91FnEN9gBatg rV6ATyqaN/6/mB/FF2kBYNuaeP0KnwmfEFjaxf5b8Mw46wPuL9xyuBZPrbujc69H4Eq3 a0Ig== X-Forwarded-Encrypted: i=1; AL+hErHQeWCRfH6n+PNdqfKyXwkKn2C/SDKFpjHtzxj/IXhurWfssHlsqLvKDC4U52NhoergAD2g6+rawjFJZlk=@vger.kernel.org X-Gm-Message-State: APuU4Z/dGJYawyQHX6WGWTEx4vbW7CJ32KPJ3Vv2zq3gA5rnDYzyINva GjSJ3kljkI61mx32j9PoZiUy3BsUHkvkg2/ufVFq4cAXntlADGoI5uMMOlENL17hL+w= X-Gm-Gg: AZFdTZc0HAvX87VY9Pk+bKSsE8rygqZmuSdLgFmAyl43J7dhwbzYY0fko4Cy9axYgNr BYdpw5N25x5Yhsnm/xoQc3mfuajrLLdt0F+BUYYLnLYGW54AgIITJMHo1+LMVtLkczAuWwVd6am OUf135P2U9EIM+ErkKj5Le2WopjGykyXOFA/pQ3E6HUwdDaBVegxWzsOTh7i5DM6XsSBcbEs5Vp N0f8h/XQnItDQ5/VSlRwNGGUf96BlhSa85PvMSBffJz4IIQjrJnyykslovSMa8t5BBxHh2B0m0Q QEvGxdPg/q9D7dt5AmoSeq9hS3/426u+IWYoP8KIXw6DyRWJVZmx6UGUJJ5rNnMDqFRbwh3EtVR MQrP86nNRvKq8ZwHdK0plqAF34S9W2aMD/mNIRmq7aAb9fX6z+sXMah2yy/qd2fn2ztVq0vm6IZ nFrwq5Pcp5POos56kB3BnZCHyeRz4JL2ZXGTWccE21waL6Kc6jQtdRTFQTmhbxWBlohuuOpyX+Q t/oGPmdT8IyfttTJs8/ToBzzpuzOpTZUlpDcmDJVRHcLJ3U1pGeTF5PGPbmxHZNMi211+mRTnNQ VJjKeL0Wh2DJshcAbtBNvfxCpiQIywe4ZIYJ+ofLyH3h8g== X-Received: by 2002:a05:6000:220d:b0:498:6171:c074 with SMTP id ffacd0b85a97d-4a8e39ae958mr149841f8f.3.1795020145028; Wed, 18 Nov 2026 08:42:25 -0800 (PST) Received: from [192.168.0.116] ([81.79.79.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a64b60940csm5630286f8f.0.2026.11.18.08.42.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Nov 2026 08:42:24 -0800 (PST) Message-ID: Date: Wed, 18 Nov 2026 16:42:23 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] accel/rocket: Report NPU usage through fdinfo To: Sidong Yang , Tomeu Vizoso , Oded Gabbay , Philipp Stanner , Danilo Krummrich , Matthew Brost , ckoenig.leichtzumerken@gmail.com Cc: mcanal@igalia.com, Heiko Stuebner , Gyeyoung Baek , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261112171144.3151554-1-sidong.yang@furiosa.ai> <20261112171144.3151554-3-sidong.yang@furiosa.ai> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20261112171144.3151554-3-sidong.yang@furiosa.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/11/2026 17:11, Sidong Yang wrote: > There is no way to tell how much of the NPU a client uses. Implement the > DRM usage stats: report the runtime of the client's scheduler entity as > drm-engine-npu, along with drm_show_memory_stats() for the BOs. > > The cores are identical, so they are reported as a single engine with > drm-engine-capacity-npu set to rdev->max_cores, the number of core > slots. > > Document the keys in the rocket driver documentation. > > Signed-off-by: Sidong Yang > --- > Documentation/accel/rocket/index.rst | 28 +++++++++++++++++++++++++++ > Documentation/gpu/drm-usage-stats.rst | 1 + > drivers/accel/rocket/rocket_drv.c | 21 +++++++++++++++++++- > 3 files changed, 49 insertions(+), 1 deletion(-) > > diff --git a/Documentation/accel/rocket/index.rst b/Documentation/accel/rocket/index.rst > index 70f97bccf100..8ae785b65a53 100644 > --- a/Documentation/accel/rocket/index.rst > +++ b/Documentation/accel/rocket/index.rst > @@ -17,3 +17,31 @@ project. > Hardware currently supported: > > * RK3588 > + > +.. _rocket-usage-stats: > + > +Rocket DRM client usage stats implementation > +============================================ > + > +The accel/rocket driver implements the DRM client usage stats specification as > +documented in :ref:`drm-client-usage-stats`. > + > +The NPU cores are reported as a single engine, npu, with a capacity equal to the > +number of cores. The time is summed over all cores and is accounted by the DRM > +GPU scheduler, from when a job is handed to a core until its fence signals. > + > +Example of the output showing the implemented key value pairs: > + > +:: > + > + pos: 0 > + flags: 02400002 > + mnt_id: 33 > + ino: 755 > + drm-driver: rocket > + drm-client-id: 263 > + drm-engine-npu: 2384122043 ns > + drm-engine-capacity-npu: 3 > + drm-total-memory: 24216 KiB > + drm-shared-memory: 0 > + drm-active-memory: 3000 KiB > diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst > index 70b7cfcc194f..288764730d23 100644 > --- a/Documentation/gpu/drm-usage-stats.rst > +++ b/Documentation/gpu/drm-usage-stats.rst > @@ -218,3 +218,4 @@ Driver specific implementations > * :ref:`panthor-usage-stats` > * :ref:`xe-usage-stats` > * :ref:`amdxdna-usage-stats` > +* :ref:`rocket-usage-stats` > diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocket_drv.c > index 5d7805c41dc3..351be60b1228 100644 > --- a/drivers/accel/rocket/rocket_drv.c > +++ b/drivers/accel/rocket/rocket_drv.c > @@ -3,8 +3,10 @@ > > #include > #include > +#include > #include > #include > +#include > #include > #include > #include > @@ -139,7 +141,23 @@ static const struct drm_ioctl_desc rocket_drm_driver_ioctls[] = { > ROCKET_IOCTL(FINI_BO, fini_bo), > }; > > -DEFINE_DRM_ACCEL_FOPS(rocket_accel_driver_fops); > +static void rocket_show_fdinfo(struct drm_printer *p, struct drm_file *file) > +{ > + struct rocket_device *rdev = to_rocket_device(file->minor->dev); > + struct rocket_file_priv *rocket_priv = file->driver_priv; > + > + drm_printf(p, "drm-engine-npu:\t%llu ns\n", > + drm_sched_entity_get_runtime(&rocket_priv->sched_entity)); > + drm_printf(p, "drm-engine-capacity-npu:\t%u\n", rdev->max_cores); > + > + drm_show_memory_stats(p, file); > +} > + > +static const struct file_operations rocket_accel_driver_fops = { > + .owner = THIS_MODULE, > + DRM_ACCEL_FOPS, > + .show_fdinfo = drm_show_fdinfo, > +}; > > /* > * Rocket driver version: > @@ -150,6 +168,7 @@ static const struct drm_driver rocket_drm_driver = { > .open = rocket_open, > .postclose = rocket_postclose, > .gem_create_object = rocket_gem_create_object, > + .show_fdinfo = rocket_show_fdinfo, > .ioctls = rocket_drm_driver_ioctls, > .num_ioctls = ARRAY_SIZE(rocket_drm_driver_ioctls), > .fops = &rocket_accel_driver_fops, Not knowing rocket, so on a glance, it looks good to me. For the adherence to DRM fdinfo spec at least, which looks completely fine: Acked-by: Tvrtko Ursulin Regards, Tvrtko