From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD06A1B87C9 for ; Wed, 13 May 2026 09:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664825; cv=none; b=NHZm0CkHbgKxQK+mv1oA9C3ddvI+4FJIa55ra5csYZopMmEnBnnxc33/WnqeYUkMn4cOt7Y8VI6Ref4FRf8fDIGg52E0eY7MTu2XE5+Hv3yXETaeod8XqNFovJY7o2ZwQn3KwPuO09ndYzgToiCspVRPqHdku+ao52ElGecLbZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664825; c=relaxed/simple; bh=QfN63W8Ur4ZgNdnr/tF+AgWT6gmJp5CCHd0L+DISOsY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OJ00o/alD/27kD2lQXg6pfh0Zizc272E4uNb538fGoCU2aWDnmJlZFCF35P4B5wMH3wc4KraO0NAN4Ocjnxzj3II4vp/xCFDl1QhTAeNrMYrfL3fHIZRxH6TbGyhSVyE5LplteyOQyr8gfAm9EAQVzUENiPAl+Vgshj3hq7wh5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X0OryaRm; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X0OryaRm" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so44271535e9.1 for ; Wed, 13 May 2026 02:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778664822; x=1779269622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xGesHuAvDA8fba+DIY6ELAjuney/OORm4DuvscE0E4k=; b=X0OryaRmdQbWatyw0GrRMk7119VA2Qn69/OXWEVCQhg0F5ta8mfMGaH7fhaBQ6EaYp +io/8qujQ6ni9sSG1nMHEExyrbAsdCmCpzfSj43EbTwMzr9YwUdYkIzKyvpR/HATSh+n wwy2hGkAyNq6P4vppE0Da5LrhWKqpPCNxprRcN1Y+R81PvAErsR2xxZoIyB/Scf2nbGS bEhdDi5TZcpvfyNpSyS2tDfrgKCmN0BOBgldlvV7ggQ4AHO+2W6Y51yEgNh1JL6wdSmU wrdE9Mozuh4CwAn2i8nH/2Bgf+b0ZMCJeQhNmSgicgk5ehSi+8M98pgIqSdfeKvPpPcz gidg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778664822; x=1779269622; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xGesHuAvDA8fba+DIY6ELAjuney/OORm4DuvscE0E4k=; b=oSu75dW9a+N5Ope3gPzBq/+gdbLB1CvSDyycm/Ixm+8yE77hsxJqhLwkcK6kM4vzo5 ZHr86sbI3jVTEjiQSFswspx/wjGKDLVl35CALftWSiB9MJxwuQXvdEbiSa2i8kamO6qD +HY1QhTcOfhhnqHxcEeGC8sbHSIViux1oivZ/qP3mAeHEij67Da7zkifhWw5D0Vb01zx 8MP8YD/pM/j4WB5w+aiGhtMX7QF5DRVYrPRUcIkTgewByWkUpSv2vCJj5mK2BukAgf7x sZDQmLqx2jvXo8TGiXOZFHIL9eokaTV68WhW4KPEm3VydGsNrzR0uja1bF6BiuVafXuQ RCvw== X-Forwarded-Encrypted: i=1; AFNElJ9QRrXAo1flzfHrq8+8z/fgzFwtdoYYWIS3rpQkquDypDNBI4GSQ8HOurPtrrQ0OG2cq8+um0b4N4HME90=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2STTdFKpq1TnqdssshlHK2WSh6L3+FFQ//sTI74tQ0WOMSl8G JYkdZqEcyFuEbKqgLplBM+dB+pyU43UGiYomURF8cPrByk5K/DIPz2xEPpXX1+Vf6atGSMSEMwP AEv7GbV0= X-Gm-Gg: Acq92OGQLlrNIct1RIYJaCVvq9k0cv0/v7MJtnp/JNKWOFkyMW2ezydZGba/VK1OdZk LygzJbqC7dvlrE8hSvsHLAQgU15IWDvu5JBsg/ENXqzk7A2HTU70WIWTvIuX7l1KuybJJIxFohO L9eMAATzgG8f+CE9WtQMuTYLKzRcXbocp80ypsO+Bwafi8H2PasvgBMMmBGaRbMs2ThHRfYhyYd 8yAfgefMSZ+CGLGbNB0wEm7QyN5UVq2uBP1d29iA2tUK5+RAwkchNvkrExZysnoDsWs4rvQg4lF B4mQtdaGs3MnBHDA8bKCStUWrzFEMJ9AzMVisDeLLGJXIduQoVCVoFKlX278DKNHWVv5lNlWkH9 mcIwUkGPPRmmRe04eZW4SZb7plRHHb9F6VMC8XN6kQxV2tQLFmeXsh/ysTxMGNp7wMZgDcG6Pmk kUTYCOyAmqRKlnYki3oqHGWbHKFgao X-Received: by 2002:a05:600c:1990:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48fc9966d5cmr32956555e9.14.1778664822176; Wed, 13 May 2026 02:33:42 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f40e340sm57201465e9.6.2026.05.13.02.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 02:33:41 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 10:33:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: trbe: Hide enable_sink sysfs file To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260507-james-cs-hide-trbe-enable-v1-1-b4e40439f44c@linaro.org> <20260513081551.GC34802@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260513081551.GC34802@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/05/2026 9:15 am, Leo Yan wrote: > On Thu, May 07, 2026 at 11:53:45AM +0100, James Clark wrote: > > [...] > >> +static umode_t coresight_attr_is_visible(struct kobject *kobj, >> + struct attribute *attr, int n) >> { >> struct device *dev = kobj_to_dev(kobj); >> + struct coresight_device *csdev = to_coresight_device(dev); >> >> if (attr == &dev_attr_label.attr) { >> if (fwnode_property_present(dev_fwnode(dev), "label")) >> return attr->mode; >> else >> return 0; >> + } else if (attr == &dev_attr_enable_sink.attr || >> + attr == &dev_attr_enable_source.attr) { >> + if (csdev->no_sysfs_mode) >> + return 0; >> + else >> + return attr->mode; > > I'd prefer no_sysfs_mode to work as a general flag rather than being > limited to sink/source devices only. Otherwise, LGTM. > > Thanks, > Leo Which other files would you hide though? These are the only two that I could think of. I wouldn't hide all sysfs files for 'no_sysfs_mode' as there are read only things that aren't strictly related to sysfs mode.