mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 32/33] sched/deadline: Check the runtime of a task whose parameters change
Date: Fri, 20 Nov 2026 14:44:19 -0500	[thread overview]
Message-ID: <cfb5b270-8b9a-455c-85c0-d421c2ea102e@efficios.com> (raw)
In-Reply-To: <sashiko-outbox-225415@kernel.org>

[ Sorry, I replied with the wrong content in the previous email for that
  topics. ]

> Does dl_in_constrained_gap() (as well as dl_check_constrained_dl() and
> update_dl_entity()) mix the old dl_se->deadline with the newly overwritten
> dl_se->dl_deadline and dl_se->dl_period?

Your first case is not a bug. The task is implicit after the change.
update_dl_entity() then applies the wakeup rule of an implicit task. A
new period moves the deadline too, as at any wakeup.

Your second case: yes. It is older than this series: v7.4-rc2 also
finds the start of the period from deadline - dl_deadline. v10 will
keep the start of the period in a new field, period_start. The new
patch is "sched/deadline: Keep the start of the period across a change
of dl_deadline". A new case, wake_after_deadline_shrunk, will test it. It
fails without the fix.

> Can rt_mutex_setprio() skip dl_deboost() by comparing pi_task->dl.deadline
> against p->dl.deadline before dl_deboost() updates p->dl.deadline?

Yes, by reading. In v10, rt_mutex_setprio() will deboost a task with
new parameters first. dl_deboost() then checks them, and the waiter is
compared with the deadline that comes out. A new case,
boost_new_params_stale, will test it. It fails without the fix.

> When dl_deboost() returns early on dl_in_constrained_gap(dl_se) for a
> running task (or when sched_setattr() puts a running task into a
> constrained gap), who calls resched_curr(rq) after enqueue_dl_entity()
> throttles it?

Nobody. It is older than this series. On v7.4-rc2, any change of a
running constrained task in its gap gets there. sched_setattr(), an
affinity change and a cgroup move all do. v10 will fix it in a new patch,
"sched/deadline: Reschedule a running task throttled at its enqueue".
dl_check_constrained_dl() will call resched_curr() for the running
task. A new case, constrained_gap_change_running, will test it. It
fails without the fix.

> Does returning early on dl_in_constrained_gap(dl_se) in dl_deboost() (and
> prio_changed_dl()), or calling update_dl_entity(dl_se) unconditionally
> afterward, break PI boosting and sleeping tasks?

First: yes. v7.4-rc2 also compares the waiter with the expired deadline
of the owner. v10 will compare the waiter with the deadline that the
owner would run on. A new patch will do that: "sched/deadline: Boost an
owner that cannot run on its own reservation". An owner that is
throttled, or in its constrained gap, cannot run on its own reservation.
So any deadline waiter boosts it. New cases, pi_owner_asleep_in_gap and
pi_owner_throttled, will test it. Both fail without the fix.

Second: yes. v7.4-rc2 sorts such a waiter the same way. It is your
second finding on patch 26. v10 will list it as a known limit.

Third: yes. In v10, dl_deboost() will check the new parameters only for
a task that is queued or blocked on an rt_mutex. A task asleep on
anything else keeps the check for its wakeup. A new case,
deboost_asleep_new_params, will test it. It fails without the fix.

> When update_dl_entity() here (or in prio_changed_dl()) starts a new period
> for an unboosted rt_mutex owner and pushes p->dl.deadline past its top
> waiter's deadline, does anything PI-boost p with that waiter?

No. This is how a boost works, here and on v7.4-rc2. A boost never
gives the owner the deadline of its waiter. It stops the throttle, and
the refills use the donor's parameters. So EDF can rank an owner after
its waiter after any new period, not only after a change of parameters.
v10 will not change this.

> Should switched_to_dl() also handle p->dl.dl_new_params for a task blocked
> on an rt_mutex?

Yes, by reading. v10 will check the new parameters of a blocked task in
sched_setattr() itself, in a new helper, dl_check_blocked_params(). It
also runs when the task comes back to the class, and clears the mark.
rt_mutex_adjust_pi() then requeues the waiter. A new case,
setattr_blocked_reenter, will test it. It fails without the fix.

> Can consuming p->dl.dl_new_params in prio_changed_dl() desynchronize
> p->dl.deadline from the task's rt_mutex waiter node when prio_changed_dl()
> is reached from callers other than __sched_setscheduler()?

Yes, by reading. The same helper fixes it. v10 will remove the check
from prio_changed_dl(). A mark left for later is then consumed only at
the wakeup enqueue or at the deboost. No case will test it. It needs a
boost or a gap to end while the task stays blocked, then a move.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

  parent reply	other threads:[~2026-11-20 19:44 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 13:55 [PATCH v9 00/33] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 01/33] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 02/33] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 03/33] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 04/33] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 05/33] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 06/33] selftests/sched: Test the root domain rebuild in deadline_bw_test Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 07/33] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 08/33] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 09/33] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 10/33] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 11/33] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 12/33] selftests/sched: Test cpuset moves in deadline_bw_test Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 13/33] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 14/33] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 15/33] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-20 14:12   ` sashiko-bot
2026-11-20 19:36     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 16/33] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-20 14:31   ` sashiko-bot
2026-11-20 19:37     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 17/33] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-20 14:32   ` sashiko-bot
2026-11-20 19:38     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 18/33] selftests/sched: Test the root domain of a task in deadline_bw_test Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 19/33] sched/deadline: Count only active CPUs when spreading extra_bw Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 20/33] rtmutex: Continue the chain walk when a waiter's deadline donor changes Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 21/33] rtmutex: Continue the walk when the owner's top waiter changes lock Mathieu Desnoyers
2026-11-20 14:20   ` sashiko-bot
2026-11-20 19:39     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 22/33] selftests/sched: Test the rtmutex chain walk in deadline_bw_test Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 23/33] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 24/33] sched/deadline: Replenish a throttled task boosted while asleep Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 25/33] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 26/33] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-20 14:39   ` sashiko-bot
2026-11-20 19:40     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 27/33] sched/deadline: Start a period at a deboost out of the class Mathieu Desnoyers
2026-11-20 14:27   ` sashiko-bot
2026-11-20 19:42     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 28/33] selftests/sched: Test deadline boosts in deadline_bw_test Mathieu Desnoyers
2026-11-20 14:26   ` sashiko-bot
2026-11-20 19:42     ` Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 29/33] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 30/33] sched/deadline: Cap the runtime left of a constrained task at dl_runtime Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 31/33] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-20 13:55 ` [PATCH v9 32/33] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-20 14:58   ` sashiko-bot
2026-11-20 19:41     ` Mathieu Desnoyers
2026-11-20 19:44     ` Mathieu Desnoyers [this message]
2026-11-20 13:55 ` [PATCH v9 33/33] selftests/sched: Test parameter changes in deadline_bw_test Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb5b270-8b9a-455c-85c0-d421c2ea102e@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®