From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934069AbcI0L6w (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Sep 2016 07:58:52 -0400
Received: from eusmtp01.atmel.com ([212.144.249.243]:25052 "EHLO
        eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933877AbcI0L6S (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Sep 2016 07:58:18 -0400
Subject: Re: [PATCH] ARM: at91: pm: remove useless extern definition
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
References: <20160927103715.26785-1-alexandre.belloni@free-electrons.com>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        Wenyou Yang <wenyou.yang@atmel.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <cfbb320a-4fc1-4e00-5ceb-632bf0a3da67@atmel.com>
Date: Tue, 27 Sep 2016 13:58:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160927103715.26785-1-alexandre.belloni@free-electrons.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.145.133.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 27/09/2016 à 12:37, Alexandre Belloni a écrit :
> at91_ramc_base is local to pm.c, remove its definition in pm.h
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>  arch/arm/mach-at91/pm.c | 2 +-
>  arch/arm/mach-at91/pm.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index b4332b727e9c..3d89b7905bd9 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -55,7 +55,7 @@ static struct {
>  	int memctrl;
>  } at91_pm_data;
>  
> -void __iomem *at91_ramc_base[2];
> +static void __iomem *at91_ramc_base[2];
>  
>  static int at91_pm_valid_state(suspend_state_t state)
>  {
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 3fcf8810f14e..bf980c6ef294 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -18,8 +18,6 @@
>  #include <soc/at91/at91sam9_sdramc.h>
>  
>  #ifndef __ASSEMBLY__
> -extern void __iomem *at91_ramc_base[];
> -
>  #define at91_ramc_read(id, field) \
>  	__raw_readl(at91_ramc_base[id] + field)
>  
> 


-- 
Nicolas Ferre